From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC 08/31] tools/stubs: Expose host
 featureset to userspace
Date: Tue, 5 Jan 2016 15:59:05 +0000
Message-ID: <568BE849.9040309@citrix.com>
References: <1450301073-28191-1-git-send-email-andrew.cooper3@citrix.com>
	<1450301073-28191-9-git-send-email-andrew.cooper3@citrix.com>
	<1452008194.13361.329.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1452008194.13361.329.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>, David Scott <dave@recoil.org>
List-Id: xen-devel@lists.xenproject.org

On 05/01/16 15:36, Ian Campbell wrote:
> On Wed, 2015-12-16 at 21:24 +0000, Andrew Cooper wrote:
>> diff --git a/tools/libxc/xc_misc.c b/tools/libxc/xc_misc.c
>> index c613545..4d7af3d 100644
>> --- a/tools/libxc/xc_misc.c
>> +++ b/tools/libxc/xc_misc.c
>> @@ -718,6 +718,33 @@ int xc_hvm_inject_trap(
>>      return rc;
>>  }
>>  
>> +int xc_get_featureset(xc_interface *xch, uint32_t index,
>> +                      uint32_t *nr_features, uint32_t *featureset)
> This looks like a valid binding to the hypercall iface, so once that is
> agreed this LGTM.
>
>> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> index b7de615..a47473b 100644
>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> @@ -1220,6 +1220,41 @@ CAMLprim value
>> stub_xc_domain_deassign_device(value xch, value domid, value desc
>>  	CAMLreturn(Val_unit);
>>  }
>>  
>> +CAMLprim value stub_xc_get_featureset(value xch, value idx)
>> +{
>> +	CAMLparam2(xch, idx);
>> +	CAMLlocal1(bitmap_val);
>> +
>> +	/* Safe, because of the global ocaml lock. */
>> +	static uint32_t fs_len;
>> +
>> +	if (fs_len == 0)
>> +	{
>> +		int ret = xc_get_featureset(_H(xch), 0, &fs_len, NULL);
>> +
>> +		if (ret || (fs_len == 0))
>> +			failwith_xc(_H(xch));
>> +	}
> This confuses me because I had thought when reading the previous patch that
> the output nr_features would depend on the specific index, is that not the
> case? Maybe this is just a hypercall docs fix?

nr_features is compile-time-constant in Xen, and every featureset handed
back will be of that length.

It is expected to grow given new changes to Xen, but won't change at
runtime.

~Andrew