On 01/05/2016 08:32 AM, Eric Blake wrote: >> >> However, docs/qapi-code-gen.txt should be updated in a follow-up patch. > > D'oh - I knew I'd forget something :) You're right, of course. For that matter, several recent patches have tweaked generated code without updating the docs, such as 9f08c8ec dropping the automatic creation of a corresponding UserDefOneList type for the example as given. I'll bring it back in sync, but now I have to decide how much (or how little) to actually demonstrate in the docs (qapi-schema-test.json is a much more thorough testing mechanism for all the corner cases; the docs only have to demonstrate a couple of common examples). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org