From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbcAEXqj (ORCPT ); Tue, 5 Jan 2016 18:46:39 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:42343 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbcAEXqg (ORCPT ); Tue, 5 Jan 2016 18:46:36 -0500 Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery To: "H. Nikolaus Schaller" , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King References: CC: , , , From: Nishanth Menon Message-ID: <568C5451.8070709@ti.com> Date: Tue, 5 Jan 2016 17:40:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote: > tested on OMP5432 EVM > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap5-board-common.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > index 5cf76a1..30c0d3b 100644 > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > @@ -358,6 +358,14 @@ > #clock-cells = <0>; > }; > > + rtc { > + compatible = "ti,palmas-rtc"; > + interrupt-parent = <&palmas>; > + interrupts = <8 IRQ_TYPE_NONE>; IRQ_TYPE_NONE is not correct here -> it should have some polarity - if it had none, there'd be no interrupt, right? > + ti,backup-battery-chargeable; > + ti,backup-battery-charge-high-current; > + }; > + > palmas_pmic { > compatible = "ti,palmas-pmic"; > interrupt-parent = <&palmas>; > -- Regards, Nishanth Menon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Date: Tue, 5 Jan 2016 17:40:01 -0600 Message-ID: <568C5451.8070709@ti.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "H. Nikolaus Schaller" , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King Cc: linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, marek@goldelico.com List-Id: devicetree@vger.kernel.org On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote: > tested on OMP5432 EVM > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap5-board-common.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi > index 5cf76a1..30c0d3b 100644 > --- a/arch/arm/boot/dts/omap5-board-common.dtsi > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi > @@ -358,6 +358,14 @@ > #clock-cells = <0>; > }; > > + rtc { > + compatible = "ti,palmas-rtc"; > + interrupt-parent = <&palmas>; > + interrupts = <8 IRQ_TYPE_NONE>; IRQ_TYPE_NONE is not correct here -> it should have some polarity - if it had none, there'd be no interrupt, right? > + ti,backup-battery-chargeable; > + ti,backup-battery-charge-high-current; > + }; > + > palmas_pmic { > compatible = "ti,palmas-pmic"; > interrupt-parent = <&palmas>; > -- Regards, Nishanth Menon