From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbcAFBsU (ORCPT ); Tue, 5 Jan 2016 20:48:20 -0500 Received: from regular1.263xmail.com ([211.150.99.133]:49625 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbcAFBsR (ORCPT ); Tue, 5 Jan 2016 20:48:17 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <0a67c7d86a9db50b48e185d90d6245ed> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <568C7258.3010104@rock-chips.com> Date: Wed, 06 Jan 2016 09:48:08 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, airlied@linux.ie, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> In-Reply-To: <1450842215-10883-1-git-send-email-zyw@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年12月23日 11:43, Chris Zhong wrote: > +static int dw_mipi_dsi_register(struct drm_device *drm, > + struct dw_mipi_dsi *dsi) > +{ > + struct drm_encoder *encoder = &dsi->encoder; > + struct drm_connector *connector = &dsi->connector; > + struct device *dev = dsi->dev; > + int ret; > + > + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, > + dev->of_node); > + /* > + * If we failed to find the CRTC(s) which this encoder is > + * supposed to be connected to, it's because the CRTC has > + * not been registered yet. Defer probing, and hope that > + * the required CRTC is added later. > + */ > + if (encoder->possible_crtcs == 0) > + return -EPROBE_DEFER; > + > + drm_encoder_helper_add(&dsi->encoder, > + &dw_mipi_dsi_encoder_helper_funcs); > + ret = drm_encoder_init(drm, &dsi->encoder, &dw_mipi_dsi_encoder_funcs, > + DRM_MODE_ENCODER_DSI); > + if (ret) { > + dev_err(dev, "Failed to initialize encoder with drm\n"); > + return ret; > + } > + > + drm_connector_helper_add(connector, > + &dw_mipi_dsi_connector_helper_funcs); > + > + drm_connector_init(drm, &dsi->connector, > + &dw_mipi_dsi_atomic_connector_funcs, > + DRM_MODE_CONNECTOR_DSI); > + Hi Chris I try to pick your patches, but found following issues: drivers/gpu/drm/rockchip/dw-mipi-dsi.c: 在函数‘dw_mipi_dsi_register’中: drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: 错误： 提供给函数 ‘drm_encoder_init’的实参太少 include/drm/drm_crtc.h:2220:5: 附注： 在此声明 make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] 错误 1 Can you rebase to newest Dave's drm-next and fix this problem? Thanks. -- Ｍark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI Date: Wed, 06 Jan 2016 09:48:08 +0800 Message-ID: <568C7258.3010104@rock-chips.com> References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1450842215-10883-1-git-send-email-zyw@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Zhong , heiko@sntech.de, linux-rockchip@lists.infradead.org, treding@nvidia.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNeW5tDEy5pyIMjPml6UgMTE6NDMsIENocmlzIFpob25nIHdyb3RlOgo+ICtzdGF0aWMg aW50IGR3X21pcGlfZHNpX3JlZ2lzdGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0sCj4gKwkJCQkg ICAgICBzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSkKPiArewo+ICsJc3RydWN0IGRybV9lbmNvZGVy ICplbmNvZGVyID0gJmRzaS0+ZW5jb2RlcjsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25u ZWN0b3IgPSAmZHNpLT5jb25uZWN0b3I7Cj4gKwlzdHJ1Y3QgZGV2aWNlICpkZXYgPSBkc2ktPmRl djsKPiArCWludCByZXQ7Cj4gKwo+ICsJZW5jb2Rlci0+cG9zc2libGVfY3J0Y3MgPSBkcm1fb2Zf ZmluZF9wb3NzaWJsZV9jcnRjcyhkcm0sCj4gKwkJCQkJCQkgICAgIGRldi0+b2Zfbm9kZSk7Cj4g KwkvKgo+ICsJICogSWYgd2UgZmFpbGVkIHRvIGZpbmQgdGhlIENSVEMocykgd2hpY2ggdGhpcyBl bmNvZGVyIGlzCj4gKwkgKiBzdXBwb3NlZCB0byBiZSBjb25uZWN0ZWQgdG8sIGl0J3MgYmVjYXVz ZSB0aGUgQ1JUQyBoYXMKPiArCSAqIG5vdCBiZWVuIHJlZ2lzdGVyZWQgeWV0LiAgRGVmZXIgcHJv YmluZywgYW5kIGhvcGUgdGhhdAo+ICsJICogdGhlIHJlcXVpcmVkIENSVEMgaXMgYWRkZWQgbGF0 ZXIuCj4gKwkgKi8KPiArCWlmIChlbmNvZGVyLT5wb3NzaWJsZV9jcnRjcyA9PSAwKQo+ICsJCXJl dHVybiAtRVBST0JFX0RFRkVSOwo+ICsKPiArCWRybV9lbmNvZGVyX2hlbHBlcl9hZGQoJmRzaS0+ ZW5jb2RlciwKPiArCQkJICAgICAgICZkd19taXBpX2RzaV9lbmNvZGVyX2hlbHBlcl9mdW5jcyk7 Cj4gKwlyZXQgPSBkcm1fZW5jb2Rlcl9pbml0KGRybSwgJmRzaS0+ZW5jb2RlciwgJmR3X21pcGlf ZHNpX2VuY29kZXJfZnVuY3MsCj4gKwkJCSBEUk1fTU9ERV9FTkNPREVSX0RTSSk7Cj4gKwlpZiAo cmV0KSB7Cj4gKwkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBlbmNvZGVyIHdp dGggZHJtXG4iKTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiArCWRybV9jb25uZWN0b3Jf aGVscGVyX2FkZChjb25uZWN0b3IsCj4gKwkJCSZkd19taXBpX2RzaV9jb25uZWN0b3JfaGVscGVy X2Z1bmNzKTsKPiArCj4gKwlkcm1fY29ubmVjdG9yX2luaXQoZHJtLCAmZHNpLT5jb25uZWN0b3Is Cj4gKwkJCSAgICZkd19taXBpX2RzaV9hdG9taWNfY29ubmVjdG9yX2Z1bmNzLAo+ICsJCQkgICBE Uk1fTU9ERV9DT05ORUNUT1JfRFNJKTsKPiArCkhpIENocmlzCgpJIHRyeSB0byBwaWNrIHlvdXIg cGF0Y2hlcywgYnV0IGZvdW5kIGZvbGxvd2luZyBpc3N1ZXM6Cgpkcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvZHctbWlwaS1kc2kuYzog5Zyo5Ye95pWw4oCYZHdfbWlwaV9kc2lfcmVnaXN0ZXLigJnk uK06CmRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jOjEwMjQ6NTog6ZSZ6K+v 77yaIOaPkOS+m+e7meWHveaVsCAK4oCYZHJtX2VuY29kZXJfaW5pdOKAmeeahOWunuWPguWkquWw kQppbmNsdWRlL2RybS9kcm1fY3J0Yy5oOjIyMjA6NTog6ZmE5rOo77yaIOWcqOatpOWjsOaYjgpt YWtlWzRdOiAqKiogW2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5vXSDplJno r68gMQoKQ2FuIHlvdSByZWJhc2UgdG8gbmV3ZXN0IERhdmUncyBkcm0tbmV4dCBhbmQgZml4IHRo aXMgcHJvYmxlbT8KClRoYW5rcy4KCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Wed, 06 Jan 2016 09:48:08 +0800 Subject: [PATCH v6.3 4/6] drm: rockchip: Support Synopsys DW MIPI DSI In-Reply-To: <1450842215-10883-1-git-send-email-zyw@rock-chips.com> References: <1450260616-21160-5-git-send-email-zyw@rock-chips.com> <1450842215-10883-1-git-send-email-zyw@rock-chips.com> Message-ID: <568C7258.3010104@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?12?23? 11:43, Chris Zhong wrote: > +static int dw_mipi_dsi_register(struct drm_device *drm, > + struct dw_mipi_dsi *dsi) > +{ > + struct drm_encoder *encoder = &dsi->encoder; > + struct drm_connector *connector = &dsi->connector; > + struct device *dev = dsi->dev; > + int ret; > + > + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, > + dev->of_node); > + /* > + * If we failed to find the CRTC(s) which this encoder is > + * supposed to be connected to, it's because the CRTC has > + * not been registered yet. Defer probing, and hope that > + * the required CRTC is added later. > + */ > + if (encoder->possible_crtcs == 0) > + return -EPROBE_DEFER; > + > + drm_encoder_helper_add(&dsi->encoder, > + &dw_mipi_dsi_encoder_helper_funcs); > + ret = drm_encoder_init(drm, &dsi->encoder, &dw_mipi_dsi_encoder_funcs, > + DRM_MODE_ENCODER_DSI); > + if (ret) { > + dev_err(dev, "Failed to initialize encoder with drm\n"); > + return ret; > + } > + > + drm_connector_helper_add(connector, > + &dw_mipi_dsi_connector_helper_funcs); > + > + drm_connector_init(drm, &dsi->connector, > + &dw_mipi_dsi_atomic_connector_funcs, > + DRM_MODE_CONNECTOR_DSI); > + Hi Chris I try to pick your patches, but found following issues: drivers/gpu/drm/rockchip/dw-mipi-dsi.c: ????dw_mipi_dsi_register??: drivers/gpu/drm/rockchip/dw-mipi-dsi.c:1024:5: ??? ????? ?drm_encoder_init?????? include/drm/drm_crtc.h:2220:5: ??? ???? make[4]: *** [drivers/gpu/drm/rockchip/dw-mipi-dsi.o] ?? 1 Can you rebase to newest Dave's drm-next and fix this problem? Thanks. -- ?ark Yao