From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbcAFIX0 (ORCPT ); Wed, 6 Jan 2016 03:23:26 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:3126 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbcAFIXX (ORCPT ); Wed, 6 Jan 2016 03:23:23 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Wed, 06 Jan 2016 00:19:08 -0800 Message-ID: <568CCCA2.4040004@nvidia.com> Date: Wed, 6 Jan 2016 13:43:22 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: "H. Nikolaus Schaller" , Nishanth Menon CC: =?windows-1252?Q?Beno=EEt_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Russell King" , linux-omap , , LKML , "Marek Belisko" Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery References: <568C5451.8070709@ti.com> In-Reply-To: X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL102.nvidia.com (10.25.59.20) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote: > Hi, > > Am 06.01.2016 um 00:40 schrieb Nishanth Menon : > >> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote: >>> + rtc { >>> + compatible = "ti,palmas-rtc"; >>> + interrupt-parent = <&palmas>; >>> + interrupts = <8 IRQ_TYPE_NONE>; >> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if >> it had none, there'd be no interrupt, right? > Well, it just translates IRQ_TYPE_NONE through > > Linux/include/dt-bindings/interrupt-controller/irq.h > > to > > interrupts = <8 0>; > > which is given as an example in > > Documentation//devicetree/bindings/rtc/rtc-palmas.txt > > Since I don't know anything about the rtc driver beyond the bindings documentation I assume it is correct... > I have added Laxman Dewangan because he introduced this interrupts = <8 0>; > As this is for palmas interrupt controller, it does not use the second field for interrupt from RTC. So there is no really any polarity. It can be set to 0. The second argument will be used for GPIOs mainly. However, support need to be added on GPIO driver for rising/falling configuration. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery Date: Wed, 6 Jan 2016 13:43:22 +0530 Message-ID: <568CCCA2.4040004@nvidia.com> References: <568C5451.8070709@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Nikolaus Schaller" , Nishanth Menon Cc: =?windows-1252?Q?Beno=EEt_Cousson?= , Tony Lindgren , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux-omap , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, LKML , Marek Belisko List-Id: devicetree@vger.kernel.org On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote: > Hi, > > Am 06.01.2016 um 00:40 schrieb Nishanth Menon : > >> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote: >>> + rtc { >>> + compatible = "ti,palmas-rtc"; >>> + interrupt-parent = <&palmas>; >>> + interrupts = <8 IRQ_TYPE_NONE>; >> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if >> it had none, there'd be no interrupt, right? > Well, it just translates IRQ_TYPE_NONE through > > Linux/include/dt-bindings/interrupt-controller/irq.h > > to > > interrupts = <8 0>; > > which is given as an example in > > Documentation//devicetree/bindings/rtc/rtc-palmas.txt > > Since I don't know anything about the rtc driver beyond the bindings documentation I assume it is correct... > I have added Laxman Dewangan because he introduced this interrupts = <8 0>; > As this is for palmas interrupt controller, it does not use the second field for interrupt from RTC. So there is no really any polarity. It can be set to 0. The second argument will be used for GPIOs mainly. However, support need to be added on GPIO driver for rising/falling configuration. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html