All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 09/15] IB/srpt: Fix srpt_close_session()
Date: Wed, 6 Jan 2016 16:46:14 +0200	[thread overview]
Message-ID: <568D28B6.5040301@dev.mellanox.co.il> (raw)
In-Reply-To: <568D25D9.3050809-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>



On 06/01/2016 16:34, Bart Van Assche wrote:
> On 01/06/2016 03:21 PM, Sagi Grimberg wrote:
>>> Avoid that srpt_close_session() waits if it doesn't have to wait.
>>
>> Can you explain when it doesn't have to wait? is it possible that
>> srpt_release_channel_work() was already triggered? isn't that a problem?
>
> Hello Sagi,
>
> The target core can decide to shut down an RDMA channel or a channel
> shutdown can be the result of the reception of a DREQ message. It is in
> the latter case that srpt_release_channel_work() can have finished
> before srpt_close_session() is called.

I understood that, and the reason I asked was because of the fact that
you dereference the ch while the channel release is ongoing...

Further reading tells me this is handled in patch 15 "IB/srpt: Fix a
rare crash in srpt_close_session()" correct?

If so, should it come before this patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-01-06 14:46 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 14:19 [PATCH 00/15] Various ib_srpt patches Bart Van Assche
     [not found] ` <568BD0FC.70207-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-05 14:20   ` [PATCH 01/15] IB/srpt: Add parentheses around sizeof argument Bart Van Assche
     [not found]     ` <568BD142.3070900-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  4:58       ` Christoph Hellwig
2016-01-06 13:58       ` Sagi Grimberg
2016-01-05 14:21   ` [PATCH 02/15] IB/srpt: Inline srpt_sdev_name() Bart Van Assche
     [not found]     ` <568BD15F.6010909-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  4:58       ` Christoph Hellwig
2016-01-06 13:58       ` Sagi Grimberg
2016-01-05 14:21   ` [PATCH 03/15] IB/srpt: Inline srpt_get_ch_state() Bart Van Assche
     [not found]     ` <568BD181.5040009-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  4:58       ` Christoph Hellwig
2016-01-06 13:59       ` Sagi Grimberg
2016-01-05 14:22   ` [PATCH 04/15] IB/srpt: Introduce target_reverse_dma_direction() Bart Van Assche
     [not found]     ` <568BD19C.6060404-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  4:59       ` Christoph Hellwig
2016-01-06 14:00       ` Sagi Grimberg
2016-01-05 14:22   ` [PATCH 05/15] IB/srpt: Use scsilun_to_int() Bart Van Assche
     [not found]     ` <568BD1B6.4090308-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  4:59       ` Christoph Hellwig
2016-01-06 14:01       ` Sagi Grimberg
2016-01-05 14:23   ` [PATCH 06/15] IB/srpt: Simplify srpt_handle_tsk_mgmt() Bart Van Assche
     [not found]     ` <568BD1D2.1030609-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:00       ` Christoph Hellwig
2016-01-06 14:02       ` Sagi Grimberg
2016-01-26 16:57       ` Estrin, Alex
     [not found]         ` <F3529576D8E232409F431C309E29399328F6B06A-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-01-26 17:32           ` Bart Van Assche
     [not found]             ` <56A7ADA3.5080507-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-26 18:35               ` Estrin, Alex
     [not found]                 ` <F3529576D8E232409F431C309E29399328F6B0C3-8k97q/ur5Z1cIJlls4ac1rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-01-26 18:46                   ` Bart Van Assche
     [not found]                     ` <56A7BF23.1060306-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-26 18:52                       ` Estrin, Alex
2016-01-05 14:23   ` [PATCH 07/15] IB/srpt: Simplify channel state management Bart Van Assche
     [not found]     ` <568BD1F1.5050107-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:01       ` Christoph Hellwig
2016-01-06 14:08       ` Sagi Grimberg
2016-01-05 14:24   ` [PATCH 08/15] IB/srpt: Simplify srpt_shutdown_session() Bart Van Assche
     [not found]     ` <568BD20F.7020101-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:07       ` Christoph Hellwig
2016-01-06 14:13       ` Sagi Grimberg
2016-01-05 14:24   ` [PATCH 09/15] IB/srpt: Fix srpt_close_session() Bart Van Assche
     [not found]     ` <568BD231.10205-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:08       ` Christoph Hellwig
2016-01-06 14:21       ` Sagi Grimberg
     [not found]         ` <568D22F6.4050803-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-06 14:34           ` Bart Van Assche
     [not found]             ` <568D25D9.3050809-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06 14:46               ` Sagi Grimberg [this message]
2016-01-05 14:25   ` [PATCH 10/15] IB/srpt: Fix srpt_handle_cmd() error paths Bart Van Assche
     [not found]     ` <568BD249.1000100-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:09       ` Christoph Hellwig
2016-01-06 14:31       ` Sagi Grimberg
     [not found]         ` <568D2553.8050302-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-06 14:36           ` Bart Van Assche
2016-01-05 14:25   ` [PATCH 11/15] IB/srpt: Fix how aborted commands are processed Bart Van Assche
     [not found]     ` <568BD26D.9080003-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:13       ` Christoph Hellwig
     [not found]         ` <20160106051305.GK15574-jcswGhMUV9g@public.gmane.org>
2016-01-06 13:30           ` Bart Van Assche
2016-01-05 14:26   ` [PATCH 12/15] IB/srpt: Eliminate srpt_find_channel() Bart Van Assche
     [not found]     ` <568BD28E.40302-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:15       ` Christoph Hellwig
2016-01-06 14:33       ` Sagi Grimberg
2016-01-05 14:26   ` [PATCH 13/15] IB/srpt: Detect session shutdown reliably Bart Van Assche
     [not found]     ` <568BD2A9.6070600-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:21       ` Christoph Hellwig
     [not found]         ` <20160106052138.GM15574-jcswGhMUV9g@public.gmane.org>
2016-01-06 13:34           ` Bart Van Assche
2016-01-06 14:39       ` Sagi Grimberg
     [not found]         ` <568D2707.9020309-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2016-01-06 14:46           ` Bart Van Assche
     [not found]             ` <568D28CA.8010804-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06 17:04               ` Christoph Hellwig
2016-01-05 14:27   ` [PATCH 14/15] IB/srpt: Fix srpt_write_pending() Bart Van Assche
     [not found]     ` <568BD2C2.6090808-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:22       ` Christoph Hellwig
2016-01-06 14:41       ` Sagi Grimberg
2016-01-05 14:27   ` [PATCH 15/15] IB/srpt: Fix a rare crash in srpt_close_session() Bart Van Assche
     [not found]     ` <568BD2E1.1060701-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-01-06  5:23       ` Christoph Hellwig
2016-01-06 14:47       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568D28B6.5040301@dev.mellanox.co.il \
    --to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.