All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@ozlabs.org>
To: Cyril Bur <cyrilbur@gmail.com>, Peng Fei BG Gou <shgoupf@cn.ibm.com>
Cc: openbmc@lists.ozlabs.org, openbmc-patches@stwcx.xyz
Subject: Re: [PATCH phosphor-host-ipmid v4] Add get/set boot option ipmid command support with correct DBUS property handling.
Date: Thu, 7 Jan 2016 12:41:13 +1100	[thread overview]
Message-ID: <568DC239.2090601@ozlabs.org> (raw)
In-Reply-To: <20160106175701.196f6a77@camb691>

Hi all,

> Again, I'm not saying it won't work but I'm trying to understand why the
> complexity in these signatures, it doesn't seem like it's being used and
> pointless complexity doesn't help anyone.

Yes - I'd prefer to get these method signatures correct before other
code starts relying on it.

[the same philosophy applies to the contributions in general - we should
be aiming to get the patch as correct as possible, rather than trying to
fix up later]

Regards,


Jeremy

  reply	other threads:[~2016-01-07  1:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  1:10 [PATCH phosphor-host-ipmid v4] Add get/set ipmid command support with correct DBUS property handling OpenBMC Patches
2016-01-05  1:10 ` [PATCH phosphor-host-ipmid v4] Add get/set boot option " OpenBMC Patches
2016-01-06  5:09   ` Cyril Bur
2016-01-06  6:13   ` Peng Fei BG Gou
2016-01-06  6:57     ` Cyril Bur
2016-01-07  1:41       ` Jeremy Kerr [this message]
2016-01-07  3:27       ` Peng Fei BG Gou
2016-01-06  7:25     ` Peng Fei BG Gou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568DC239.2090601@ozlabs.org \
    --to=jk@ozlabs.org \
    --cc=cyrilbur@gmail.com \
    --cc=openbmc-patches@stwcx.xyz \
    --cc=openbmc@lists.ozlabs.org \
    --cc=shgoupf@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.