From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH9Jf-0003hV-Ou for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:05:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aH9Jb-000808-NB for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:05:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aH9Jb-000803-Hw for qemu-devel@nongnu.org; Thu, 07 Jan 2016 07:05:15 -0500 References: <1452087782-980-1-git-send-email-caoj.fnst@cn.fujitsu.com> <568E320E.9@redhat.com> <568E35A7.4060403@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <568E5476.9010002@redhat.com> Date: Thu, 7 Jan 2016 13:05:10 +0100 MIME-Version: 1.0 In-Reply-To: <568E35A7.4060403@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] SCSI bus: fix to incomplete QOMify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin , qemu-devel@nongnu.org On 07/01/2016 10:53, Cao jin wrote: > On 01/07/2016 05:38 PM, Paolo Bonzini wrote: >> On 06/01/2016 14:43, Cao jin wrote: >> These functions are called in the data path; changes to use SCSI_BUS() >> should come with performance data proving that it doesn't slow down I/O. >> > > I see. I am not familiar with the procedure of scsi i/o performance > test, do have some guideline about it? Usually people test with FIO, but I think it's simpler to just keep DO_UPCAST here. Paolo