From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753365AbcAGP2s (ORCPT ); Thu, 7 Jan 2016 10:28:48 -0500 Received: from mail-bn1bon0085.outbound.protection.outlook.com ([157.56.111.85]:29600 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753307AbcAGP2p (ORCPT ); Thu, 7 Jan 2016 10:28:45 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters To: Joerg Roedel References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160107123411.GH19149@8bytes.org> CC: , , , , , From: Suravee Suthikulpanit Message-ID: <568E8421.5020506@amd.com> Date: Thu, 7 Jan 2016 09:28:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160107123411.GH19149@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BLUPR08CA0067.namprd08.prod.outlook.com (10.141.200.47) To BY1PR12MB0440.namprd12.prod.outlook.com (25.162.147.141) X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;2:QtzFU62dRAmG5CKtf0AOeEKBQKQw9HTlD3hYUFE+wXQYX+JKYxwefal1qa7itVEzCXilXx+Emei9VO8Tq6BI5zVnyqVRKbyycBzsWpAjD8ogHlXoWrPug+oL9bY/dYfWSajbwm5fDKeKhseoSd2Taw==;3:G61mpl7eQjqDFwpNFVtkFloHtD1OndxZZGLZr44VEoMsM0ztKtu9ZMF1+GqB5x0WMP4UUlpd7jB34IyEHt2U3EvjbwFIenfnIEHYZmCbDH/QX0Wj2noo+6Bf7JLCof+C;25:4t3mk9Cin6/dLIEtBlI9n0WV2krrK3IqZkvRyUAB0OZsnwEnDuikuW3euSkBlr8DIFFsCeMZMeJEljpGSX4dVbgGzYu4jXq3RzZ+yXr05/jx5zKRDrq4VzeYnHnPVuMXaVdxBIsq5zxPN0gCVsfoWn3CFCnA829RaJsyOKZ5zwykbQTLnieRj3/IOuYCrRmu7p56Ql0GotUXCb+Joa48gEuA7nwO7+orwRrmJD+dIw/RmqGiNBYuTrhPX3H6nfE7 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-MS-Office365-Filtering-Correlation-Id: 77eb11fb-b493-424d-f3c0-08d31777394d X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;20:9NBkxdCMXXbrtJcrPc83yyqxQS+7lZmyD7nraDOTU+I8UUZZ1NdMUMSFJbEf7ibbS0DsrTauESMHepknRn7+4nweSsJmeQvDt+yZ0oIzRmpAgE1xl2FXFz+4DUD6DW0m7VILeNDWRHCQbWq0EY4zXN/hUCRaRSU/OHwN9jR2RM418x2UlDcqVWt3+JxdBghFfBSSQgDCTi9kMZnJDqj/iwg7vAXDO44ybd+9DuiZI1GdrIo/zOlnQr9CyB2EbiBGyk6cK9o4XIR9KOb17giQ1X3w8Hg3AJoHy9cEWn9dI8CzCe31oHD1iB6y/Kp2b4ENeNARmm0Ay3dSo7I7eD8RutaucisBded6leR4QELvKlIxn6JkvgvtOWSNdapU49KZuppTKXVjcAV/kbO+hdwxTxxUp8zUaUR7oYqIBosyLu+zPPeABVcA92rBsm7Z7nJIo3/O80XR9ko6/7mESapILw8u+9uMkPaUfPcsJsN09kSB/37AjdzWbU9EuduT1ENo;4:ZS1tpy7Q2bKJqIiEVe/D5blNW3K8e/xUv5AblgAA5s20CqdbrLuGF57eJJTpFzULN2JDCf0z836iSJAJ/W+zEzY7EBnyXpxfDQ78sMhCygBtlqKg945qkEXJIXFiPLTaWWnWHVKkCseflgHykSYULH8rLK1r2XXsXwXXIE5av9qwpry76CV1lzkMZL0X0k15aJUr+LqcVN2A4+zj/7PJ6ESr5yiZupcFIV7jySpMNyHQQXyfnW6AttYKN7bdnkRY2veNScQnym56JXiYD2CvZIgJ12HPaNHi374YMIFT2HlWvMuM82w6cJRvgTsC71tFTmQhcFXkl3yrSTQg6VzKGCLXE8CVcr9GuAFwlEv71ornYdEZOYWVbVLCBvs2tKGNA1Nun2ARTByIoef7cWRPmNT+Iqvg7pNy1SpcHGqIxbw= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(10201501046);SRVR:BY1PR12MB0440;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0440; X-Forefront-PRVS: 0814A2C7A3 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(377454003)(24454002)(189002)(199003)(479174004)(122386002)(47776003)(106356001)(83506001)(87976001)(586003)(50986999)(86362001)(19580405001)(3846002)(92566002)(1096002)(66066001)(36756003)(33656002)(101416001)(2950100001)(105586002)(77096005)(23746002)(76176999)(87266999)(64126003)(50466002)(5004730100002)(6116002)(110136002)(97736004)(5001960100002)(42186005)(230700001)(4326007)(65806001)(4001350100001)(19580395003)(5008740100001)(59896002)(81156007)(65816999)(189998001)(80316001)(65956001)(54356999)(40100003)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0440;H:[10.236.65.101];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY1PR12MB0440;23:mUwjvE4qhTDN2wnle/GHwar+5Z3lND+2smfLE?= =?Windows-1252?Q?agSHFI8dj/OzbV7to3Aa6qozlOuKxyHsmi1H1C8CJwFP6RihP/stZe8g?= =?Windows-1252?Q?SbzK1FP94aA++yFahxEcACzWyexGmb4h7VWBlC7VKcxG3F+rYWdyxxNu?= =?Windows-1252?Q?LlLTOhiBMgfol5yXSKvh+0EcTUP7kj983dpoMBfvwG9feLLd+bbHwrKd?= =?Windows-1252?Q?opVcNrA+rmiK04+deD2qqWeVLguRBDeVaX4eYgcztT2vNAQ1K38e30E1?= =?Windows-1252?Q?ZYPgYIZnzHDtxebg+xDwB+yIvNR0M1CIWyXtaqjLkgEmSbPPBUmdvb8L?= =?Windows-1252?Q?fqfMwbCt9LlHC2Y6SMaZNu+eKA/KL6nKKV93aumdeftq/rNVijsWp2UP?= =?Windows-1252?Q?P0xyYUg8DzyYcUgZTKQDmvDDjX5atRSbgLSt8eLB6YRL0WzHJD6GTK5a?= =?Windows-1252?Q?RmPwghYK7+9mQ5Ts59zlTELj+g+mKB7rTuXAiywr7laSzOI0hGp04Aw3?= =?Windows-1252?Q?FlnoheeSeXOF9Uin7VIlu+vktuBH8Vtr13+T2isYUu18N02yzvbB/xog?= =?Windows-1252?Q?deAxqYyxtMx4dbdMcbJsgLNDencMKcg1qI9nXp0cau0ZvUJuhWJCV3Pa?= =?Windows-1252?Q?+8Y2/lxZpAMsNhtPHMZqzexZueVx+0xJuQ77zytprisBW+zLB0NT6M5B?= =?Windows-1252?Q?A2VgNVrUFpDT0q3uFZkejw0p/0jm0CFS0dzdrqxFMn3LvS/Hs9YfNdyC?= =?Windows-1252?Q?ZaXoANWbl/8c72FLSxSvUW3zZ1ZauaCdiAeIpG55prU+MRZC/kM0qpvE?= =?Windows-1252?Q?twgSZkYWVCgaSYAky2y1l3vVSwufn13F7fxWTm2kyxDaPmFwijOxMSSc?= =?Windows-1252?Q?ZXY/zGCCnUZ3GUWs1VsDuQGKVHdjJV7R/4ekLjfawKzEscQ18yILcY5v?= =?Windows-1252?Q?Zq22XC9tJEvmNnGW403lF5+cFh+Vo5Ksu6nMgYY3v6E8RG2RjJNWvhlW?= =?Windows-1252?Q?eZgYD9y8d0HPAYprBQ0hIpTDB9iHZeWeaWuzGoe4K+pg08IoejkCAZaK?= =?Windows-1252?Q?sUH7dHkkXaCPFcLW9fpPcuY8uDHLU2YNixEU4dswkK5Th7naZvx0ZvYt?= =?Windows-1252?Q?8PsxKEkMyvg+yCCqjriEcJ6BA1EVW8s2PDMVmJcPFu6GiLPe7EtLpjGA?= =?Windows-1252?Q?V+5OluvuFjzibTn11ICvJ4A9vysXfk0ylVA9tGEAwb1Z2irJIRwhuem1?= =?Windows-1252?Q?YLy6X2FpnreQrUkd+1qdtWrP79n6RUoFVTHRYbacGvcME4EnCp14kQVe?= =?Windows-1252?Q?uQ9eAK5YKEh3v/wWuQoGvFN2umu+waQFqV3ideJ9lmsFRh1gzRMC9dgF?= =?Windows-1252?Q?l4Lz/vgCnfGWWdX5j7x9I/8IPeiQdNYU0A19EoNKrRuJg2WiazoWGg?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0440;5:6WL4wsmrkQdnP7W5MhhFQ3+s8OR7neEiD0/Oj8kaGvVNGKGlKwpJrNsNYpgMNeV+l31BHd2uxQP/F4cKCtuft/Tb+EOaNckXrIyXbHo+s+ilLhfxt8/ua0dfgEthgxSAY7hBeIkpGaODcImP7iFLuQ==;24:8lSMy9b8H+AVO/+5m17IRVCf77PqhFtV+IjQ5SrNwRW/2dE8ftVgzwnUM32ln7sTOr8MFHeUbV1rMJYhqfrzsu/EbdJbp8I4MZ2Zn8qD4kY=;20:8zP2D4z3raG5QCXlEU2H4/MQ7ktk6SY5OLOFsv02A7qHD4TdRHATdP0op3PwkqvlHYoXfCPdJ72B4qyTGNznDfia+KptrcEI9Lu7xefCt7E0U8HzDDooGWBt7epBhGcOFZF3/f3pnT7KPzSSnigfeIHNFAR5gi3vDg87xe6tyEIKf08Y1tM5JH7Du+boJYw1DsJwcfvnAZEnlL1/UzrXIqYRfgxtEc1Osvh4PYhincU376tMI/a3QA17mmHGuvmc SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jan 2016 15:28:40.8859 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0440 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 06:34 AM, Joerg Roedel wrote: > On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote: >> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, >> which should not be the case. Also, these don't properly support >> multi-IOMMU system. >> >> Current and future AMD systems with IOMMU that support perf counter >> would likely contain homogeneous IOMMUs where multiple IOMMUs are >> availalbe. So, this patch modifies these function to iterate all IOMMU >> to check the max banks and counters reported by the hardware. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++---------- >> drivers/iommu/amd_iommu_init.c | 20 ++++++++++++-------- >> include/linux/perf/perf_event_amd_iommu.h | 7 ++----- >> 3 files changed, 21 insertions(+), 23 deletions(-) > > Reviewed-by: Joerg Roedel > > This looks like the fix for the CZ issue, right? If true, it is > probably v4.5 material. Yes in deed :) Suravee From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [PATCH v2 2/6] perf/amd/iommu: Modify functions to query max banks and counters Date: Thu, 7 Jan 2016 09:28:33 -0600 Message-ID: <568E8421.5020506@amd.com> References: <1451672020-2150-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1451672020-2150-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160107123411.GH19149@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160107123411.GH19149-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Joerg Roedel Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org List-Id: iommu@lists.linux-foundation.org On 01/07/2016 06:34 AM, Joerg Roedel wrote: > On Fri, Jan 01, 2016 at 12:13:36PM -0600, Suravee Suthikulpanit wrote: >> Currently, amd_iommu_pc_get_max_[banks|counters]() require devid, >> which should not be the case. Also, these don't properly support >> multi-IOMMU system. >> >> Current and future AMD systems with IOMMU that support perf counter >> would likely contain homogeneous IOMMUs where multiple IOMMUs are >> availalbe. So, this patch modifies these function to iterate all IOMMU >> to check the max banks and counters reported by the hardware. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> arch/x86/kernel/cpu/perf_event_amd_iommu.c | 17 +++++++---------- >> drivers/iommu/amd_iommu_init.c | 20 ++++++++++++-------- >> include/linux/perf/perf_event_amd_iommu.h | 7 ++----- >> 3 files changed, 21 insertions(+), 23 deletions(-) > > Reviewed-by: Joerg Roedel > > This looks like the fix for the CZ issue, right? If true, it is > probably v4.5 material. Yes in deed :) Suravee