From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbcAGU5A (ORCPT ); Thu, 7 Jan 2016 15:57:00 -0500 Received: from lists.s-osg.org ([54.187.51.154]:47203 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751534AbcAGU47 (ORCPT ); Thu, 7 Jan 2016 15:56:59 -0500 Subject: Re: [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware_nowait() To: Brian Norris , Greg Kroah-Hartman , Ming Lei References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-4-git-send-email-computersforpeace@gmail.com> Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Luis R. Rodriguez" , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <568ED119.8040905@osg.samsung.com> Date: Thu, 7 Jan 2016 13:56:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449701429-121423-4-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2015 03:50 PM, Brian Norris wrote: > The kerneldoc for request_firmware_nowait() says that it may call the > provided cont() callback with @fw == NULL, if the firmware request > fails. However, this is not the case when called with an empty string > (""). This case is short-circuited by the 'name[0] == '\0'' check > introduced in commit 471b095dfe0d ("firmware_class: make sure fw requests > contain a name"), so _request_firmware() never gets to set the fw to > NULL. > Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH v2 4/5] firmware: actually return NULL on failed request_firmware_nowait() Date: Thu, 7 Jan 2016 13:56:57 -0700 Message-ID: <568ED119.8040905@osg.samsung.com> References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-4-git-send-email-computersforpeace@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449701429-121423-4-git-send-email-computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris , Greg Kroah-Hartman , Ming Lei Cc: Kees Cook , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Luis R. Rodriguez" , Shuah Khan List-Id: linux-api@vger.kernel.org On 12/09/2015 03:50 PM, Brian Norris wrote: > The kerneldoc for request_firmware_nowait() says that it may call the > provided cont() callback with @fw == NULL, if the firmware request > fails. However, this is not the case when called with an empty string > (""). This case is short-circuited by the 'name[0] == '\0'' check > introduced in commit 471b095dfe0d ("firmware_class: make sure fw requests > contain a name"), so _request_firmware() never gets to set the fw to > NULL. > Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978