From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753186AbcAGVml (ORCPT ); Thu, 7 Jan 2016 16:42:41 -0500 Received: from lists.s-osg.org ([54.187.51.154]:47279 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbcAGVmk (ORCPT ); Thu, 7 Jan 2016 16:42:40 -0500 Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests To: Brian Norris References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-5-git-send-email-computersforpeace@gmail.com> <568ED136.40308@osg.samsung.com> <20160107213953.GA49009@google.com> Cc: Greg Kroah-Hartman , Ming Lei , Kees Cook , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Luis R. Rodriguez" , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <568EDBCD.7070201@osg.samsung.com> Date: Thu, 7 Jan 2016 14:42:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160107213953.GA49009@google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 02:39 PM, Brian Norris wrote: > Hi Shuah, > > On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote: >> On 12/09/2015 03:50 PM, Brian Norris wrote: >>> Now that we've added a 'trigger_async_request' knob to test the >>> request_firmware_nowait() API, let's use it. Also add tests for the >>> empty ("") string, since there have been a couple errors in that >>> handling already. >>> >>> Since we now have real ways that the sysfs write might fail, let's add >>> the appropriate check on the 'echo' lines too. >>> >>> Signed-off-by: Brian Norris >>> Acked-by: Kees Cook >> >> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. > > Great! Perhaps I'm missing something: I see patches 1-4, but not this > patch (patch 5) in: > > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next > Should show up in a bit. Looks like I applied to my local and didn't do a push. Thanks for double checking. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shuah Khan Subject: Re: [PATCH v2 5/5] selftests: firmware: add empty string and async tests Date: Thu, 7 Jan 2016 14:42:37 -0700 Message-ID: <568EDBCD.7070201@osg.samsung.com> References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-5-git-send-email-computersforpeace@gmail.com> <568ED136.40308@osg.samsung.com> <20160107213953.GA49009@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160107213953.GA49009-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris Cc: Greg Kroah-Hartman , Ming Lei , Kees Cook , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Luis R. Rodriguez" , Shuah Khan List-Id: linux-api@vger.kernel.org On 01/07/2016 02:39 PM, Brian Norris wrote: > Hi Shuah, > > On Thu, Jan 07, 2016 at 01:57:26PM -0700, Shuah Khan wrote: >> On 12/09/2015 03:50 PM, Brian Norris wrote: >>> Now that we've added a 'trigger_async_request' knob to test the >>> request_firmware_nowait() API, let's use it. Also add tests for the >>> empty ("") string, since there have been a couple errors in that >>> handling already. >>> >>> Since we now have real ways that the sysfs write might fail, let's add >>> the appropriate check on the 'echo' lines too. >>> >>> Signed-off-by: Brian Norris >>> Acked-by: Kees Cook >> >> Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. > > Great! Perhaps I'm missing something: I see patches 1-4, but not this > patch (patch 5) in: > > git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git +next > Should show up in a bit. Looks like I applied to my local and didn't do a push. Thanks for double checking. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978