Re: [PATCH net-next v2] net, sched: add clsact qdisc

[John Fastabend <john.fastabend@gmail.com>]

On 16-01-07 01:29 PM, Daniel Borkmann wrote:
> This work adds a generalization of the ingress qdisc as a qdisc holding
> only classifiers. The clsact qdisc works on ingress, but also on egress.
> In both cases, it's execution happens without taking the qdisc lock, and
> the main difference for the egress part compared to prior version of [1]
> is that this can be applied with _any_ underlying real egress qdisc (also
> classless ones).
> 

[...]

> Prior work on a mqprio prequeue() facility [1] was done mainly by John Fastabend.
> 
>   [1] http://patchwork.ozlabs.org/patch/512949/
> 
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Acked-by: John Fastabend <john.r.fastabend@intel.com>

Looks good to me and is a better implementation then my initial take
with the mqprio perqueue() stuff.

I think this complements the lockless work and also putting it in front
of the qdisc bypass logic lets us skip the qdisc but also still use
this for queue selection. Further we can build interesting queue
select logic now and maybe remove select_queue() from the ndo ops
eventually? With this and xps there really is no reason to have drivers
implementing some under-the-covers logic anymore.

Thanks,
John