From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53603)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSyG-0005ip-MG
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:04:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSyB-0004qS-JJ
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:04:32 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36862)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aHSyB-0004qN-C2
	for qemu-devel@nongnu.org; Fri, 08 Jan 2016 04:04:27 -0500
Received: by mail-wm0-x22c.google.com with SMTP id l65so126660005wmf.1
	for <qemu-devel@nongnu.org>; Fri, 08 Jan 2016 01:04:27 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450441266-543-1-git-send-email-berrange@redhat.com>
	<1450441266-543-5-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <568F7B97.8050206@redhat.com>
Date: Fri, 8 Jan 2016 10:04:23 +0100
MIME-Version: 1.0
In-Reply-To: <1450441266-543-5-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v4 4/9] io: add QIOChannelSocket class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>



On 18/12/2015 13:21, Daniel P. Berrange wrote:
> +
> +        if (nfds > SOCKET_MAX_FDS) {
> +            error_setg_errno(errp, -EINVAL,
> +                             "Only %d FDs can be sent, got %zu",
> +                             SOCKET_MAX_FDS, nfds);
> +            return -1;
> +        }

Hi Daniel,

the second argument here should be positive (s/-EINVAL/EINVAL).

Paolo