From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] arch/x86: convert bigmem to Kconfig Date: Fri, 08 Jan 2016 01:50:30 -0700 Message-ID: <568F866602000078000C4B2A@prv-mh.provo.novell.com> References: <1452221757-14267-1-git-send-email-cardoe@cardoe.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452221757-14267-1-git-send-email-cardoe@cardoe.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Doug Goldstein Cc: Andrew Cooper , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org >>> On 08.01.16 at 03:55, wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -25,6 +25,18 @@ config ARCH_DEFCONFIG > > menu "Architecture Features" > > +config BIGMEM > + bool "big memory support" > + default n > + ---help--- > + Allows Xen to support up to 123Tb of memory. > + > + This requires growing struct page_info from 32 to 48 bytes as well > + as shrinking the always accessible direct mapped memory range from > + 5Tb to 3.5Tb. Fundamentally okay, but I think the numbers should be dropped (as they could easily become stale, since they reflect in the first case just current state and in the second really just an implementation detail). No strict need to re-submit (can be fixed up upon commit), but I'd like to have your consent since this is going to be under your name. Jan