From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHa8f-00076O-5Y for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:43:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aHa8b-0005bn-Pl for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:43:45 -0500 Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:33241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aHa8b-0005bg-Lb for qemu-devel@nongnu.org; Fri, 08 Jan 2016 11:43:41 -0500 Received: by mail-qk0-x22d.google.com with SMTP id p186so122585153qke.0 for ; Fri, 08 Jan 2016 08:43:41 -0800 (PST) Sender: Richard Henderson References: <1452270356-26373-1-git-send-email-edgar.iglesias@gmail.com> From: Richard Henderson Message-ID: <568FE739.2000102@twiddle.net> Date: Fri, 8 Jan 2016 08:43:37 -0800 MIME-Version: 1.0 In-Reply-To: <1452270356-26373-1-git-send-email-edgar.iglesias@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/2] tcg-icount: Add and use tcg_set_insn_param to update tcg insn params List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 01/08/2016 08:25 AM, Edgar E. Iglesias wrote: > To do so, we'd need to first emit the insn_start and then after translating the > given target-insn, update the insn_start parameters with the decoded insn > details. Fair enough. > Any thoughts on this approach? Or ideas on better options to achieve this? This looks like a nice cleanup already. Reviewed-by: Richard Henderson r~