From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3D4C11F65 for ; Wed, 30 Jun 2021 11:21:38 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 816E861628 for ; Wed, 30 Jun 2021 11:21:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 816E861628 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C37CC82D76; Wed, 30 Jun 2021 13:21:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="CxzBiOEx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E23882E56; Wed, 30 Jun 2021 13:21:32 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D559F82C1B for ; Wed, 30 Jun 2021 13:21:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 2D76422256; Wed, 30 Jun 2021 13:21:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1625052089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIYhH7M1wXSYDerghL6Zyy5CeIzbQx3Yo1wR+QJ1OU8=; b=CxzBiOEx1YpVLUUqbdrVfp28OU0xD7kbCWNUEsnQax9hN8W2t6gyhZz3BpMAoEdVS2ZdxU T6HZ9ClVWXa+GMUCuXgJNOH5p2jdgi8Pwv9rH4vJy3YMO5JzJV9biCGEJ4hvmU/rKKwrce 3re+TIsdIhEaeAmpnyFGPL+v7AltNvY= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 30 Jun 2021 13:21:29 +0200 From: Michael Walle To: Vladimir Oltean Cc: u-boot@lists.denx.de, Ramon Fried , Priyanka Jain Subject: Re: [PATCH v2] board: sl28: add DSA support for variant 2 In-Reply-To: <20210630103456.6fwem735ue7r7dzg@skbuf> References: <20210623115602.5015-1-michael@walle.cc> <9d1873bbe6909811f6be546a0004030b@walle.cc> <20210630103456.6fwem735ue7r7dzg@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <568d9ce6ef5432ca6d7b8d08657b9b87@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-06-30 12:34, schrieb Vladimir Oltean: > On Wed, Jun 30, 2021 at 10:26:57AM +0200, Michael Walle wrote: >> Can this please go through the net queue? >> >> By chance, I've seen this patch: >> https://patchwork.ozlabs.org/project/uboot/patch/20210629175317.2607470-5-vladimir.oltean@nxp.com/ >> >> Now I'm lucky that I have the following chunk, otherwise the patch >> wouldn't >> work. >> >> +&enetc2 { >> + status = "okay"; >> +}; > > Why "lucky"? I remember you were pushing this device tree style in the > first place. Thats correct, but in u-boot this device was still defaulting to status = "okay", thus it would have been superfluous to still enable it in the board dts. And tbh, I don't exactly know why I enabled it nonetheless. Normally I keep things small ;) Its not about the change (which is good), but there seems to be a disconnect between which patches goes through which queue and you have to be lucky that a (newer) patch doesn't break your patch which is sitting on another queue to be picked up while the newer one is already pulled in. -- -michael