From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755207AbcAJF0J (ORCPT ); Sun, 10 Jan 2016 00:26:09 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:33775 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753860AbcAJF0E (ORCPT ); Sun, 10 Jan 2016 00:26:04 -0500 Subject: Re: [PATCH v2 07/19] n_tty: Fix unsafe reference to "other" ldisc To: Greg Kroah-Hartman References: <1448660356-6328-1-git-send-email-peter@hurleysoftware.com> <1452400870-6005-1-git-send-email-peter@hurleysoftware.com> <1452400870-6005-8-git-send-email-peter@hurleysoftware.com> Cc: Jiri Slaby , linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <5691EB69.5010606@hurleysoftware.com> Date: Sat, 9 Jan 2016 21:26:01 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1452400870-6005-8-git-send-email-peter@hurleysoftware.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2016 08:40 PM, Peter Hurley wrote: > Although n_tty_check_unthrottle() has a valid ldisc reference (since > the tty core gets the ldisc ref in tty_read() before calling the line > discipline read() method), it does not have a valid ldisc reference to > the "other" pty of a pty pair. Since getting an ldisc reference for > tty->link essentially open-codes tty_wakeup(), just replace with the > equivalent tty_wakeup(). Hi Greg, Same here (forgot to re-mark this patch for stable). Regards, Peter Hurley