All of lore.kernel.org
 help / color / mirror / Atom feed
From: wanghaibin <wanghaibin.wang@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jiangshanlai@gmail.com>,
	<peter.huangpeng@huawei.com>
Subject: Re: [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed.
Date: Mon, 11 Jan 2016 12:26:17 +0800	[thread overview]
Message-ID: <56932EE9.2030909@huawei.com> (raw)
In-Reply-To: <20160107155032.GB1898@mtj.duckdns.org>

On 2016/1/7 23:50, Tejun Heo wrote:

> On Thu, Jan 07, 2016 at 08:38:57PM +0800, wanghaibin wrote:
>> Before the return that wq_numa_init failed, it will be bettet to free
>> the numa node table to avoid the memory leaks.
> 

OK, I just expect that it can free the memory in all exception cases!

> That's a WARN_ON condition which should never happen.  The system is
> already pretty messed up and just limping along.  It really doesn't
> matter whether some memory is cleaned up or not.  Let's keep it
> simple.

OK, get it !


> 
> Thanks.
> 

  reply	other threads:[~2016-01-11  4:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-07 12:38 [RFC PATCH 0/4] fixs/suggestions for workqueue subsystem wanghaibin
2016-01-07 12:38 ` [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location wanghaibin
2016-01-07 15:48   ` Tejun Heo
2016-01-11  5:21     ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed wanghaibin
2016-01-07 15:50   ` Tejun Heo
2016-01-11  4:26     ` wanghaibin [this message]
2016-01-07 12:38 ` [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin
2016-01-07 16:00   ` Tejun Heo
2016-01-11 12:23     ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function wanghaibin
2016-01-07 16:07   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56932EE9.2030909@huawei.com \
    --to=wanghaibin.wang@huawei.com \
    --cc=jiangshanlai@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.huangpeng@huawei.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.