All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 21/24] Testing: remove -q from grep
Date: Sun, 30 Jan 2011 13:57:44 +0100	[thread overview]
Message-ID: <56935a36945105a151999d7fed409100ec18c264.1296391340.git.zkabelac@redhat.com> (raw)
In-Reply-To: <cover.1296391340.git.zkabelac@redhat.com>

to avoid problems with pipe breaking

Signed-off-by: Zdenek Kabelac <zkabelac@redhat.com>
---
 test/t-mirror-names.sh                  |    2 +-
 test/t-mirror-vgreduce-removemissing.sh |    2 +-
 test/t-pvcreate-operation.sh            |    2 +-
 test/t-snapshot-merge.sh                |    9 +++++----
 test/t-vgcreate-usage.sh                |    2 +-
 test/t-vgextend-usage.sh                |    2 +-
 6 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/test/t-mirror-names.sh b/test/t-mirror-names.sh
index aae7cf5..09ac9d3 100644
--- a/test/t-mirror-names.sh
+++ b/test/t-mirror-names.sh
@@ -27,7 +27,7 @@ lv_devices_() {
                sed 's/ //g' | sed 's/,/ /g')
 
   for d in $devs; do
-    (echo $devices | grep -q $d)  || return 1
+    (echo $devices | grep $d >/dev/null)  || return 1
     devices=$(echo $devices | sed "s/$d//")
   done
 
diff --git a/test/t-mirror-vgreduce-removemissing.sh b/test/t-mirror-vgreduce-removemissing.sh
index 146c2d4..f4f7567 100755
--- a/test/t-mirror-vgreduce-removemissing.sh
+++ b/test/t-mirror-vgreduce-removemissing.sh
@@ -65,7 +65,7 @@ lv_is_linear_()
 {
 	echo "Check if $1 is linear LV (i.e. not a mirror)"
 	lvs -o stripes,attr --noheadings $vg/$1 | sed 's/ //g'
-	lvs -o stripes,attr --noheadings $vg/$1 | sed 's/ //g' | grep -q '^1-'
+	lvs -o stripes,attr --noheadings $vg/$1 | sed 's/ //g' | grep '^1-' >/dev/null
 }
 
 rest_pvs_()
diff --git a/test/t-pvcreate-operation.sh b/test/t-pvcreate-operation.sh
index f9a9eb6..a1663d6 100755
--- a/test/t-pvcreate-operation.sh
+++ b/test/t-pvcreate-operation.sh
@@ -82,7 +82,7 @@ for i in 0 1 2 3
 do
 # pvcreate (lvm2) succeeds writing LVM label at sector $i
     pvcreate --labelsector $i $dev1
-    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep -q LABELONE;
+    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep LABELONE >/dev/null
     pvremove -f $dev1
 done
 
diff --git a/test/t-snapshot-merge.sh b/test/t-snapshot-merge.sh
index 2895c76..22babf8 100755
--- a/test/t-snapshot-merge.sh
+++ b/test/t-snapshot-merge.sh
@@ -47,7 +47,7 @@ aux prepare_vg 1 100
 # test full merge of a single LV
 setup_merge $vg $lv1
 # now that snapshot LV is created: test if snapshot-merge target is available
-$(dmsetup targets | grep -q snapshot-merge) || exit 200
+$(dmsetup targets | grep snapshot-merge >/dev/null) || exit 200
 lvs -a
 # make sure lvconvert --merge requires explicit LV listing
 not lvconvert --merge 2>err
@@ -73,11 +73,12 @@ lvconvert --merge $vg/$(snap_lv_name_ $lv1)
 lvchange --refresh $vg/$lv1
 umount test_mnt
 rm -r test_mnt
-dmsetup table ${vg}-${lv1} | grep -q " snapshot-origin "
+dmsetup table ${vg}-${lv1} | grep " snapshot-origin "
+
 # -- refresh LV to start merge (now that FS is unmounted),
 #    an active merge uses the 'snapshot-merge' target
 lvchange --refresh $vg/$lv1
-dmsetup table ${vg}-${lv1} | grep -q " snapshot-merge "
+dmsetup table ${vg}-${lv1} | grep " snapshot-merge "
 # -- don't care if merge is still active; lvremove at this point
 #    may test stopping an active merge
 lvremove -f $vg/$lv1
@@ -96,7 +97,7 @@ lvconvert --merge $vg/$(snap_lv_name_ $lv1)
 lvchange --refresh $vg/$lv1
 umount test_mnt
 rm -r test_mnt
-dmsetup table ${vg}-${lv1} | grep -q " snapshot-origin "
+dmsetup table ${vg}-${lv1} | grep " snapshot-origin " >/dev/null
 lvremove -f $vg/$lv1
 
 
diff --git a/test/t-vgcreate-usage.sh b/test/t-vgcreate-usage.sh
index ab7ef54..916262e 100755
--- a/test/t-vgcreate-usage.sh
+++ b/test/t-vgcreate-usage.sh
@@ -102,7 +102,7 @@ for i in 0 1 2 3
 do
 # vgcreate (lvm2) succeeds writing LVM label at sector $i
     vgcreate -c n --labelsector $i $vg $dev1
-    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep -q LABELONE;
+    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep LABELONE >/dev/null
     vgremove -f $vg
     pvremove -f $dev1
 done
diff --git a/test/t-vgextend-usage.sh b/test/t-vgextend-usage.sh
index 4d13de5..07bca52 100644
--- a/test/t-vgextend-usage.sh
+++ b/test/t-vgextend-usage.sh
@@ -46,7 +46,7 @@ for i in 0 1 2 3
 do
 # vgcreate (lvm2) succeeds writing LVM label at sector $i
     vgextend --labelsector $i $vg $dev1
-    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep -q LABELONE;
+    dd if=$dev1 bs=512 skip=$i count=1 2>/dev/null | strings | grep LABELONE >/dev/null
     vgreduce $vg $dev1
     pvremove -f $dev1
 done
-- 
1.7.3.5



  parent reply	other threads:[~2011-01-30 12:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30 12:57 [PATCH 00/24] Performance improvements Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 01/24] Add find_config_tree_int64 function Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 02/24] Replace PV_MIN_SIZE with function pv_min_size() Zdenek Kabelac
2011-01-30 20:01   ` Milan Broz
2011-01-30 20:15     ` Zdenek Kabelac
2011-01-30 20:22       ` Milan Broz
2011-01-30 21:10         ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 03/24] Test pv_min_size functionality Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 04/24] Move add_dev_node to DM_DEVICE_RESUME Zdenek Kabelac
2011-01-31 11:37   ` Peter Rajnoha
2011-01-30 12:57 ` [PATCH 05/24] Perf: Fix multiple operations on the same node Zdenek Kabelac
2011-01-30 19:43   ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 06/24] lv_info handle udev_sync Zdenek Kabelac
2011-01-30 20:17   ` Milan Broz
2011-01-30 20:23     ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 07/24] Remove open_count read from some lv_info calls Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 08/24] Perf: optimize _eat_space and _get_token Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 09/24] Align orphan strings Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 10/24] Perf: speed up hash tables Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 11/24] Perf: New HASH function Zdenek Kabelac
2011-01-31 10:33   ` Petr Rockai
2011-01-30 12:57 ` [PATCH 12/24] Perf: Increase hash sizes Zdenek Kabelac
2011-01-30 20:35   ` Milan Broz
2011-01-30 20:54     ` Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 13/24] Memory unlock allows 1 page difference Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 14/24] Critical section Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 15/24] Remove fs_unlock after failed suspend Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 16/24] Man pages reformating Zdenek Kabelac
2011-01-30 20:37   ` Milan Broz
2011-01-30 12:57 ` [PATCH 17/24] Void* arithmetic replaced with char* Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 18/24] API change - support more const arg Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 19/24] Use cleaner const * pointer Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 20/24] Const fixing Zdenek Kabelac
2011-01-30 20:44   ` Milan Broz
2011-01-30 12:57 ` Zdenek Kabelac [this message]
2011-01-30 20:50   ` [PATCH 21/24] Testing: remove -q from grep Milan Broz
2011-01-30 12:57 ` [PATCH 22/24] Testing: Try to prioritize locking process Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 23/24] Extend lvm2api with lvm_lv_rename Zdenek Kabelac
2011-01-30 12:57 ` [PATCH 24/24] Testing lvm_lv_rename Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56935a36945105a151999d7fed409100ec18c264.1296391340.git.zkabelac@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.