From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aIcoU-0006o5-Nz
	for qemu-devel@nongnu.org; Mon, 11 Jan 2016 08:47:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aIcoT-0002Yu-Vc
	for qemu-devel@nongnu.org; Mon, 11 Jan 2016 08:47:14 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1447682723-3977-1-git-send-email-peter.maydell@linaro.org>
	<1447682723-3977-10-git-send-email-peter.maydell@linaro.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5693B259.2030106@redhat.com>
Date: Mon, 11 Jan 2016 14:47:05 +0100
MIME-Version: 1.0
In-Reply-To: <1447682723-3977-10-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/19] exec.c: Use
	cpu_get_phys_page_attrs_debug
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, qemu-arm@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>, patches@linaro.org



On 16/11/2015 15:05, Peter Maydell wrote:
> -    hwaddr phys = cpu_get_phys_page_debug(cpu, pc);
> +    MemTxAttrs attrs = {};
> +    hwaddr phys = cpu_get_phys_page_attrs_debug(cpu, pc, &attrs);
> +    int asidx = cpu_asidx_from_attrs(cpu, attrs);
>      if (phys != -1) {
> -        tb_invalidate_phys_addr(cpu->as,
> +        tb_invalidate_phys_addr(cpu->cpu_ases[asidx].as,
>                                  phys | (pc & ~TARGET_PAGE_MASK));
>      }

The only question I have is whether it is right to have empty MemTxAttrs
here.  Is there any way to use the MemTxAttrs for the "current state" of
the CPU, whatever that is (on x86 I have added cpu_get_mem_attrs to
target-i386/cpu.h)?

Paolo