From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 07/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects Date: Mon, 11 Jan 2016 17:15:54 +0000 Message-ID: <5693E34A.6080809@linux.intel.com> References: <1450765253-32104-1-git-send-email-ankitprasad.r.sharma@intel.com> <1450765253-32104-8-git-send-email-ankitprasad.r.sharma@intel.com> <56793AE9.5090300@linux.intel.com> <20151222174009.GI5896@nuc-i3427.alporthouse.com> <5693BA6D.2040402@linux.intel.com> <20160111144500.GG652@nuc-i3427.alporthouse.com> <5693C60B.6080709@linux.intel.com> <20160111170337.GM652@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 56614898CC for ; Mon, 11 Jan 2016 09:15:57 -0800 (PST) In-Reply-To: <20160111170337.GM652@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ankitprasad.r.sharma@intel.com, intel-gfx@lists.freedesktop.org, akash.goel@intel.com, shashidhar.hiremath@intel.com List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMS8wMS8xNiAxNzowMywgQ2hyaXMgV2lsc29uIHdyb3RlOgo+IE9uIE1vbiwgSmFuIDEx LCAyMDE2IGF0IDAzOjExOjA3UE0gKzAwMDAsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+Pgo+PiBP biAxMS8wMS8xNiAxNDo0NSwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4gT24gTW9uLCBKYW4gMTEs IDIwMTYgYXQgMDI6MjE6MzNQTSArMDAwMCwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Pj4KPj4+ PiBPbiAyMi8xMi8xNSAxNzo0MCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+Pj4+PiBPbiBUdWUsIERl YyAyMiwgMjAxNSBhdCAxMTo1ODozM0FNICswMDAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+ Pj4+IE1heWJlOgo+Pj4+Pj4KPj4+Pj4+IAlpZiAoIW9iai0+YmFzZS5maWxwIHx8IGNwdV93cml0 ZV9uZWVkc19jbGZsdXNoKG9iaikpCj4+Pj4+PiAgICAgCQlyZXQgPSBpOTE1X2dlbV9ndHRfcHdy aXRlX2Zhc3QoLi4uKTsKPj4+Pj4+Cj4+Pj4+PiAJaWYgKHJldCA9PSAtRUZBVUxUICYmICFvYmot PmJhc2UuZmlscCkgewo+Pj4+Pj4gCQlyZXQgPSBpOTE1X2dlbV9ndHRfcHdyaXRlX3Nsb3coLi4u KSAvKiBOZXcgZnVuY3Rpb24sIGRvaW5nIHRoZQo+Pj4+Pj4gc2xvd191c2VyX2FjY2VzcyBsb29w IGZvciAhZmlscCBvYmplY3RzLCBleHRyYWN0ZWQgZnJvbQo+Pj4+Pj4gZ3R0X3B3cml0ZV9mYXN0 IGFib3ZlLiAqLwo+Pj4+Pgo+Pj4+PiBUaGUgcG9pbnQgaXMgdGhhdCAiZ3R0X3B3cml0ZV9zbG93 IiBpcyBnb2luZyB0byBiZSBwcmVmZXJyYWJsZSBpbiB0aGUKPj4+Pj4gY2FzZXMgd2hlcmUgaXQg aXMgcG9zc2libGUuIEl0IGp1c3Qgd2Fzbid0IHRoZSBmdWxsIGZhbGxiYWNrIHBhdGNoIGZvcgo+ Pj4+PiBhbGwgb2JqZWN0cyBwcmV2aW91c2x5LCBzbyB3ZSBkaWRuJ3QgYm90aGVyIHRvIHdyaXRl IGEgcGFydGlhbCBmYWxsYmFjawo+Pj4+PiBoYW5kbGVyLgo+Pj4+Cj4+Pj4gTWF5YmUgSSBkb24n dCBnZXQgdGhpcyAtIGlzIGZhc3RfdXNlcl93cml0ZSBleHBlY3RlZCBhbHdheXMgdG8gZmFpbAo+ Pj4+IGZvciBub24gc2htZW0gYmFja2VkIG9iamVjdHM/IEFuZCBzbyByZXZlcnQgdG8gdGhlIHNs b3dfdXNlcl9wYXRoCj4+Pj4gYWx3YXlzIGFuZCBpbW1lZGlhdGVseT8gQmVjYXVzZSBmYXN0X3Vz ZXJfd3JpdGUgaXMgc3RpbGwgdGhlIHByaW1hcnkKPj4+PiBjaG9pY2UgZm9yIGV2ZXJ5dGhpbmcu Cj4+Pgo+Pj4gSWYgd2UgYWxyZWFkeSBoYXZlIGEgR1RUIG1hcHBpbmcgYXZhaWxhYmxlLCB0aGVu IFdDIHdyaXRlcyBpbnRvIHRoZQo+Pj4gb2JqZWN0IGFyZSBhYm91dCBhcyBmYXN0IGFzIHdlIGNh biBnZXQsIGVzcGVjaWFsbHkgaWYgd2UgZG9uJ3QgaGF2ZQo+Pj4gZGlyZWN0IHBhZ2UgYWNjZXNz LiBUaGV5IGFsc28gaGF2ZSB0aGUgYmVuZWZpdCBvZiBub3QgcG9sbHV0aW5nIHRoZQo+Pj4gY2Fj aGUgZnVydGhlciAtIHRob3VnaCB0aGF0IG1heWJlIGEgZG93bnNpZGUgYXMgd2VsbCwgaW4gd2hp Y2ggY2FzZQo+Pj4gcHdyaXRlL3ByZWFkIHdhcyB0aGUgd3JvbmcgaW50ZXJmYWNlIHRvIHVzZS4K Pj4+Cj4+PiBmYXN0X3VzZXJfd3JpdGUgaXMgbm8gbW9yZSBsaWtlbHkgdG8gZmFpbCBmb3Igc3Rv bGVuIG9ianMgdGhhbiBmb3IKPj4+IHNobWVtZnMgb2JqLCBpdCBpcyBqdXN0IHRoYXQgd2UgY2Fu bm90IGZhbGxiYWNrIHRvIGRpcmVjdCBwYWdlIGFjY2Vzcwo+Pj4gZm9yIHN0b2xlbiBvYmpzIGFu ZCBzbyBuZWVkIGEgZmFsbGJhY2sgcGF0aCB0aGF0IHdyaXRlcyB0aHJvdWdoIHRoZSBHVFQuCj4+ PiBUaGF0IGZhbGxiYWNrIHBhdGggd291bGQgYWxzbyBiZSBwcmVmZXJyYWJsZSB0byBmYWxsaW5n IGJhY2sgZnJvbSB0aGUKPj4+IG1pZGRsZSBvZiBhIEdUVCB3cml0ZSB0byB0aGUgZGlyZWN0IHBh Z2UgcGF0aHMuIFRoZSBpc3N1ZSB3YXMgc2ltcGx5Cj4+PiB0aGF0IHRoZSBHVFQgcGF0aHMgY2Fu bm90IGJlIGFzc3VtZWQgdG8gYmUgdW5pdmVyc2FsbHkgYXZhaWxhYmxlLAo+Pj4gd2hlcmVhcyBo aXN0b3JpY2FsbHkgdGhlIGRpcmVjdCBwYWdlIGFjY2VzcyBwYXRocyB3ZXJlLiAqVGhhdCogY2hh bmdlcywKPj4+IGFuZCBub3cgd2UgY2Fubm90IHJlbHkgb24gZWl0aGVyIHBhdGggYmVpbmcgdW5p dmVyc2FsbHkgYXZhaWxhYmxlLgo+Pgo+PiBTbyBpdCBzb3VuZHMgdGhhdCB3ZSBkb24ndCBuZWVk IHRvIGhhdmUgY29kZSB3aGljaCBmYWxscyBiYWNrIGluIHRoZQo+PiBtaWRkbGUgb2YgdGhlIHdy aXRlIGJ1dCBjb3VsZCBiZSB3cml0dGVuIGNsZWFuZXIgYXMgc2VwYXJhdGUKPj4gaGVscGVycz8K Pj4KPj4gQmVjYXVzZSBJIHJlYWxseSBkaXNsaWtlIHRoYXQgbmV3IGxvb3AuLi4KPiAKPiBXaGF0 IG5ldyBsb29wPyBXZSBkb24ndCBuZWVkIGEgbmV3IGxvb3AuLi4KPiAKPiBpOTE1X2dlbV9ndHRf cHdyaXRlKCk6Cj4gCS8qIEltcG9ydGFudCBhbmQgZXhjZWVkaW5nbHkgY29tcGxleCBzZXR1cC90 ZWFyZG93biBjb2RlCj4gCSAqIHJlbW92ZWQgZm9yIGJyZXZpdHkuCj4gCSAqLwo+IAlmb3JfZWFj aF9wYWdlKCkgewo+IAkJLi4uIGdldCBsaW1pdHMgb2Ygb3BlcmF0aW9uIGluIHBhZ2UuLi4KPiAK PiAJCWlmIChmYXN0X2d0dF93cml0ZSgjI2FyZ3MpKSB7Cj4gCQkJLyogQmV3YXJlIGRyYWdvbnMg Ki8KPiAJCQltdXRleF91bmxvY2soKTsKPiAJCQloaXRfc2xvd19wYXRoID0gMTsKPiAJCQlzbG93 X2d0dF93cml0ZSgjI2FyZ3MpOwo+IAkJCW11dGV4X2xvY2soKTsKPiAJCX0KPiAJfQo+IAo+IAlp ZiAoaGl0X3Nsb3dfcGF0aCkgewo+IAkJLyogQmV3YXJlIGRyYWdvbnMgdGhhdCBiaXRlICovCj4g CQlyZXQgPSBpOTE1X2dlbV9vYmplY3Rfc2V0X3RvX2d0dF9kb21haW4ob2JqLCB0cnVlKTsKPiAJ fQo+IAo+IElzIHRoYXQgbm90IHdoYXQgd2FzIHdyaXR0ZW4/IEkgdGFrZSBpdCBteSB0ZWxlcGF0 aHkgaXNuJ3Qgd29ya2luZwo+IGFnYWluLgoKU29ycnkgbm90IGEgbmV3IGxvb3AsIG5ldyBjYXNl IGluIGEgb2xkIGxvb3AuIFRoaXMgaXMgdGhlIGh1bmsgSSB0aGluawppcyBub3QgaGVscGluZyBy ZWFkYWJpbGl0eToKCkBAIC04NjksMTEgKzk2NywyOSBAQCBpOTE1X2dlbV9ndHRfcHdyaXRlX2Zh c3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUsCiAJCS8qIElmIHdlIGdldCBhIGZhdWx0 IHdoaWxlIGNvcHlpbmcgZGF0YSwgdGhlbiAocHJlc3VtYWJseSkgb3VyCiAJCSAqIHNvdXJjZSBw YWdlIGlzbid0IGF2YWlsYWJsZS4gIFJldHVybiB0aGUgZXJyb3IgYW5kIHdlJ2xsCiAJCSAqIHJl dHJ5IGluIHRoZSBzbG93IHBhdGguCisJCSAqIElmIHRoZSBvYmplY3QgaXMgbm9uLXNobWVtIGJh Y2tlZCwgd2UgcmV0cnkgYWdhaW4gd2l0aCB0aGUKKwkJICogcGF0aCB0aGF0IGhhbmRsZXMgcGFn ZSBmYXVsdC4KIAkJICovCi0JCWlmIChmYXN0X3VzZXJfd3JpdGUoaTkxNS0+Z3R0Lm1hcHBhYmxl LCBwYWdlX2Jhc2UsCi0JCQkJICAgIHBhZ2Vfb2Zmc2V0LCB1c2VyX2RhdGEsIHBhZ2VfbGVuZ3Ro KSkgewotCQkJcmV0ID0gLUVGQVVMVDsKLQkJCWdvdG8gb3V0X2ZsdXNoOworCQlpZiAoZmF1bHRl ZCB8fCBmYXN0X3VzZXJfd3JpdGUoaTkxNS0+Z3R0Lm1hcHBhYmxlLAorCQkJCQkJcGFnZV9iYXNl LCBwYWdlX29mZnNldCwKKwkJCQkJCXVzZXJfZGF0YSwgcGFnZV9sZW5ndGgpKSB7CisJCQlpZiAo IW9iai0+YmFzZS5maWxwKSB7CisJCQkJZmF1bHRlZCA9IHRydWU7CisJCQkJbXV0ZXhfdW5sb2Nr KCZkZXYtPnN0cnVjdF9tdXRleCk7CisJCQkJaWYgKHNsb3dfdXNlcl9hY2Nlc3MoaTkxNS0+Z3R0 Lm1hcHBhYmxlLAorCQkJCQkJICAgICBwYWdlX2Jhc2UsCisJCQkJCQkgICAgIHBhZ2Vfb2Zmc2V0 LCB1c2VyX2RhdGEsCisJCQkJCQkgICAgIHBhZ2VfbGVuZ3RoLCB0cnVlKSkgeworCQkJCQlyZXQg PSAtRUZBVUxUOworCQkJCQltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7CisJCQkJCWdv dG8gb3V0X2ZsdXNoOworCQkJCX0KKworCQkJCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4 KTsKKwkJCX0gZWxzZSB7CisJCQkJcmV0ID0gLUVGQVVMVDsKKwkJCQlnb3RvIG91dF9mbHVzaDsK KwkJCX0KCkJlY2F1c2UgdGhlIGNvbmNlcHQgaXMgbm93IGRpZmZlcmVudCBmb3IgcGFnZSBmYXVs dHMgb24gc2htZW0gYmFzZWQgYW5kCm5vbi1zaG1lbSBiYXNlZCBvYmplY3RzLiBGb3JtZXIgZmFs bHMgb3V0IG9uIGZhdWx0IGFuZCBlbmRzIHVwIGluCmk5MTVfZ2VtX3NobWVtX3B3cml0ZSwgd2hp bGUgbGF0dGVyIGtlZXBzIGJhbmdpbmcgb24gaW4gCmk5MTVfZ2VtX2d0dF9wd3JpdGVfZmFzdC4K CkkgZmluZCBpdCBjb25mdXNpbmcgY29kZSBvcmdhbml6YXRpb24gYW5kIG5hbWluZy4gU28gSSBz dWdnZXN0ZWQgdGhlCm5ldyBwYXRoICghc2htZW0gKyBmYXVsdCkgaXMgYWRkZWQgYXMgYSBzZXBh cmF0ZSBuZXcgZnVuY3Rpb24gYW5kIGNhbGxlZApmcm9tIGk5MTVfZ2VtX3B3cml0ZV9pb2N0bCBz YW1lIGFzIGk5MTVfZ2VtX3NobWVtX3B3cml0ZSBidXQgeW91Cm9iamVjdGVkOgoKICAgIGlmICgh b2JqLT5iYXNlLmZpbHAgfHwgY3B1X3dyaXRlX25lZWRzX2NsZmx1c2gob2JqKSkKICAgICAgICAg ICByZXQgPSBpOTE1X2dlbV9ndHRfcHdyaXRlX2Zhc3QoLi4uKTsKCiAgICBpZiAocmV0ID09IC1F RkFVTFQgJiYgIW9iai0+YmFzZS5maWxwKSB7CiAgICAgICAgcmV0ID0gaTkxNV9nZW1fZ3R0X3B3 cml0ZV9zbG93KC4uLikgLyogTmV3IGZ1bmN0aW9uLCBkb2luZyB0aGUgc2xvd191c2VyX2FjY2Vz cyBsb29wIGZvciAhZmlscCBvYmplY3RzLCBleHRyYWN0ZWQgZnJvbSBndHRfcHdyaXRlX2Zhc3Qg YWJvdmUuICovCiAgICB9IGVsc2UgaWYgKHJldCA9PSAtRUZBVUxUIHx8IHJldCA9PSAtRU5PU1BD KSB7CiAgICAgICAgaWYgKG9iai0+cGh5c19oYW5kbGUpCiAgICAgICAgICAgIC4uLgogICAgICAg IC4uLgoKUmVnYXJkcywKClR2cnRrbwoKCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==