From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761961AbcALBgi (ORCPT ); Mon, 11 Jan 2016 20:36:38 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:22582 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760024AbcALBgg (ORCPT ); Mon, 11 Jan 2016 20:36:36 -0500 Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl To: Lee Jones References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , From: xuejiancheng Message-ID: <5694584D.7040301@huawei.com> Date: Tue, 12 Jan 2016 09:35:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160111085555.GE14104@x1> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.217.211] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.5694585E.0050,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 451545615172e45e64354914b7858cd4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/11 16:55, Lee Jones wrote: > On Mon, 11 Jan 2016, xuejiancheng wrote: >> On 2016/1/11 13:48, Lee Jones wrote: >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>> >>>> Add device tree bindings for Hi3519 system controller. >>>> >>>> Signed-off-by: Jiancheng Xue >>>> --- >>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt >>> >>> I have this patch, but none of the others in the set, thus I am >>> lacking context. >>> >> I can forward other patches in the set to you. Thank you. >> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> new file mode 100644 >>>> index 0000000..115c5be >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> @@ -0,0 +1,14 @@ >>>> +* Hisilicon Hi3519 System Controller Block >>>> + >>>> +This bindings use the following binding: >>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>> + >>>> +Required properties: >>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>> +- reg: the register region of this block >>>> + >>>> +Examples: >>>> +sysctrl: system-controller@12010000 { >>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; >>>> + reg = <0x12010000 0x1000>; >>>> +}; >>> >>> There is no requirement (nor want) for binding documents where the >>> given device is simply using highly generic bindings. This just >>> amounts to churn. >>> >> This block is specific for Hi3519 SOC, and may has its own driver. > > Does it have its own driver currently? > Not yet. Arnd Bergmann and Rob Herring all suggested adding a specific compatible string with the SOC name. This binding is just used for describing the compatible string now. When more functions on hi3519 SOC are added later, the specific driver will be also needed. >> So I think it's better to keep this binding. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuejiancheng Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Date: Tue, 12 Jan 2016 09:35:09 +0800 Message-ID: <5694584D.7040301@huawei.com> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160111085555.GE14104@x1> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, khilman-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, yanhaifeng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, yanghongwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, suwenping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, ml.yang-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, gaofei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, zhangzhenxing-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, xuejiancheng-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016/1/11 16:55, Lee Jones wrote: > On Mon, 11 Jan 2016, xuejiancheng wrote: >> On 2016/1/11 13:48, Lee Jones wrote: >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>> >>>> Add device tree bindings for Hi3519 system controller. >>>> >>>> Signed-off-by: Jiancheng Xue >>>> --- >>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt >>> >>> I have this patch, but none of the others in the set, thus I am >>> lacking context. >>> >> I can forward other patches in the set to you. Thank you. >> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> new file mode 100644 >>>> index 0000000..115c5be >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> @@ -0,0 +1,14 @@ >>>> +* Hisilicon Hi3519 System Controller Block >>>> + >>>> +This bindings use the following binding: >>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>> + >>>> +Required properties: >>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>> +- reg: the register region of this block >>>> + >>>> +Examples: >>>> +sysctrl: system-controller@12010000 { >>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; >>>> + reg = <0x12010000 0x1000>; >>>> +}; >>> >>> There is no requirement (nor want) for binding documents where the >>> given device is simply using highly generic bindings. This just >>> amounts to churn. >>> >> This block is specific for Hi3519 SOC, and may has its own driver. > > Does it have its own driver currently? > Not yet. Arnd Bergmann and Rob Herring all suggested adding a specific compatible string with the SOC name. This binding is just used for describing the compatible string now. When more functions on hi3519 SOC are added later, the specific driver will be also needed. >> So I think it's better to keep this binding. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuejiancheng@huawei.com (xuejiancheng) Date: Tue, 12 Jan 2016 09:35:09 +0800 Subject: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl In-Reply-To: <20160111085555.GE14104@x1> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> Message-ID: <5694584D.7040301@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/1/11 16:55, Lee Jones wrote: > On Mon, 11 Jan 2016, xuejiancheng wrote: >> On 2016/1/11 13:48, Lee Jones wrote: >>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>> >>>> Add device tree bindings for Hi3519 system controller. >>>> >>>> Signed-off-by: Jiancheng Xue >>>> --- >>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ >>>> 1 file changed, 14 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt >>> >>> I have this patch, but none of the others in the set, thus I am >>> lacking context. >>> >> I can forward other patches in the set to you. Thank you. >> >>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> new file mode 100644 >>>> index 0000000..115c5be >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>> @@ -0,0 +1,14 @@ >>>> +* Hisilicon Hi3519 System Controller Block >>>> + >>>> +This bindings use the following binding: >>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>> + >>>> +Required properties: >>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>> +- reg: the register region of this block >>>> + >>>> +Examples: >>>> +sysctrl: system-controller at 12010000 { >>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; >>>> + reg = <0x12010000 0x1000>; >>>> +}; >>> >>> There is no requirement (nor want) for binding documents where the >>> given device is simply using highly generic bindings. This just >>> amounts to churn. >>> >> This block is specific for Hi3519 SOC, and may has its own driver. > > Does it have its own driver currently? > Not yet. Arnd Bergmann and Rob Herring all suggested adding a specific compatible string with the SOC name. This binding is just used for describing the compatible string now. When more functions on hi3519 SOC are added later, the specific driver will be also needed. >> So I think it's better to keep this binding. >