From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934051AbcALIer (ORCPT ); Tue, 12 Jan 2016 03:34:47 -0500 Received: from mout.web.de ([212.227.15.3]:64357 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760402AbcALIeq (ORCPT ); Tue, 12 Jan 2016 03:34:46 -0500 Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after error detection To: Lee Jones References: <566ABCD9.1060404@users.sourceforge.net> <568284D3.3060006@users.sourceforge.net> <20160111083108.GC14104@x1> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <5694BAA0.80004@users.sourceforge.net> Date: Tue, 12 Jan 2016 09:34:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160111083108.GC14104@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:NjB/NqijeninoKLkvt2y6k7Ym7Lox5IyRn61w0A4ukL/K2D3/jQ WppDSdpUBvpHcQrCnpqhga+bCFaK/t8wJDfow7znXp/MapXGMtrwAvdvdoT/n2jVIVfyU9q 1TNCTApLsrs9ziqJfv/KWEPgYNQirWwkGdlZ4Kr9c+i8v33P7yh7I6BnkN7BB/1IczrhJA2 LETOTTdzbVai5ajgJOajg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vzy8E3uemZQ=:t4sOmBRiOc02y0dB11wQH/ lGswSigdEBkg8eVHWoTcHyhblKPUEhbbAVWm0mga5GkZIIZsdoE7PLkKUtITp+PIVa5p3Hg1a cqVlgFiKzr4kONpD47F4jaLEIL/NvTSFo69NWaBzpNvOlm22AtOu7v6ofvLrzHlx4rfX/V2HZ tGrkAD4e8M0iywecewHC64iTXzPGQ4G2pPHKo0/LxrnyL/OVcOElZMuc5EQKYJrX2xGfHOhPA bo2Ap3Y2vGmXaN7AjIMYJmi7poowQkyckKdhci8rJsJ/I054ctrWLSMv10qmlqGxZnkeZa4ZK XhQPQ1Lr4GRFlCyqqeBCpu7RvSyS6Lb/mw6duyjq7e9ya4/gZmemt41BrJyanO1m2M+1j+6fi Y2N/umF2ulzBQugYXf/FpGTcLAJC+XiNQtilBn3GkFsZrGjaPmBqYCb7hiXmBvFl/l6cb9aaD N4O/xooL59O3xfyP7CvD455pxqDQIBTGIo/cAAL/8jEuclXPIe2jBWDKM2aQl8Dzaekk3A1Di Pnlmr8EJH9OHJoVid1GZMurO2eaz3EhUp9zaptDbOe5Lxo/X8PrErJHQYRNNWpsZRoDHPAx6j plF0mPjvH1YQ3XVdZj/TrVaI4O4ZaAKFDO7wllAuCqbmxbJDK7EdCJpgL/5c+MB12PySZhLay U4dcdr6yb7HvMQ7W5JOV+gjf32CLz2/j9nPs4XuGf7e4IGd1ddXtt2jO5rQ9aU4yVSPDkiCkM Ak8nulK5jh8FkiORPiwuCPGaRMLtQuGNfXEqYUlxXINIegYLWEWXj1V9r86q3t/SxJK9hV4l0 c2HwJPT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The platform_device_put() function was called in one case by the >> add_child() function during error handling even if the passed >> variable "pdev" contained a null pointer. >> >> Implementation details could be improved by the adjustment of jump targets >> according to the Linux coding style convention. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/mfd/dm355evm_msp.c | 21 ++++++++++----------- >> 1 file changed, 10 insertions(+), 11 deletions(-) > > Same comments as before. To which comments do you refer here? Are you interested in any further clarification of open issues? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 12 Jan 2016 08:34:40 +0000 Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after error detection Message-Id: <5694BAA0.80004@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <568284D3.3060006@users.sourceforge.net> <20160111083108.GC14104@x1> In-Reply-To: <20160111083108.GC14104@x1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> The platform_device_put() function was called in one case by the >> add_child() function during error handling even if the passed >> variable "pdev" contained a null pointer. >> >> Implementation details could be improved by the adjustment of jump targets >> according to the Linux coding style convention. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/mfd/dm355evm_msp.c | 21 ++++++++++----------- >> 1 file changed, 10 insertions(+), 11 deletions(-) > > Same comments as before. To which comments do you refer here? Are you interested in any further clarification of open issues? Regards, Markus