From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761660AbcALJf6 (ORCPT ); Tue, 12 Jan 2016 04:35:58 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:34521 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbcALJfx (ORCPT ); Tue, 12 Jan 2016 04:35:53 -0500 Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl To: Lee Jones References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> <5694584D.7040301@huawei.com> <20160112074107.GK19803@x1> <5694B68A.6040300@huawei.com> <20160112083946.GN19803@x1> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , From: xuejiancheng Message-ID: <5694C725.6010502@huawei.com> Date: Tue, 12 Jan 2016 17:28:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160112083946.GN19803@x1> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.217.211] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5694C731.005E,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 451545615172e45e64354914b7858cd4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/12 16:39, Lee Jones wrote: > On Tue, 12 Jan 2016, xuejiancheng wrote: > >> Hello Lee, >> >> On 2016/1/12 15:41, Lee Jones wrote: >>> On Tue, 12 Jan 2016, xuejiancheng wrote: >>> >>>> >>>> >>>> On 2016/1/11 16:55, Lee Jones wrote: >>>>> On Mon, 11 Jan 2016, xuejiancheng wrote: >>>>>> On 2016/1/11 13:48, Lee Jones wrote: >>>>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>>>>>> >>>>>>>> Add device tree bindings for Hi3519 system controller. >>>>>>>> >>>>>>>> Signed-off-by: Jiancheng Xue >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ >>>>>>>> 1 file changed, 14 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>> >>>>>>> I have this patch, but none of the others in the set, thus I am >>>>>>> lacking context. >>>>>>> >>>>>> I can forward other patches in the set to you. Thank you. >>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..115c5be >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> @@ -0,0 +1,14 @@ >>>>>>>> +* Hisilicon Hi3519 System Controller Block >>>>>>>> + >>>>>>>> +This bindings use the following binding: >>>>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>>>>>> +- reg: the register region of this block >>>>>>>> + >>>>>>>> +Examples: >>>>>>>> +sysctrl: system-controller@12010000 { >>>>>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; >>>>>>>> + reg = <0x12010000 0x1000>; >>>>>>>> +}; >>>>>>> >>>>>>> There is no requirement (nor want) for binding documents where the >>>>>>> given device is simply using highly generic bindings. This just >>>>>>> amounts to churn. >>>>>>> >>>>>> This block is specific for Hi3519 SOC, and may has its own driver. >>>>> >>>>> Does it have its own driver currently? >>>>> >>>> Not yet. >>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string >>>> with the SOC name. This binding is just used for describing the compatible string now. >>>> When more functions on hi3519 SOC are added later, the specific driver will be also >>>> needed. >>> >>> Save this binding until it has more functionality. We here "I'll add >>> to this later" all too often. >>> >> >> In the hi3519.dtsi file, there is a system-controller device node described like below: >> sysctrl: system-controller@12010000 { >> compatible = "hisilicon,hi3519-sysctrl", "syscon"; >> reg = <0x12010000 0x1000>; >> }; >> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the >> compatible string?　 > > Where is this compatible string _used_? > >> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding? >> Could you give some suggestions? Thank you very much! > > If you're not using the compatible i.e. the device doesn't have its > own driver yet, then there is no need to supply the binding at all, is > there? > OK. Thank you. >>>>>> So I think it's better to keep this binding. >>>>> >>>> >>> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuejiancheng Subject: Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl Date: Tue, 12 Jan 2016 17:28:05 +0800 Message-ID: <5694C725.6010502@huawei.com> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> <5694584D.7040301@huawei.com> <20160112074107.GK19803@x1> <5694B68A.6040300@huawei.com> <20160112083946.GN19803@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160112083946.GN19803@x1> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: mturquette@baylibre.com, sboyd@codeaurora.org, p.zabel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, khilman@linaro.org, arnd@arndb.de, olof@lixom.net, xuwei5@hisilicon.com, haojian.zhuang@linaro.org, zhangfei.gao@linaro.org, bintian.wang@huawei.com, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, yanhaifeng@hisilicon.com, yanghongwei@hisilicon.com, suwenping@hisilicon.com, ml.yang@hisilicon.com, gaofei@hisilicon.com, zhangzhenxing@hisilicon.com, xuejiancheng@hisilicon.com List-Id: devicetree@vger.kernel.org On 2016/1/12 16:39, Lee Jones wrote: > On Tue, 12 Jan 2016, xuejiancheng wrote: >=20 >> Hello Lee, >> >> On 2016/1/12 15:41, Lee Jones wrote: >>> On Tue, 12 Jan 2016, xuejiancheng wrote: >>> >>>> >>>> >>>> On 2016/1/11 16:55, Lee Jones wrote: >>>>> On Mon, 11 Jan 2016, xuejiancheng wrote: >>>>>> On 2016/1/11 13:48, Lee Jones wrote: >>>>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>>>>>> >>>>>>>> Add device tree bindings for Hi3519 system controller. >>>>>>>> >>>>>>>> Signed-off-by: Jiancheng Xue >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 +++++++= +++++++ >>>>>>>> 1 file changed, 14 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi35= 19.txt >>>>>>> >>>>>>> I have this patch, but none of the others in the set, thus I am >>>>>>> lacking context. >>>>>>> >>>>>> I can forward other patches in the set to you. Thank you. >>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt = b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..115c5be >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> @@ -0,0 +1,14 @@ >>>>>>>> +* Hisilicon Hi3519 System Controller Block >>>>>>>> + >>>>>>>> +This bindings use the following binding: >>>>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>>>>>> +- reg: the register region of this block >>>>>>>> + >>>>>>>> +Examples: >>>>>>>> +sysctrl: system-controller@12010000 { >>>>>>>> + compatible =3D "hisilicon,hi3519-sysctrl", "syscon"; >>>>>>>> + reg =3D <0x12010000 0x1000>; >>>>>>>> +}; >>>>>>> >>>>>>> There is no requirement (nor want) for binding documents where = the >>>>>>> given device is simply using highly generic bindings. This jus= t >>>>>>> amounts to churn. >>>>>>> >>>>>> This block is specific for Hi3519 SOC, and may has its own drive= r. >>>>> >>>>> Does it have its own driver currently? >>>>> >>>> Not yet. >>>> Arnd Bergmann and Rob Herring all suggested adding a specific comp= atible string >>>> with the SOC name. This binding is just used for describing the co= mpatible string now. >>>> When more functions on hi3519 SOC are added later, the specific dr= iver will be also >>>> needed. >>> >>> Save this binding until it has more functionality. We here "I'll a= dd >>> to this later" all too often. >>> >> >> In the hi3519.dtsi file, there is a system-controller device node de= scribed like below: >> sysctrl: system-controller@12010000 { >> compatible =3D "hisilicon,hi3519-sysctrl", "syscon"; >> reg =3D <0x12010000 0x1000>; >> }; >> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just= use "syscon" as the >> compatible string?=E3=80=80 >=20 > Where is this compatible string _used_? >=20 >> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should= I put this binding? >> Could you give some suggestions? Thank you very much! >=20 > If you're not using the compatible i.e. the device doesn't have its > own driver yet, then there is no need to supply the binding at all, i= s > there? >=20 OK. Thank you. >>>>>> So I think it's better to keep this binding. >>>>> >>>> >>> >> >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuejiancheng@huawei.com (xuejiancheng) Date: Tue, 12 Jan 2016 17:28:05 +0800 Subject: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl In-Reply-To: <20160112083946.GN19803@x1> References: <1452219400-32478-1-git-send-email-xuejiancheng@huawei.com> <1452219400-32478-6-git-send-email-xuejiancheng@huawei.com> <20160111054846.GD3331@x1> <56935EA8.4060801@huawei.com> <20160111085555.GE14104@x1> <5694584D.7040301@huawei.com> <20160112074107.GK19803@x1> <5694B68A.6040300@huawei.com> <20160112083946.GN19803@x1> Message-ID: <5694C725.6010502@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/1/12 16:39, Lee Jones wrote: > On Tue, 12 Jan 2016, xuejiancheng wrote: > >> Hello Lee, >> >> On 2016/1/12 15:41, Lee Jones wrote: >>> On Tue, 12 Jan 2016, xuejiancheng wrote: >>> >>>> >>>> >>>> On 2016/1/11 16:55, Lee Jones wrote: >>>>> On Mon, 11 Jan 2016, xuejiancheng wrote: >>>>>> On 2016/1/11 13:48, Lee Jones wrote: >>>>>>> On Fri, 08 Jan 2016, Jiancheng Xue wrote: >>>>>>> >>>>>>>> Add device tree bindings for Hi3519 system controller. >>>>>>>> >>>>>>>> Signed-off-by: Jiancheng Xue >>>>>>>> --- >>>>>>>> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ >>>>>>>> 1 file changed, 14 insertions(+) >>>>>>>> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>> >>>>>>> I have this patch, but none of the others in the set, thus I am >>>>>>> lacking context. >>>>>>> >>>>>> I can forward other patches in the set to you. Thank you. >>>>>> >>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> new file mode 100644 >>>>>>>> index 0000000..115c5be >>>>>>>> --- /dev/null >>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt >>>>>>>> @@ -0,0 +1,14 @@ >>>>>>>> +* Hisilicon Hi3519 System Controller Block >>>>>>>> + >>>>>>>> +This bindings use the following binding: >>>>>>>> +Documentation/devicetree/bindings/mfd/syscon.txt >>>>>>>> + >>>>>>>> +Required properties: >>>>>>>> +- compatible: "hisilicon,hi3519-sysctrl". >>>>>>>> +- reg: the register region of this block >>>>>>>> + >>>>>>>> +Examples: >>>>>>>> +sysctrl: system-controller at 12010000 { >>>>>>>> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; >>>>>>>> + reg = <0x12010000 0x1000>; >>>>>>>> +}; >>>>>>> >>>>>>> There is no requirement (nor want) for binding documents where the >>>>>>> given device is simply using highly generic bindings. This just >>>>>>> amounts to churn. >>>>>>> >>>>>> This block is specific for Hi3519 SOC, and may has its own driver. >>>>> >>>>> Does it have its own driver currently? >>>>> >>>> Not yet. >>>> Arnd Bergmann and Rob Herring all suggested adding a specific compatible string >>>> with the SOC name. This binding is just used for describing the compatible string now. >>>> When more functions on hi3519 SOC are added later, the specific driver will be also >>>> needed. >>> >>> Save this binding until it has more functionality. We here "I'll add >>> to this later" all too often. >>> >> >> In the hi3519.dtsi file, there is a system-controller device node described like below: >> sysctrl: system-controller at 12010000 { >> compatible = "hisilicon,hi3519-sysctrl", "syscon"; >> reg = <0x12010000 0x1000>; >> }; >> Do you mean that I should remove "hisilicon,hi3519-sysctrl" and just use "syscon" as the >> compatible string?? > > Where is this compatible string _used_? > >> If I want to add "hisilicon,hi3519-sysctrl" for hi3519. where should I put this binding? >> Could you give some suggestions? Thank you very much! > > If you're not using the compatible i.e. the device doesn't have its > own driver yet, then there is no need to supply the binding at all, is > there? > OK. Thank you. >>>>>> So I think it's better to keep this binding. >>>>> >>>> >>> >> >