From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aIxeg-0002eJ-LM
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:02:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aIxeb-0000mr-JW
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:02:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57132)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1aIxeb-0000mm-Ak
	for qemu-devel@nongnu.org; Tue, 12 Jan 2016 07:02:25 -0500
References: <1450803119-4223-1-git-send-email-mst@redhat.com>
	<1450803119-4223-15-git-send-email-mst@redhat.com>
	<568F7BE8.9060505@redhat.com>
	<20160112130514-mutt-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5694EB48.6040909@redhat.com>
Date: Tue, 12 Jan 2016 13:02:16 +0100
MIME-Version: 1.0
In-Reply-To: <20160112130514-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 14/55] ipmi: Add a local BMC simulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Xiao Guangrong <guangrong.xiao@linux.intel.com>, Corey Minyard <cminyard@mvista.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Shannon Zhao <zhaoshenglong@huawei.com>



On 12/01/2016 12:06, Michael S. Tsirkin wrote:
>>> > > +{
>>> > > +    if ((netfn & 1) || (netfn > MAX_NETFNS) || (s->netfns[netfn / 2])) {
>> > 
>> > Off by one.  The check should be >=, not >.
>> > 
>> > Paolo
> Corey, can you look into this please?
> 


He already posted some fixes yesterday.

Paolo