From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 20/22] drm/tilcdc: Nuke preclose hook Date: Tue, 12 Jan 2016 16:19:39 +0200 Message-ID: <56950B7B.1030006@ti.com> References: <1452548477-15905-1-git-send-email-daniel.vetter@ffwll.ch> <1452548477-15905-21-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0546752946==" Return-path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5D526E3D1 for ; Tue, 12 Jan 2016 06:19:44 -0800 (PST) In-Reply-To: <1452548477-15905-21-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Intel Graphics Development , "Sarha, Jyri" List-Id: dri-devel@lists.freedesktop.org --===============0546752946== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CkwDt8FcHX6FkKbr5KmfxPIGaWM8HHxgJ" --CkwDt8FcHX6FkKbr5KmfxPIGaWM8HHxgJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/01/16 23:41, Daniel Vetter wrote: > Again since the drm core takes care of event unlinking/disarming this > is now just needless code. >=20 > v2: Fixup misplaced hunks. >=20 > Cc: Rob Clark > Acked-by: Daniel Stone > Reviewed-by: Alex Deucher (v1) > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 20 -------------------- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 8 -------- > drivers/gpu/drm/tilcdc/tilcdc_drv.h | 1 - > 3 files changed, 29 deletions(-) >=20 > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/til= cdc/tilcdc_crtc.c > index 7d07733bdc86..4802da8e6d6f 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -662,26 +662,6 @@ irqreturn_t tilcdc_crtc_irq(struct drm_crtc *crtc)= > return IRQ_HANDLED; > } > =20 > -void tilcdc_crtc_cancel_page_flip(struct drm_crtc *crtc, struct drm_fi= le *file) > -{ > - struct tilcdc_crtc *tilcdc_crtc =3D to_tilcdc_crtc(crtc); > - struct drm_pending_vblank_event *event; > - struct drm_device *dev =3D crtc->dev; > - unsigned long flags; > - > - /* Destroy the pending vertical blanking event associated with the > - * pending page flip, if any, and disable vertical blanking interrupt= s. > - */ > - spin_lock_irqsave(&dev->event_lock, flags); > - event =3D tilcdc_crtc->event; > - if (event && event->base.file_priv =3D=3D file) { > - tilcdc_crtc->event =3D NULL; > - event->base.destroy(&event->base); > - drm_vblank_put(dev, 0); > - } > - spin_unlock_irqrestore(&dev->event_lock, flags); > -} > - Hmm, looks fine, but when I was comparing the omapdrm change and this one, I see tilcdc doing drm_vblank_put() in the removed code but omapdrm doesn't. The other patches that nuke preclose hooks also contain vblank_put. Will there be a vblank_put call missing here, or will there be an extra vblank_put call happening somewhere on omapdrm? Tomi --CkwDt8FcHX6FkKbr5KmfxPIGaWM8HHxgJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWlQt7AAoJEPo9qoy8lh718rYP/RVxceFwh96PvCym7AZs5797 uN4fUT71os2ioeQ7Ge3rOBIwRl1FVoXZ85Obh53XdRYXl89yAyqlEEUpP9az/Pkp MckMRmj4/kT5iRlY86s/gOyaJdEX95Jtul3o/5z1XpIvFOLQd/pXpNt4I2NRZoaf YUP+dM0DaQqK28FLL5XYiyUNKGjf+g78HnyswqGpj0OROg8p2x5aaZbQd1j3rorF 4+MEzpxDFZq8P+sDXDVFYIXozoRE6GV3SgSHLUIq57nxEp00OvUVg9AxyY9L+1N2 aey+txLxOoLMRYp+9LO7JTPoZSFpN27Fj55pyvx325JifyXJowzwWEiSCNl/+Qgt Sfznlz1QhxLy1NdSibcdJRjlakGikX7ATNhtMK0qfzgtfZ4swXZaa7SO+AFBtvzG 47XaWSpw31l6GajIkghs/Kwq6znyND5SIN7ukAQhBGGbTZyC/gqbY7cmo5Uk8a7j WDzw3lO2h22+o/UIqFtMfY0a7jOscphAofFEtJPprrxeVEfICGZn7JepLq5PA3vj PjX7Tr9xyYCKzJmgEoK+ug8mfa24pPLPhOLgHMB9uM6ZDZASkmMvfbFnGX+uG7Fj Nmz198PEbmmQgjpI1biXV6CPEuP/bnzkJR6gxpHpuDlRIs+yM2+66IG5hOulO7Bh 2yQxd5KXdBHKyRpbSAmI =hCEr -----END PGP SIGNATURE----- --CkwDt8FcHX6FkKbr5KmfxPIGaWM8HHxgJ-- --===============0546752946== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0546752946==--