From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 16/22] drm/omap: Nuke close hooks Date: Wed, 13 Jan 2016 13:00:38 +0200 Message-ID: <56962E56.6010200@ti.com> References: <1452548477-15905-1-git-send-email-daniel.vetter@ffwll.ch> <1452548477-15905-17-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0281805497==" Return-path: In-Reply-To: <1452548477-15905-17-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Intel Graphics Development , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org --===============0281805497== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Gor8rLJkM0ge9Nk6BG20nI17j25AuaWLT" --Gor8rLJkM0ge9Nk6BG20nI17j25AuaWLT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Daniel, On 11/01/16 23:41, Daniel Vetter wrote: > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapd= rm/omap_drv.c > index dfafdb602ad2..603a65498b40 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -175,17 +175,6 @@ static int omap_atomic_commit(struct drm_device *d= ev, > priv->commit.pending |=3D commit->crtcs; > spin_unlock(&priv->commit.lock); > =20 > - /* Keep track of all CRTC events to unlink them in preclose(). */ > - spin_lock_irqsave(&dev->event_lock, flags); > - for (i =3D 0; i < dev->mode_config.num_crtc; ++i) { > - struct drm_crtc_state *cstate =3D state->crtc_states[i]; > - > - if (cstate && cstate->event) > - list_add_tail(&cstate->event->base.link, > - &priv->commit.events); > - } > - spin_unlock_irqrestore(&dev->event_lock, flags); > - > /* Swap the state, this is the point of no return. */ > drm_atomic_helper_swap_state(dev, state); 'flags' local needs to be removed from omap_atomic_commit, otherwise: drivers/gpu/drm/omapdrm/omap_drv.c:145:16: error: unused variable 'flags'= Tomi --Gor8rLJkM0ge9Nk6BG20nI17j25AuaWLT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWli5WAAoJEPo9qoy8lh71ytsP/iLzOGqGo9K+ZQWlbcwJyyzL Tbz6zMSpr/HpHnpo6c168uBEftu4bmTo1fIuaeccGQjPG1qOZVZvHn31H0tqGUqG LlKtlzh0tpfqVrUFNkMQbtFEoni+d2M+anFiHELKmBIvp0BOBJUaoLrCxfGmEPuS M6ucSQNZboBfC44aU024MFS/1Q1EA0k4XNS86+EQ3qFhNtlbNU/ac6oMO5DHLboP emKTUi6/jXAvm5JjChbWl5LfbqWqRZEbl4v7QT8E3ZT0hKSA75jNpKs3X/segVev HMwVOLoRXoh3FPX6JJZsF7ruLfg3+cWx4Zj1QGNwk4Imb/iZrPdawqc9rpQfJ4oW DZWBCNtWr7wmOtq1yJVCAa0oDzdlJQ//856e3jIL3LP4jd+8iBB8VLGYp+yqZCPr EJXG031+dVyXjX3VbivusQlnlr+1gRHqZjehNk5k50TNMnBSCCS2WSFCdzgJDGSD H/TXXquiP0brk9K8t7PUpejmWiZ+KcyfJ6ws4C7aEca+m0k9gNjTXGs/hfB+m4tf 4mBE/nKSCG9B/bn3X5vkNHhWGTi25baFBvkoGA96U8FVPf4L5f7/28XtC1/2Z7BJ G2BUlXBqiMVtap4KwsUXSusKo1xikBE/CQ0qQ3g09aRD2cHiaM+g9rmxoTu2sQt4 PbY0C1mLEAxgAUsayGc3 =LwFe -----END PGP SIGNATURE----- --Gor8rLJkM0ge9Nk6BG20nI17j25AuaWLT-- --===============0281805497== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0281805497==--