From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 1/5] xen/elfnotes: initialise phys_entry to
 UNSET_ADDR32
Date: Wed, 13 Jan 2016 13:05:40 +0000
Message-ID: <56964BA4.5050701@citrix.com>
References: <1452688338-70075-1-git-send-email-roger.pau@citrix.com>
	<1452688338-70075-2-git-send-email-roger.pau@citrix.com>
	<5696553302000078000C649D@prv-mh.provo.novell.com>
	<56964881.9000707@citrix.com>
	<5696590E02000078000C64F7@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=8132bb835=Andrew.Cooper3@citrix.com>)
	id 1aJL7Q-00078e-IA
	for xen-devel@lists.xenproject.org; Wed, 13 Jan 2016 13:05:44 +0000
In-Reply-To: <5696590E02000078000C64F7@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On 13/01/16 13:02, Jan Beulich wrote:
>>>> On 13.01.16 at 13:52, <roger.pau@citrix.com> wrote:
>> El 13/01/16 a les 13.46, Jan Beulich ha escrit:
>>>>>> On 13.01.16 at 13:32, <roger.pau@citrix.com> wrote:
>>> Re the title: I think the fix here really is to the checking against the
>>> right value, not the initialization?
>> Yes, the initialization doesn't matter much, the proper fix is the
>> checking. I would change it to:
>>
>> xen/elfnotes: check phys_entry against UNSET_ADDR32
>>
>> Which I think can be done by the committer (or I can resend if needed).
> Sure.
>
>>>>  tools/libxc/xc_dom_elfloader.c     | 2 +-
>>>>  xen/common/libelf/libelf-dominfo.c | 1 +
>>>>  xen/include/xen/libelf.h           | 1 +
>>>>  3 files changed, 3 insertions(+), 1 deletion(-)
>>> With this diffstat, any reason only tools maintainers got Cc-ed?
>> Hm, weird, that's what scripts/get_maintainer.pl gave me as output.
> Something must be broken there.

There is not an entry covering xen/common.

~Andrew