From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aJMXH-0003oN-Vy for qemu-devel@nongnu.org; Wed, 13 Jan 2016 09:36:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aJMXH-0000K4-32 for qemu-devel@nongnu.org; Wed, 13 Jan 2016 09:36:31 -0500 References: <1451506316-31975-1-git-send-email-rkagan@virtuozzo.com> From: Laszlo Ersek Message-ID: <569660E2.3050608@redhat.com> Date: Wed, 13 Jan 2016 15:36:18 +0100 MIME-Version: 1.0 In-Reply-To: <1451506316-31975-1-git-send-email-rkagan@virtuozzo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] i386: expose floppy-related objects in SSDT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Kagan , qemu-devel@nongnu.org Cc: Kevin Wolf , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-stable@nongnu.org, "Dr. David Alan Gilbert (git)" , Igor Mammedov , Paolo Bonzini , John Snow , Richard Henderson Hi Roman, On 12/30/15 21:11, Roman Kagan wrote: > Windows on UEFI systems is only capable of detecting the presence and > the type of floppy drives via corresponding ACPI objects. I'm late to the party, but please allow me a question: how did you figure out that UEFI Windows requires this? In general, what the ACPI specification says is at best a "guideline" for Windows. So how did you prove this was a requirement for Windows? Thanks Laszlo > > Those objects are added in patch 5; the preceding ones pave the way to > it, by making the necessary data public and by moving the whole > floppy drive controller description into runtime-generated SSDT. > > Note that the series conflicts with Igor's patchset for dynamic DSDT, in > particular, with "[PATCH v2 27/51] pc: acpi: move FDC0 device from DSDT > to SSDT"; I haven't managed to avoid that while trying to meet > maintainer's comments. > > Roman Kagan (6): > i386/pc: expose identifying the floppy controller > i386/acpi: make floppy controller object dynamic > tests/acpi: update test data > expose floppy drive geometry and CMOS type > i386: populate floppy drive information in SSDT > tests/acpi: update test data > > Signed-off-by: Roman Kagan > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Igor Mammedov > Cc: John Snow > Cc: Kevin Wolf > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: qemu-block@nongnu.org > Cc: qemu-stable@nongnu.org > --- > changes since v4: > - re-split out code changes from test data updates > > changes since v3: > - make FDC object fully dynamic in a separate patch > - split out support patches > - include test data updates with the respective patches to maintain > bisectability > > changes since v2: > - explicit endianness for buffer data > - reorder code to reduce conflicts with dynamic DSDT patchset > - update test data > > hw/block/fdc.c | 11 +++++ > hw/i386/acpi-build.c | 92 ++++++++++++++++++++++++++++++++++++ > hw/i386/acpi-dsdt-isa.dsl | 18 ------- > hw/i386/acpi-dsdt.dsl | 1 - > hw/i386/pc.c | 46 ++++++++++-------- > hw/i386/q35-acpi-dsdt.dsl | 7 +-- > include/hw/block/fdc.h | 2 + > include/hw/i386/pc.h | 3 ++ > tests/acpi-test-data/pc/DSDT | Bin 3028 -> 2946 bytes > tests/acpi-test-data/pc/SSDT | Bin 2486 -> 2635 bytes > tests/acpi-test-data/pc/SSDT.bridge | Bin 4345 -> 4494 bytes > tests/acpi-test-data/q35/DSDT | Bin 7666 -> 7578 bytes > 12 files changed, 137 insertions(+), 43 deletions(-) >