From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v1 5/5] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes Date: Wed, 13 Jan 2016 18:04:25 +0100 Message-ID: <56968399.5070706@atmel.com> References: <1452702857-2240-1-git-send-email-romain.izard.pro@gmail.com> <1452702857-2240-6-git-send-email-romain.izard.pro@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1452702857-2240-6-git-send-email-romain.izard.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Romain Izard , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Brian Norris Cc: Yang Wenyou , Josh Wu , linux-arm-kernel , Alexandre Belloni List-Id: devicetree@vger.kernel.org Le 13/01/2016 17:34, Romain Izard a =E9crit : > Both nodes are required to access NAND Flash memory. Additional > settings will be necessary at the board level to use it. >=20 > Signed-off-by: Romain Izard > --- > arch/arm/boot/dts/sama5d2.dtsi | 38 ++++++++++++++++++++++++++++++++= ++++++ > 1 file changed, 38 insertions(+) >=20 > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5= d2.dtsi > index aee571448342..80420177ec1a 100644 > --- a/arch/arm/boot/dts/sama5d2.dtsi > +++ b/arch/arm/boot/dts/sama5d2.dtsi > @@ -265,6 +265,44 @@ > cache-level =3D <2>; > }; > =20 > + nand0: nand@80000000 { > + compatible =3D "atmel,sama5d2-nand"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + ranges; > + reg =3D < /* EBI CS3 */ > + 0x80000000 0x08000000 > + /* SMC PMECC regs */ > + 0xf8014070 0x00000490 > + /* SMC PMECC Error Location regs */ > + 0xf8014500 0x00000200 > + /* ROM Galois tables */ > + 0x00040000 0x00018000 > + >; > + interrupts =3D <17 IRQ_TYPE_LEVEL_HIGH 6>; > + atmel,nand-addr-offset =3D <21>; > + atmel,nand-cmd-offset =3D <22>; > + atmel,nand-has-dma; > + atmel,has-pmecc; > + atmel,pmecc-lookup-table-offset =3D <0x0 0x8000>; > + status =3D "disabled"; > + > + nfc@90000000 { It's nfc@c0000000 > + compatible =3D "atmel,sama5d4-nfc"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + reg =3D < /* NFC Command Registers */ > + 0xC0000000 0x08000000 Lower case please > + /* NFC HSMC regs */ > + 0xf8014000 0x00000070 > + /* NFC SRAM banks */ > + 0x00100000 0x00100000 > + >; > + clocks =3D <&hsmc_clk>; > + atmel,write-by-sram; > + }; > + }; > + Otherwise, it seems okay. When corrected, you can add my: Acked-by: Nicolas Ferre Brian, Wenyou, I'm okay if this patch goes to Mainline with the mtd subsystem: there should be no conflict with arm-soc for the upcoming kernel revisions. Thanks, bye. > sdmmc0: sdio-host@a0000000 { > compatible =3D "atmel,sama5d2-sdhci"; > reg =3D <0xa0000000 0x300>; >=20 --=20 Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH v1 5/5] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes To: Romain Izard , , , Brian Norris References: <1452702857-2240-1-git-send-email-romain.izard.pro@gmail.com> <1452702857-2240-6-git-send-email-romain.izard.pro@gmail.com> CC: Yang Wenyou , Josh Wu , linux-arm-kernel , Alexandre Belloni From: Nicolas Ferre Message-ID: <56968399.5070706@atmel.com> Date: Wed, 13 Jan 2016 18:04:25 +0100 MIME-Version: 1.0 In-Reply-To: <1452702857-2240-6-git-send-email-romain.izard.pro@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 13/01/2016 17:34, Romain Izard a écrit : > Both nodes are required to access NAND Flash memory. Additional > settings will be necessary at the board level to use it. > > Signed-off-by: Romain Izard > --- > arch/arm/boot/dts/sama5d2.dtsi | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > index aee571448342..80420177ec1a 100644 > --- a/arch/arm/boot/dts/sama5d2.dtsi > +++ b/arch/arm/boot/dts/sama5d2.dtsi > @@ -265,6 +265,44 @@ > cache-level = <2>; > }; > > + nand0: nand@80000000 { > + compatible = "atmel,sama5d2-nand"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + reg = < /* EBI CS3 */ > + 0x80000000 0x08000000 > + /* SMC PMECC regs */ > + 0xf8014070 0x00000490 > + /* SMC PMECC Error Location regs */ > + 0xf8014500 0x00000200 > + /* ROM Galois tables */ > + 0x00040000 0x00018000 > + >; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>; > + atmel,nand-addr-offset = <21>; > + atmel,nand-cmd-offset = <22>; > + atmel,nand-has-dma; > + atmel,has-pmecc; > + atmel,pmecc-lookup-table-offset = <0x0 0x8000>; > + status = "disabled"; > + > + nfc@90000000 { It's nfc@c0000000 > + compatible = "atmel,sama5d4-nfc"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = < /* NFC Command Registers */ > + 0xC0000000 0x08000000 Lower case please > + /* NFC HSMC regs */ > + 0xf8014000 0x00000070 > + /* NFC SRAM banks */ > + 0x00100000 0x00100000 > + >; > + clocks = <&hsmc_clk>; > + atmel,write-by-sram; > + }; > + }; > + Otherwise, it seems okay. When corrected, you can add my: Acked-by: Nicolas Ferre Brian, Wenyou, I'm okay if this patch goes to Mainline with the mtd subsystem: there should be no conflict with arm-soc for the upcoming kernel revisions. Thanks, bye. > sdmmc0: sdio-host@a0000000 { > compatible = "atmel,sama5d2-sdhci"; > reg = <0xa0000000 0x300>; > -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Wed, 13 Jan 2016 18:04:25 +0100 Subject: [PATCH v1 5/5] ARM: at91/dt: sama5d2: add nand0 and nfc0 nodes In-Reply-To: <1452702857-2240-6-git-send-email-romain.izard.pro@gmail.com> References: <1452702857-2240-1-git-send-email-romain.izard.pro@gmail.com> <1452702857-2240-6-git-send-email-romain.izard.pro@gmail.com> Message-ID: <56968399.5070706@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 13/01/2016 17:34, Romain Izard a ?crit : > Both nodes are required to access NAND Flash memory. Additional > settings will be necessary at the board level to use it. > > Signed-off-by: Romain Izard > --- > arch/arm/boot/dts/sama5d2.dtsi | 38 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi > index aee571448342..80420177ec1a 100644 > --- a/arch/arm/boot/dts/sama5d2.dtsi > +++ b/arch/arm/boot/dts/sama5d2.dtsi > @@ -265,6 +265,44 @@ > cache-level = <2>; > }; > > + nand0: nand at 80000000 { > + compatible = "atmel,sama5d2-nand"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + reg = < /* EBI CS3 */ > + 0x80000000 0x08000000 > + /* SMC PMECC regs */ > + 0xf8014070 0x00000490 > + /* SMC PMECC Error Location regs */ > + 0xf8014500 0x00000200 > + /* ROM Galois tables */ > + 0x00040000 0x00018000 > + >; > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>; > + atmel,nand-addr-offset = <21>; > + atmel,nand-cmd-offset = <22>; > + atmel,nand-has-dma; > + atmel,has-pmecc; > + atmel,pmecc-lookup-table-offset = <0x0 0x8000>; > + status = "disabled"; > + > + nfc at 90000000 { It's nfc at c0000000 > + compatible = "atmel,sama5d4-nfc"; > + #address-cells = <1>; > + #size-cells = <1>; > + reg = < /* NFC Command Registers */ > + 0xC0000000 0x08000000 Lower case please > + /* NFC HSMC regs */ > + 0xf8014000 0x00000070 > + /* NFC SRAM banks */ > + 0x00100000 0x00100000 > + >; > + clocks = <&hsmc_clk>; > + atmel,write-by-sram; > + }; > + }; > + Otherwise, it seems okay. When corrected, you can add my: Acked-by: Nicolas Ferre Brian, Wenyou, I'm okay if this patch goes to Mainline with the mtd subsystem: there should be no conflict with arm-soc for the upcoming kernel revisions. Thanks, bye. > sdmmc0: sdio-host at a0000000 { > compatible = "atmel,sama5d2-sdhci"; > reg = <0xa0000000 0x300>; > -- Nicolas Ferre