From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E5E7A; Mon, 28 Feb 2022 16:32:17 +0000 (UTC) Received: by mail-wm1-f51.google.com with SMTP id c192so6018618wma.4; Mon, 28 Feb 2022 08:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=FPcvzvX3MDs+LdnqfpdttONymmd5Rh4uve9/n2nXP25NoIaAzzIdxwwWDw74Eu2KAI s7CcDs1KSGhtfBpOFKS9DacY1Xo9WueMmBUvHWJ3xmIJP7JG2mKiuTOJkrLHQvGUsCoX 3MGqYVcHH8JyXnG9VDBJa2G3WdzVY2i8A6bUaV2YeoVt43Y7Gk0EGEkO8giTcRgXZEa1 d2sIdsyHQvoAkmkkfV/trDwqaYFMLsGxnRmU6/rgU/hUm/p4fIAuhDbtVGD4HTE9KA/T jV9dQimHsukOP9QwzcTcDUq5vajfFEy6WqvtxDGfLVRtKL6+dKj0XvnqoXXF/qh+qYUL DsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=o87hqnv4IGCL4G2JvXAx7TXEdGF3EMfkK34zTcupAq7PS4rf+9WGnYe2ZAjl0P0Fb3 NZwlNgrVmq0KgvvW6883UcRxwNO/j6GcTwbtiwRr6FxLVX6KnaYD3GxOMRhS0UVlD6Ew uASNAw5rq6lZILTyLK4j42OD7C6mNZUepD/b0KuRBcBPFVE3MO1OnDieA+6fVrU56xTS NlnvEOr9JdZ7zrlW7K441n3hru24K6KUvKC/4Dw1sQsUqjOVCMGishTe1l4eUDixe1tj uDZZOSuQDqpbpU+0TWjFDweU+7/R/rtdeaU7a3hQp/uaXZsqaw7b6TYi0iCqHiHkKl0a G6Yw== X-Gm-Message-State: AOAM5304ikwVb0RbjFFHuETHH+Ucwc1c2eIt+AUPIjCMyDfVZ+paX9qy UhHdBT/GdUQCUJolSpGXHwM= X-Google-Smtp-Source: ABdhPJy/RE308BOWztEfvBeC+M/1tepbLiYUtCH/0hJf9ShvYGyv+1u2o9DxOIVpfyR+PA44lN0jhw== X-Received: by 2002:a05:600c:418b:b0:380:e493:660a with SMTP id p11-20020a05600c418b00b00380e493660amr13779838wmh.189.1646065935336; Mon, 28 Feb 2022 08:32:15 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id u4-20020adfdb84000000b001e8d8ac5394sm11503518wri.110.2022.02.28.08.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 08:32:14 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, Nicolas Dufresne Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [RFC PATCH 2/8] media: Add P010 format Date: Mon, 28 Feb 2022 17:32:13 +0100 Message-ID: <5696849.MhkbZ0Pkbq@kista> In-Reply-To: <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> References: <20220227144926.3006585-1-jernej.skrabec@gmail.com> <20220227144926.3006585-3-jernej.skrabec@gmail.com> <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Dne ponedeljek, 28. februar 2022 ob 13:48:53 CET je Nicolas Dufresne=20 napisal(a): > Le dimanche 27 f=E9vrier 2022 =E0 15:49 +0100, Jernej Skrabec a =E9crit : > > Add P010 format, which is commonly used for 10-bit videos. >=20 > There is a much more complete patch that was sent previously (with=20 documentation > and all): >=20 > https://patchwork.kernel.org/project/linux-rockchip/patch/ 20210618131526.566762-5-benjamin.gaignard@collabora.com/ Great, I'll take it for next revision. Although I'm not sure what "much mor= e=20 complete" means. Only additional thing is documentation. Best regards, Jernej >=20 > regards, > Nicolas >=20 > >=20 > > Signed-off-by: Jernej Skrabec > > --- > > drivers/media/v4l2-core/v4l2-common.c | 2 ++ > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/uapi/linux/videodev2.h | 1 + > > 3 files changed, 4 insertions(+) > >=20 > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2- core/v4l2-common.c > > index 1db0020e08c0..4ede36546e9c 100644 > > --- a/drivers/media/v4l2-core/v4l2-common.c > > +++ b/drivers/media/v4l2-core/v4l2-common.c > > @@ -275,6 +275,8 @@ const struct v4l2_format_info *v4l2_format_info(u32= =20 format) > > { .format =3D V4L2_PIX_FMT_YUV422P, .pixel_enc =3D=20 V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 3, .bpp =3D { 1, 1,= 1, 0 },=20 =2Ehdiv =3D 2, .vdiv =3D 1 }, > > { .format =3D V4L2_PIX_FMT_GREY, .pixel_enc =3D=20 V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 1, .bpp =3D { 1, 0,= 0, 0 },=20 =2Ehdiv =3D 1, .vdiv =3D 1 }, > > =20 > > + { .format =3D V4L2_PIX_FMT_P010, .pixel_enc =3D=20 V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 },=20 =2Ehdiv =3D 2, .vdiv =3D 2 }, > > + > > /* Tiled YUV formats */ > > { .format =3D V4L2_PIX_FMT_NV12_4L4, .pixel_enc =3D=20 V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 1, 2,= 0, 0 },=20 =2Ehdiv =3D 2, .vdiv =3D 2 }, > > { .format =3D V4L2_PIX_FMT_P010_4L4, .pixel_enc =3D=20 V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 },=20 =2Ehdiv =3D 2, .vdiv =3D 2 }, > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2- core/v4l2-ioctl.c > > index 048f326c57b9..a8d999e23e5b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1295,6 +1295,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc= =20 *fmt) > > case V4L2_PIX_FMT_M420: descr =3D "YUV 4:2:0=20 (M420)"; break; > > case V4L2_PIX_FMT_NV12: descr =3D "Y/CbCr 4:2:0"; break; > > case V4L2_PIX_FMT_NV21: descr =3D "Y/CrCb 4:2:0"; break; > > + case V4L2_PIX_FMT_P010: descr =3D "10-bit Y/CbCr 4:2:0";=20 break; > > case V4L2_PIX_FMT_NV16: descr =3D "Y/CbCr 4:2:2"; break; > > case V4L2_PIX_FMT_NV61: descr =3D "Y/CrCb 4:2:2"; break; > > case V4L2_PIX_FMT_NV24: descr =3D "Y/CbCr 4:4:4"; break; > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/ videodev2.h > > index 772dbadd1a24..211bc11a48cb 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -597,6 +597,7 @@ struct v4l2_pix_format { > > /* two planes -- one Y, one Cr + Cb interleaved */ > > #define V4L2_PIX_FMT_NV12 v4l2_fourcc('N', 'V', '1', '2') /* 12 Y/= CbCr=20 4:2:0 */ > > #define V4L2_PIX_FMT_NV21 v4l2_fourcc('N', 'V', '2', '1') /* 12 Y/= CrCb=20 4:2:0 */ > > +#define V4L2_PIX_FMT_P010 v4l2_fourcc('P', '0', '1', '0') /* 24 Y/= CbCr=20 4:2:0 10-bit */ > > #define V4L2_PIX_FMT_NV16 v4l2_fourcc('N', 'V', '1', '6') /* 16 Y/= CbCr=20 4:2:2 */ > > #define V4L2_PIX_FMT_NV61 v4l2_fourcc('N', 'V', '6', '1') /* 16 Y/= CrCb=20 4:2:2 */ > > #define V4L2_PIX_FMT_NV24 v4l2_fourcc('N', 'V', '2', '4') /* 24 Y/= CbCr=20 4:4:4 */ >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D08A3C433F5 for ; Mon, 28 Feb 2022 16:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E8ppsIbAkhjzEnaD8kH4fPvTz+c1T5SH4u/zVmuLGIM=; b=hq1L/ENg6B5kmR n2aRNOZOcqs5Rtllq2BplzhdyS2s6UPZHERKqa39qElpNfwEhaelAdUcBt5R1CHa77jp+t6fK9901 R9ck+VZ46/Apb6xhsHpQcpDVIcj5caBjXRip+ug0Rj7ZmTqBmWurhgjrzbRcj6bH3VELMU3PE5s5t cKFELvfnSrHI9XQ1IaVDK3Mw5h6yo6jLcRVaD0qrORe5q3gMlP/cC2xe2JfsKM0/dA2q8koLAWcSn 3nUzm41I9TR+Q2q526ralA8a3ZXzqIOuM0jsVHNDjQGhasohE58+R3bgW1fk6T6PMD0MnMA7Den/B CqMeJOzqrjp4KHXi9jlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOiwi-00DLFT-Um; Mon, 28 Feb 2022 16:32:24 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOiwb-00DLCF-UY; Mon, 28 Feb 2022 16:32:23 +0000 Received: by mail-wm1-x331.google.com with SMTP id r10so6022359wma.2; Mon, 28 Feb 2022 08:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=FPcvzvX3MDs+LdnqfpdttONymmd5Rh4uve9/n2nXP25NoIaAzzIdxwwWDw74Eu2KAI s7CcDs1KSGhtfBpOFKS9DacY1Xo9WueMmBUvHWJ3xmIJP7JG2mKiuTOJkrLHQvGUsCoX 3MGqYVcHH8JyXnG9VDBJa2G3WdzVY2i8A6bUaV2YeoVt43Y7Gk0EGEkO8giTcRgXZEa1 d2sIdsyHQvoAkmkkfV/trDwqaYFMLsGxnRmU6/rgU/hUm/p4fIAuhDbtVGD4HTE9KA/T jV9dQimHsukOP9QwzcTcDUq5vajfFEy6WqvtxDGfLVRtKL6+dKj0XvnqoXXF/qh+qYUL DsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=72RP48QIWMKUHJ4jIPnijwCo7N6K0udqOMenti4H4sFiwdbx3jLTC0YbVQmHj3ak3U A2INljRyqNzIRVM0oRb1/G7dUKa3L3UbzXiVjV3/c8yzG2gbEXF1idLk6PEiqo43bJQw CJL9iDeQnoeR4Wz7RHHzZ5vAr6qw91bFham5GTdfY7H0LapPS+UuFPIoiY6XjdVx/DAm oe/z36I6aA9ka3v6/qolKydh8ov95N5IQ/alV4XECEg14MkJYR3oJPNX6R8Cm7wbGxfi dJriBZY6GxVTDA2yYzbssav+qAnS/AL413S5DRq68T5WGBukbZRr9m1mjJIHGP60pop+ +cXw== X-Gm-Message-State: AOAM532fFaZ6+iLwZVzhE/dx6UDx2yi9FDZ6IEGHba2kbQaz1UgtpxWE qFJbmObpfDirrDtqHFQtxDw= X-Google-Smtp-Source: ABdhPJy/RE308BOWztEfvBeC+M/1tepbLiYUtCH/0hJf9ShvYGyv+1u2o9DxOIVpfyR+PA44lN0jhw== X-Received: by 2002:a05:600c:418b:b0:380:e493:660a with SMTP id p11-20020a05600c418b00b00380e493660amr13779838wmh.189.1646065935336; Mon, 28 Feb 2022 08:32:15 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id u4-20020adfdb84000000b001e8d8ac5394sm11503518wri.110.2022.02.28.08.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 08:32:14 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, Nicolas Dufresne Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [RFC PATCH 2/8] media: Add P010 format Date: Mon, 28 Feb 2022 17:32:13 +0100 Message-ID: <5696849.MhkbZ0Pkbq@kista> In-Reply-To: <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> References: <20220227144926.3006585-1-jernej.skrabec@gmail.com> <20220227144926.3006585-3-jernej.skrabec@gmail.com> <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_083218_014417_B577A7B2 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 28. februar 2022 ob 13:48:53 CET je Nicolas Dufresne = napisal(a): > Le dimanche 27 f=E9vrier 2022 =E0 15:49 +0100, Jernej Skrabec a =E9crit : > > Add P010 format, which is commonly used for 10-bit videos. > = > There is a much more complete patch that was sent previously (with = documentation > and all): > = > https://patchwork.kernel.org/project/linux-rockchip/patch/ 20210618131526.566762-5-benjamin.gaignard@collabora.com/ Great, I'll take it for next revision. Although I'm not sure what "much mor= e = complete" means. Only additional thing is documentation. Best regards, Jernej > = > regards, > Nicolas > = > > = > > Signed-off-by: Jernej Skrabec > > --- > > drivers/media/v4l2-core/v4l2-common.c | 2 ++ > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/uapi/linux/videodev2.h | 1 + > > 3 files changed, 4 insertions(+) > > = > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2- core/v4l2-common.c > > index 1db0020e08c0..4ede36546e9c 100644 > > --- a/drivers/media/v4l2-core/v4l2-common.c > > +++ b/drivers/media/v4l2-core/v4l2-common.c > > @@ -275,6 +275,8 @@ const struct v4l2_format_info *v4l2_format_info(u32 = format) > > { .format =3D V4L2_PIX_FMT_YUV422P, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 3, .bpp =3D { 1, 1,= 1, 0 }, = .hdiv =3D 2, .vdiv =3D 1 }, > > { .format =3D V4L2_PIX_FMT_GREY, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 1, .bpp =3D { 1, 0,= 0, 0 }, = .hdiv =3D 1, .vdiv =3D 1 }, > > = > > + { .format =3D V4L2_PIX_FMT_P010, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > + > > /* Tiled YUV formats */ > > { .format =3D V4L2_PIX_FMT_NV12_4L4, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 1, 2,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > { .format =3D V4L2_PIX_FMT_P010_4L4, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2- core/v4l2-ioctl.c > > index 048f326c57b9..a8d999e23e5b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1295,6 +1295,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc = *fmt) > > case V4L2_PIX_FMT_M420: descr =3D "YUV 4:2:0 = (M420)"; break; > > case V4L2_PIX_FMT_NV12: descr =3D "Y/CbCr 4:2:0"; break; > > case V4L2_PIX_FMT_NV21: descr =3D "Y/CrCb 4:2:0"; break; > > + case V4L2_PIX_FMT_P010: descr =3D "10-bit Y/CbCr 4:2:0"; = break; > > case V4L2_PIX_FMT_NV16: descr =3D "Y/CbCr 4:2:2"; break; > > case V4L2_PIX_FMT_NV61: descr =3D "Y/CrCb 4:2:2"; break; > > case V4L2_PIX_FMT_NV24: descr =3D "Y/CbCr 4:4:4"; break; > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/ videodev2.h > > index 772dbadd1a24..211bc11a48cb 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -597,6 +597,7 @@ struct v4l2_pix_format { > > /* two planes -- one Y, one Cr + Cb interleaved */ > > #define V4L2_PIX_FMT_NV12 v4l2_fourcc('N', 'V', '1', '2') /* 12 Y/= CbCr = 4:2:0 */ > > #define V4L2_PIX_FMT_NV21 v4l2_fourcc('N', 'V', '2', '1') /* 12 Y/= CrCb = 4:2:0 */ > > +#define V4L2_PIX_FMT_P010 v4l2_fourcc('P', '0', '1', '0') /* 24 Y/= CbCr = 4:2:0 10-bit */ > > #define V4L2_PIX_FMT_NV16 v4l2_fourcc('N', 'V', '1', '6') /* 16 Y/= CbCr = 4:2:2 */ > > #define V4L2_PIX_FMT_NV61 v4l2_fourcc('N', 'V', '6', '1') /* 16 Y/= CrCb = 4:2:2 */ > > #define V4L2_PIX_FMT_NV24 v4l2_fourcc('N', 'V', '2', '4') /* 24 Y/= CbCr = 4:4:4 */ > = > = _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C4AFC433F5 for ; Mon, 28 Feb 2022 16:33:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8eByOfuGdFvlsXUvOecNZoQIFnbxstQpb01Ewl80hIE=; b=dQ3njfq3a/NzUt YswcZMF0lWr25j4Xx4eXs5MrxhdI9oVAPtP6UKtYdruoLB7o2MlVZrWAVY8TFKdmmHL0+URthOj0A KXDz+vXd8vjbHcC7JtquIg+ctxhleDmvUdy1UrCG33EIkyQk6kCkOg2H3QA3tuisYd8XxwP/reYkF XtIG2W7J+vNFsKu5KiZ4LXWwUsTxW75h7O1M9Hu5SdAudxoqtKfqh8V2SyLuYzSR+vLH0KYcGvBvn lQRBHYXM4yI5GgxSpGZ4s853TbKtk8RZfX4RfaqYJ6nuk/6ZAUOqA1bl0Dq8jFizOeFJbrIMa4lWL zqkgeikLDptuvdx04XBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOiwk-00DLFl-IV; Mon, 28 Feb 2022 16:32:26 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOiwb-00DLCF-UY; Mon, 28 Feb 2022 16:32:23 +0000 Received: by mail-wm1-x331.google.com with SMTP id r10so6022359wma.2; Mon, 28 Feb 2022 08:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=FPcvzvX3MDs+LdnqfpdttONymmd5Rh4uve9/n2nXP25NoIaAzzIdxwwWDw74Eu2KAI s7CcDs1KSGhtfBpOFKS9DacY1Xo9WueMmBUvHWJ3xmIJP7JG2mKiuTOJkrLHQvGUsCoX 3MGqYVcHH8JyXnG9VDBJa2G3WdzVY2i8A6bUaV2YeoVt43Y7Gk0EGEkO8giTcRgXZEa1 d2sIdsyHQvoAkmkkfV/trDwqaYFMLsGxnRmU6/rgU/hUm/p4fIAuhDbtVGD4HTE9KA/T jV9dQimHsukOP9QwzcTcDUq5vajfFEy6WqvtxDGfLVRtKL6+dKj0XvnqoXXF/qh+qYUL DsdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nspjxBI9tYzhw/PzFHLylmjKidTTydsrD7JFMGTC0VQ=; b=72RP48QIWMKUHJ4jIPnijwCo7N6K0udqOMenti4H4sFiwdbx3jLTC0YbVQmHj3ak3U A2INljRyqNzIRVM0oRb1/G7dUKa3L3UbzXiVjV3/c8yzG2gbEXF1idLk6PEiqo43bJQw CJL9iDeQnoeR4Wz7RHHzZ5vAr6qw91bFham5GTdfY7H0LapPS+UuFPIoiY6XjdVx/DAm oe/z36I6aA9ka3v6/qolKydh8ov95N5IQ/alV4XECEg14MkJYR3oJPNX6R8Cm7wbGxfi dJriBZY6GxVTDA2yYzbssav+qAnS/AL413S5DRq68T5WGBukbZRr9m1mjJIHGP60pop+ +cXw== X-Gm-Message-State: AOAM532fFaZ6+iLwZVzhE/dx6UDx2yi9FDZ6IEGHba2kbQaz1UgtpxWE qFJbmObpfDirrDtqHFQtxDw= X-Google-Smtp-Source: ABdhPJy/RE308BOWztEfvBeC+M/1tepbLiYUtCH/0hJf9ShvYGyv+1u2o9DxOIVpfyR+PA44lN0jhw== X-Received: by 2002:a05:600c:418b:b0:380:e493:660a with SMTP id p11-20020a05600c418b00b00380e493660amr13779838wmh.189.1646065935336; Mon, 28 Feb 2022 08:32:15 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id u4-20020adfdb84000000b001e8d8ac5394sm11503518wri.110.2022.02.28.08.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 08:32:14 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, Nicolas Dufresne Cc: mchehab@kernel.org, hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: Re: [RFC PATCH 2/8] media: Add P010 format Date: Mon, 28 Feb 2022 17:32:13 +0100 Message-ID: <5696849.MhkbZ0Pkbq@kista> In-Reply-To: <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> References: <20220227144926.3006585-1-jernej.skrabec@gmail.com> <20220227144926.3006585-3-jernej.skrabec@gmail.com> <1b2ce01fb04f29cca58d40bd81d9f4cc46dcebf8.camel@ndufresne.ca> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_083218_014417_B577A7B2 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne ponedeljek, 28. februar 2022 ob 13:48:53 CET je Nicolas Dufresne = napisal(a): > Le dimanche 27 f=E9vrier 2022 =E0 15:49 +0100, Jernej Skrabec a =E9crit : > > Add P010 format, which is commonly used for 10-bit videos. > = > There is a much more complete patch that was sent previously (with = documentation > and all): > = > https://patchwork.kernel.org/project/linux-rockchip/patch/ 20210618131526.566762-5-benjamin.gaignard@collabora.com/ Great, I'll take it for next revision. Although I'm not sure what "much mor= e = complete" means. Only additional thing is documentation. Best regards, Jernej > = > regards, > Nicolas > = > > = > > Signed-off-by: Jernej Skrabec > > --- > > drivers/media/v4l2-core/v4l2-common.c | 2 ++ > > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > > include/uapi/linux/videodev2.h | 1 + > > 3 files changed, 4 insertions(+) > > = > > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2- core/v4l2-common.c > > index 1db0020e08c0..4ede36546e9c 100644 > > --- a/drivers/media/v4l2-core/v4l2-common.c > > +++ b/drivers/media/v4l2-core/v4l2-common.c > > @@ -275,6 +275,8 @@ const struct v4l2_format_info *v4l2_format_info(u32 = format) > > { .format =3D V4L2_PIX_FMT_YUV422P, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 3, .bpp =3D { 1, 1,= 1, 0 }, = .hdiv =3D 2, .vdiv =3D 1 }, > > { .format =3D V4L2_PIX_FMT_GREY, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 1, .bpp =3D { 1, 0,= 0, 0 }, = .hdiv =3D 1, .vdiv =3D 1 }, > > = > > + { .format =3D V4L2_PIX_FMT_P010, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > + > > /* Tiled YUV formats */ > > { .format =3D V4L2_PIX_FMT_NV12_4L4, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 1, 2,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > { .format =3D V4L2_PIX_FMT_P010_4L4, .pixel_enc =3D = V4L2_PIXEL_ENC_YUV, .mem_planes =3D 1, .comp_planes =3D 2, .bpp =3D { 2, 4,= 0, 0 }, = .hdiv =3D 2, .vdiv =3D 2 }, > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2- core/v4l2-ioctl.c > > index 048f326c57b9..a8d999e23e5b 100644 > > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > > @@ -1295,6 +1295,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc = *fmt) > > case V4L2_PIX_FMT_M420: descr =3D "YUV 4:2:0 = (M420)"; break; > > case V4L2_PIX_FMT_NV12: descr =3D "Y/CbCr 4:2:0"; break; > > case V4L2_PIX_FMT_NV21: descr =3D "Y/CrCb 4:2:0"; break; > > + case V4L2_PIX_FMT_P010: descr =3D "10-bit Y/CbCr 4:2:0"; = break; > > case V4L2_PIX_FMT_NV16: descr =3D "Y/CbCr 4:2:2"; break; > > case V4L2_PIX_FMT_NV61: descr =3D "Y/CrCb 4:2:2"; break; > > case V4L2_PIX_FMT_NV24: descr =3D "Y/CbCr 4:4:4"; break; > > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/ videodev2.h > > index 772dbadd1a24..211bc11a48cb 100644 > > --- a/include/uapi/linux/videodev2.h > > +++ b/include/uapi/linux/videodev2.h > > @@ -597,6 +597,7 @@ struct v4l2_pix_format { > > /* two planes -- one Y, one Cr + Cb interleaved */ > > #define V4L2_PIX_FMT_NV12 v4l2_fourcc('N', 'V', '1', '2') /* 12 Y/= CbCr = 4:2:0 */ > > #define V4L2_PIX_FMT_NV21 v4l2_fourcc('N', 'V', '2', '1') /* 12 Y/= CrCb = 4:2:0 */ > > +#define V4L2_PIX_FMT_P010 v4l2_fourcc('P', '0', '1', '0') /* 24 Y/= CbCr = 4:2:0 10-bit */ > > #define V4L2_PIX_FMT_NV16 v4l2_fourcc('N', 'V', '1', '6') /* 16 Y/= CbCr = 4:2:2 */ > > #define V4L2_PIX_FMT_NV61 v4l2_fourcc('N', 'V', '6', '1') /* 16 Y/= CrCb = 4:2:2 */ > > #define V4L2_PIX_FMT_NV24 v4l2_fourcc('N', 'V', '2', '4') /* 24 Y/= CbCr = 4:4:4 */ > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel