From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Dai Subject: Re: [PATCH v1] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed Date: Wed, 13 Jan 2016 10:17:34 -0800 Message-ID: <569694BE.6050702@intel.com> References: <1452113637-12981-1-git-send-email-yu.dai@intel.com> <1452640652-24404-1-git-send-email-yu.dai@intel.com> <5696945A.7050002@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A6AF6E981 for ; Wed, 13 Jan 2016 10:21:15 -0800 (PST) In-Reply-To: <5696945A.7050002@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMS8xMy8yMDE2IDEwOjE1IEFNLCBEYXZlIEdvcmRvbiB3cm90ZToKPiBPbiAxMi8wMS8x NiAyMzoxNywgeXUuZGFpQGludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IEFsZXggRGFpIDx5dS5k YWlAaW50ZWwuY29tPgo+ID4KPiA+IER1cmluZyBkcml2ZXIgdW5sb2FkaW5nLCB0aGUgZ3VjX2Ns aWVudCBjcmVhdGVkIGZvciBjb21tYW5kIHN1Ym1pc3Npb24KPiA+IG5lZWRzIHRvIGJlIHJlbGVh c2VkIHRvIGF2b2lkIG1lbW9yeSBsZWFrLgo+ID4KPiA+IFRoZSBzdHJ1Y3RfbXV0ZXggbmVlZHMg dG8gYmUgaGVsZCBiZWZvcmUgdGVhcmluZyBkb3duIEd1Qy4KPiA+Cj4gPiB2MTogTW92ZSBpOTE1 X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUgb3V0IG9mIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaSBh bmQKPiA+ICAgICAgdGFrZSBzdHJ1Y3RfbXV0ZXggbG9jayBiZWZvcmUgcmVsZWFzZSBHdUMgY2xp ZW50LiAoRGF2ZSBHb3Jkb24pCj4KPiBZb3UgZG9uJ3Qgc2VlbSB0byBoYXZlIGltcGxlbWVudGVk IGFsbCB0aGUgcG9pbnRzIEkgbWVudGlvbmVkPyBJIHRoaW5rCj4geW91IHdhbnQ6Cj4KPiBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmM6Cj4gQEAgLTQ0NSw2ICs0NDUsNyBA QCBpbnQgaW50ZWxfZ3VjX3Vjb2RlX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPgo+ICAg ICAgICAgICBkaXJlY3RfaW50ZXJydXB0c190b19ob3N0KGRldl9wcml2KTsKPiAgICAgICAgICAg aTkxNV9ndWNfc3VibWlzc2lvbl9kaXNhYmxlKGRldik7Cj4gKyAgICAgICBpOTE1X2d1Y19zdWJt aXNzaW9uX2ZpbmkoZGV2KTsKPgo+IE9wdGlvbmFsLCBidXQgY2xlYW5lci4gV2UgY2FsbGVkIGk5 MTVfZ3VjX3N1Ym1pc3Npb25faW5pdCgpIGVhcmxpZXIgaW4KPiB0aGlzIGZ1bmN0aW9uLCBzbyB3 ZSBzaG91bGQgY2FsbCBpOTE1X2d1Y19zdWJtaXNzaW9uX2ZpbmkoKSBpbiB0aGUKPiBmYWlsdXJl IHBhdGguIFRoYXQgd2F5LCB3ZSBlaXRoZXIgc3VjY2VlZCwgb3IgbGVhdmUgdGhlIHN5c3RlbSBz dGF0ZQo+IHVuY2hhbmdlZCwgTk9UIGxlYXZpbmcgZXh0cmEgb2JqZWN0cyBhbGxvY2F0ZWQuCj4K PiAgICAgICAgICAgcmV0dXJuIGVycjsKPiAgICB9CgpJIGRvbid0IHdhbnQgdGhpcyBiZWNhdXNl IHN0cnVjdF9tdXRleCBpcyBoZWxkIGJ5IGNhbGxlciBhbHJlYWR5IHdoaWxlIAp0aGUgZmluaSgp IHdpbGwgYWNxdWlyZSBpdCB0b28uCj4gQEAgLTU2MSwxMCArNTYyLDEyIEBAIHN0YXRpYyB2b2lk IGd1Y19md19mZXRjaChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+IHN0cnVjdCBpbnRlbF9ndWNf ZncgKmd1Y19mdykKPiAgICAJRFJNX0VSUk9SKCJGYWlsZWQgdG8gZmV0Y2ggR3VDIGZpcm13YXJl IGZyb20gJXMgKGVycm9yICVkKVxuIiwKPiAgICAJCSAgZ3VjX2Z3LT5ndWNfZndfcGF0aCwgZXJy KTsKPgo+ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgIAlvYmogPSBndWNf ZnctPmd1Y19md19vYmo7Cj4gICAgCWlmIChvYmopCj4gICAgCQlkcm1fZ2VtX29iamVjdF91bnJl ZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiAgICAJZ3VjX2Z3LT5ndWNfZndfb2JqID0gTlVMTDsKPiAr CW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+Cj4gVGhpcyBpcyB0aGUgbG9ja2lu ZyB0aGF0IG5lZWRzIHRvIGJlIGFkZGVkIHRvIHRoZSBmYWlsdXJlIHBhdGguCj4gVGhpcyBpcyBy ZXF1aXJlZCAqaW4gYWRkaXRpb24gdG8qIHRoZSBsb2NraW5nIHJlb3JnYW5pc2F0aW9uIGJlbG93 LgoKSSBtaXNzZWQgdGhpcyBwYXJ0Lgo+ID4gU2lnbmVkLW9mZi1ieTogQWxleCBEYWkgPHl1LmRh aUBpbnRlbC5jb20+Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2d1Y19sb2FkZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIu Ywo+ID4gaW5kZXggZDIwNzg4Zi4uNzBmYThmNSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjX2xvYWRlci5jCj4gPiBAQCAtNjMxLDEwICs2MzEsMTEgQEAgdm9pZCBpbnRl bF9ndWNfdWNvZGVfZmluaShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gICAJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ICAgCXN0cnVj dCBpbnRlbF9ndWNfZncgKmd1Y19mdyA9ICZkZXZfcHJpdi0+Z3VjLmd1Y19mdzsKPiA+Cj4gPiAr CW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiA+ICAgCWRpcmVjdF9pbnRlcnJ1cHRz X3RvX2hvc3QoZGV2X3ByaXYpOwo+ID4gKwlpOTE1X2d1Y19zdWJtaXNzaW9uX2Rpc2FibGUoZGV2 KTsKPiA+ICAgCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXYpOwo+ID4KPiA+IC0JbXV0ZXhf bG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikK PiA+ICAgCQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmZ3VjX2Z3LT5ndWNfZndfb2JqLT5i YXNlKTsKPiA+ICAgCWd1Y19mdy0+Z3VjX2Z3X29iaiA9IE5VTEw7Cj4KPiBUaGlzIGJpdCBpcyBm aW5lLCBidXQgaW5jb21wbGV0ZSB3aXRob3V0IHRoZSBvdGhlciBjaGFuZ2VzIGFib3ZlLgo+Cj4g LkRhdmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=