From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed Date: Wed, 13 Jan 2016 19:11:04 +0000 Message-ID: <5696A148.4070309@intel.com> References: <1452113637-12981-1-git-send-email-yu.dai@intel.com> <1452711710-4505-1-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 55F496E993 for ; Wed, 13 Jan 2016 11:11:06 -0800 (PST) In-Reply-To: <1452711710-4505-1-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMTMvMDEvMTYgMTk6MDEsIHl1LmRhaUBpbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogQWxleCBE YWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4KPiBEdXJpbmcgZHJpdmVyIHVubG9hZGluZywgdGhlIGd1 Y19jbGllbnQgY3JlYXRlZCBmb3IgY29tbWFuZCBzdWJtaXNzaW9uCj4gbmVlZHMgdG8gYmUgcmVs ZWFzZWQgdG8gYXZvaWQgbWVtb3J5IGxlYWsuCj4KPiBUaGUgc3RydWN0X211dGV4IG5lZWRzIHRv IGJlIGhlbGQgYmVmb3JlIHRlYXJpbmcgZG93biBHdUMuCj4KPiB2MTogTW92ZSBpOTE1X2d1Y19z dWJtaXNzaW9uX2Rpc2FibGUgb3V0IG9mIGk5MTVfZ3VjX3N1Ym1pc3Npb25fZmluaSBhbmQKPiAg ICAgIHRha2Ugc3RydWN0X211dGV4IGxvY2sgYmVmb3JlIHJlbGVhc2UgR3VDIGNsaWVudC4gKERh dmUgR29yZG9uKQo+IHYyOiBBZGQgdGhlIGxvY2tpbmcgZm9yIGZhaWx1cmUgY2FzZSBpbiBndWNf ZndfZmV0Y2guIChEYXZlIEdvcmRvbikKPiAgICAgIEFkZCBpOTE1X2d1Y19zdWJtaXNzaW9uX2Zp bmkgZm9yIGZhaWx1cmUgY2FzZSBpbiBpbnRlbF9ndWNfdWNvZGVfbG9hZC4KPgo+IFNpZ25lZC1v ZmYtYnk6IEFsZXggRGFpIDx5dS5kYWlAaW50ZWwuY29tPgoKTEdUTS4KClJldmlld2VkLWJ5OiBE YXZlIEdvcmRvbiA8ZGF2aWQucy5nb3Jkb25AaW50ZWwuY29tPgoKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBpbmRleCBkMjA3ODhmLi4zYWNjZDkxIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IEBAIC00NDUsNiArNDQ1LDcg QEAgZmFpbDoKPgo+ICAgCWRpcmVjdF9pbnRlcnJ1cHRzX3RvX2hvc3QoZGV2X3ByaXYpOwo+ICAg CWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+ICsJaTkxNV9ndWNfc3VibWlzc2lv bl9maW5pKGRldik7Cj4KPiAgIAlyZXR1cm4gZXJyOwo+ICAgfQo+IEBAIC01NjEsMTAgKzU2Miwx MiBAQCBmYWlsOgo+ICAgCURSTV9FUlJPUigiRmFpbGVkIHRvIGZldGNoIEd1QyBmaXJtd2FyZSBm cm9tICVzIChlcnJvciAlZClcbiIsCj4gICAJCSAgZ3VjX2Z3LT5ndWNfZndfcGF0aCwgZXJyKTsK Pgo+ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICAgCW9iaiA9IGd1Y19mdy0+ Z3VjX2Z3X29iajsKPiAgIAlpZiAob2JqKQo+ICAgCQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5j ZSgmb2JqLT5iYXNlKTsKPiAgIAlndWNfZnctPmd1Y19md19vYmogPSBOVUxMOwo+ICsJbXV0ZXhf dW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4KPiAgIAlyZWxlYXNlX2Zpcm13YXJlKGZ3KTsJ CS8qIE9LIGV2ZW4gaWYgZncgaXMgTlVMTCAqLwo+ICAgCWd1Y19mdy0+Z3VjX2Z3X2ZldGNoX3N0 YXR1cyA9IEdVQ19GSVJNV0FSRV9GQUlMOwo+IEBAIC02MzEsMTAgKzYzNCwxMSBAQCB2b2lkIGlu dGVsX2d1Y191Y29kZV9maW5pKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gICAJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgIAlzdHJ1Y3Qg aW50ZWxfZ3VjX2Z3ICpndWNfZncgPSAmZGV2X3ByaXYtPmd1Yy5ndWNfZnc7Cj4KPiArCW11dGV4 X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgIAlkaXJlY3RfaW50ZXJydXB0c190b19ob3N0 KGRldl9wcml2KTsKPiArCWk5MTVfZ3VjX3N1Ym1pc3Npb25fZGlzYWJsZShkZXYpOwo+ICAgCWk5 MTVfZ3VjX3N1Ym1pc3Npb25fZmluaShkZXYpOwo+Cj4gLQltdXRleF9sb2NrKCZkZXYtPnN0cnVj dF9tdXRleCk7Cj4gICAJaWYgKGd1Y19mdy0+Z3VjX2Z3X29iaikKPiAgIAkJZHJtX2dlbV9vYmpl Y3RfdW5yZWZlcmVuY2UoJmd1Y19mdy0+Z3VjX2Z3X29iai0+YmFzZSk7Cj4gICAJZ3VjX2Z3LT5n dWNfZndfb2JqID0gTlVMTDsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK