From: "Jan Beulich" <JBeulich@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise
Date: Thu, 14 Jan 2016 02:07:35 -0700 [thread overview]
Message-ID: <5697736702000078000C6976@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5696881D.6060600@citrix.com>
>>> On 13.01.16 at 18:23, <roger.pau@citrix.com> wrote:
> El 13/01/16 a les 17.29, Jan Beulich ha escrit:
>>>>> On 13.01.16 at 13:32, <roger.pau@citrix.com> wrote:
>>> The BSP will be marked as initialised after hvm_load_cpu_ctxt has loaded the
>>> initial state, which is called from the toolstack during domain creation.
>>
>> But the comment that you remove says explicitly that this isn't a
>> requirement.
>
> Previous to my HVMlite series that was true, and HVM guests were started
> without setting any explicit CPU state (in fact we placed that horrible
> jmp at 0x0, because the IP was by default set to 0x0). This is no longer
> true, and now HVM guests require that a proper CPU context is loaded
> before starting. I believe this is better, and this change helps enforce
> this policy.
Well, that's fine, but the patch description then needs to reflect
this.
Jan
next prev parent reply other threads:[~2016-01-14 9:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 12:32 [PATCH 0/5] HVMlite: minor fixes and Dom0 preparatory patches Roger Pau Monne
2016-01-13 12:32 ` [PATCH 1/5] xen/elfnotes: initialise phys_entry to UNSET_ADDR32 Roger Pau Monne
2016-01-13 12:46 ` Jan Beulich
2016-01-13 12:52 ` Roger Pau Monné
2016-01-13 13:02 ` Jan Beulich
2016-01-13 13:05 ` Andrew Cooper
2016-01-13 13:08 ` Jan Beulich
2016-01-13 13:10 ` Andrew Cooper
2016-01-13 12:32 ` [PATCH 2/5] libelf: rewrite symtab/strtab loading for Dom0 Roger Pau Monne
2016-01-13 12:32 ` [PATCH 3/5] x86/hvm: don't set the BSP as initialised in hvm_vcpu_initialise Roger Pau Monne
2016-01-13 16:29 ` Jan Beulich
2016-01-13 17:23 ` Roger Pau Monné
2016-01-14 9:07 ` Jan Beulich [this message]
2016-01-13 12:32 ` [PATCH 4/5] x86/PV: remove the emulated PIT Roger Pau Monne
2016-01-13 16:36 ` Jan Beulich
2016-01-14 8:25 ` Roger Pau Monné
2016-01-14 9:11 ` Jan Beulich
2016-01-14 10:59 ` Roger Pau Monné
2016-01-14 12:38 ` Jan Beulich
2016-01-14 14:03 ` Roger Pau Monné
2016-01-14 14:36 ` Jan Beulich
2016-01-13 12:32 ` [PATCH 5/5] x86/HVM: don't setup an intercept handler for IO port 0xcf8 unconditionally Roger Pau Monne
2016-01-13 16:38 ` Jan Beulich
2016-01-13 16:45 ` Andrew Cooper
2016-01-13 16:48 ` Paul Durrant
2016-01-14 8:35 ` Roger Pau Monné
2016-01-14 9:12 ` Jan Beulich
2016-01-14 10:50 ` Andrew Cooper
2016-01-14 11:00 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5697736702000078000C6976@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.