From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions Date: Fri, 15 Jan 2016 15:50:27 +0100 Message-ID: <56990733.7000506@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <567EDED5.4040201@users.sourceforge.net> <5697D865.5010507@users.sourceforge.net> <5697DE31.9040309@users.sourceforge.net> <20160115132014.GC30615@leon.nu> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160115132014.GC30615-2ukJVAZIZ/Y@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky Cc: Devesh Sharma , Doug Ledford , Hal Rosenstock , Mitesh Ahuja , Sean Hefty , Selvin Xavier , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Julia Lawall List-Id: linux-rdma@vger.kernel.org >> The variable "status" will be set to an appropriate value a bit later. >> Thus omit the explicit initialisation at the beginning. > > What did you try to achieve by this patch? I would like to optimise the affected source files a bit. Would you like to clarify any measurable effects around the implementation detail when various variables will only be initialised immediately before they will be read again? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754027AbcAOOu7 (ORCPT ); Fri, 15 Jan 2016 09:50:59 -0500 Received: from mout.web.de ([212.227.15.14]:50244 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421AbcAOOu4 (ORCPT ); Fri, 15 Jan 2016 09:50:56 -0500 Subject: Re: InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions To: linux-rdma@vger.kernel.org, Leon Romanovsky References: <566ABCD9.1060404@users.sourceforge.net> <567EDED5.4040201@users.sourceforge.net> <5697D865.5010507@users.sourceforge.net> <5697DE31.9040309@users.sourceforge.net> <20160115132014.GC30615@leon.nu> Cc: Devesh Sharma , Doug Ledford , Hal Rosenstock , Mitesh Ahuja , Sean Hefty , Selvin Xavier , LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <56990733.7000506@users.sourceforge.net> Date: Fri, 15 Jan 2016 15:50:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160115132014.GC30615@leon.nu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:380AFWkAOEuUXzJ5WGhefRxBDfpgDqNNggzAv3IoSHgbkXUxmVE Jrl6LGuvIqxinRpsfR4Dp2wt/K1gMwz2Ocj+AHFLPQ7u7ilHYj+JIhOJFCREtUiZZ2jdzS+ 6d3hfuvzEb/MXDYaoSU6v1jwOEU9FY+VSpMArh+4OktVNWUxmSBs2fRg33qsHhS4C7pSzP4 KDmKt/IATA3cFmSOtKh5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:xKUxmdGh4B8=:CZn21pRYd5NIoNFHaaOq+C EWqZ3B3TBWTRg0rvuiQYWKCpDn2vLaEkb4AsLzot/rLanf9Xg6yfNqFMD6XwFR3B/PRkWCqdY 0dL3DGC2NxGZ6O+Fa6MLq59oiSnTHVD017Dum+19lWjAdnaoa27UPmZcIejAz/+0g6gVC4PR5 Pl2YTPAmc6ljGLRhA1xONoVzrNVx7/fPhP1ufIp/BWcI54iM7BQ1as+uIUSm/fI2lasu9WzN2 oomx2L9PWSRBydoZT0dj4+AqFBg/JXMb68drA+rYXqz1pcG64U103RP19xjRWmv2TOHlcn1UF roceLCjhY8m7xcXAOWAhI0iRLT1gTJRaJMrI+G31MGnMoHrgBQN6YyIqp03WpmJlNsrW4jMuh do/0o+Uu2sURpgEvnPgnLKIXAQbggJAujKNGNwyhcit0osRJxBkfcDWjtYzDXYT9oYdg84pBw 5u2x+fNgy4J4ph2KirTrP4766jWToVHn/y0dm5YZGIYrgPQEoFW1+JfMjO5xmp8Sla+hBXGsl BTChlvhaA/fciqTljlXm1iIq7xr+ojF5BN22CjycXY6gT1izf2+10ej1UIxk4mxufr8KFpg7k mu0z+vBrCfLY6mPlgQCwN1PN4km+GEqawW1EyCOZjye9aepoT/ZOXZ0YUFF2sR0ybehLogzLJ F9+gp4kj9LPjuD3mz5Tm64ViRbzluwweuo28tjFNsnK/CNay/HgZP9wqDMBJ63LFw84PxH4Ug 3xwHXp+B7C37FEGZdbDWIX2QWgka4wC5hyJwFa7YqmE1VDgXqH5LXQMfbSLMsR9oCIcunbgAB A52ptDy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> The variable "status" will be set to an appropriate value a bit later. >> Thus omit the explicit initialisation at the beginning. > > What did you try to achieve by this patch? I would like to optimise the affected source files a bit. Would you like to clarify any measurable effects around the implementation detail when various variables will only be initialised immediately before they will be read again? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 15 Jan 2016 14:50:27 +0000 Subject: Re: InfiniBand-ocrdma: Delete unnecessary variable initialisations in 11 functions Message-Id: <56990733.7000506@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <567EDED5.4040201@users.sourceforge.net> <5697D865.5010507@users.sourceforge.net> <5697DE31.9040309@users.sourceforge.net> <20160115132014.GC30615@leon.nu> In-Reply-To: <20160115132014.GC30615-2ukJVAZIZ/Y@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky Cc: Devesh Sharma , Doug Ledford , Hal Rosenstock , Mitesh Ahuja , Sean Hefty , Selvin Xavier , LKML , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Julia Lawall >> The variable "status" will be set to an appropriate value a bit later. >> Thus omit the explicit initialisation at the beginning. > > What did you try to achieve by this patch? I would like to optimise the affected source files a bit. Would you like to clarify any measurable effects around the implementation detail when various variables will only be initialised immediately before they will be read again? Regards, Markus