From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33211)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aK8uN-0002qC-F1
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:15:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aK8uK-0004Uz-6U
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:15:35 -0500
Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:35304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1aK8uK-0004Ut-2V
	for qemu-devel@nongnu.org; Fri, 15 Jan 2016 13:15:32 -0500
Received: by mail-qk0-x22c.google.com with SMTP id y67so56641598qkc.2
	for <qemu-devel@nongnu.org>; Fri, 15 Jan 2016 10:15:32 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1452093672-75002-1-git-send-email-webberapple@gmail.com>
	<CAFEAcA92g2feKUvsejKzWkRL4waO_hxA_k73VxJFir3Yy_s0FA@mail.gmail.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <56993740.2090801@twiddle.net>
Date: Fri, 15 Jan 2016 10:15:28 -0800
MIME-Version: 1.0
In-Reply-To: <CAFEAcA92g2feKUvsejKzWkRL4waO_hxA_k73VxJFir3Yy_s0FA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] util: Fix QEMU_LD_PREFIX endless loop
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "Wei-Bo, Chen" <webberapple@gmail.com>

On 01/15/2016 09:53 AM, Peter Maydell wrote:
>> @@ -58,7 +58,7 @@ static struct pathelem *new_entry(const char *root,
>>  #if defined(DT_DIR) && defined(DT_UNKNOWN) && defined(DT_LNK)
>>  # define dirent_type(dirent) ((dirent)->d_type)
>>  # define is_dir_maybe(type) \
>> -    ((type) == DT_DIR || (type) == DT_UNKNOWN || (type) == DT_LNK)
>> +    ((type) == DT_DIR || (type) == DT_UNKNOWN)
>>  #else
>>  # define dirent_type(dirent) (1)
>>  # define is_dir_maybe(type)  (type)
>> --
>> 2.5.0
> 
> This change would be essentially reverting commit 338d80dd353c50b63,
> which specifically added support for symbolic links in the directory
> structure. So if we applied it we'd be regressing on the problem
> that that change was meant to fix.
> 
> Richard, git says that commit was one of yours :-)

Because gcc and qemu have different names for their sysroot trees, and in my
disks, gcc is the "master".  So I normally have

   .../qemu/run/qemu-alpha -> .../gcc/run-cross/alphaev67-linux/sys-root
   .../qemu/run/qemu-arm -> .../gcc/run-cross/arm-linux-gnueabi/sys-root
   .../qemu/run/qemu-sparc -> .../gcc/run-cross/sparc64-linux/sys-root
   .../qemu/run/qemu-sparc64 -> .../gcc/run-cross/sparc64-linux/sys-root

The DT_LNK is required for traversing even the first link.


r~