From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v6 1/5] build: Env var to enable expert config options Date: Fri, 15 Jan 2016 10:20:46 -0700 Message-ID: <5699387E02000078000C784B@prv-mh.provo.novell.com> References: <1452877299-59267-1-git-send-email-jonathan.creekmore@gmail.com> <1452877299-59267-2-git-send-email-jonathan.creekmore@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aK83N-0007Um-Hd for xen-devel@lists.xenproject.org; Fri, 15 Jan 2016 17:20:49 +0000 In-Reply-To: <1452877299-59267-2-git-send-email-jonathan.creekmore@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jonathan Creekmore Cc: xen-devel@lists.xenproject.org, Keir Fraser , Ian Jackson , Ian Campbell , Tim Deegan List-Id: xen-devel@lists.xenproject.org >>> On 15.01.16 at 18:01, wrote: > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -11,6 +11,7 @@ export XEN_DOMAIN ?= $(shell ([ -x /bin/dnsdomainname ] && /bin/dnsdomainname) | > export XEN_BUILD_DATE ?= $(shell LC_ALL=C date) > export XEN_BUILD_TIME ?= $(shell LC_ALL=C date +%T) > export XEN_BUILD_HOST ?= $(shell hostname) > +export XEN_CONFIG_EXPERT ?= n This, I'm afraid, invalidates what I've said in another reply on the earlier thread a few minutes ago. What Makefile.kconfig gets to see must be consistent for FORCE to not be added to include/config/auto.conf's dependencies by auto.conf.cmd. Or in other words - did you check (in conjunction with that other patch fixing incremental rebuilds) whether incremental rebuilds aren't again becoming full rebuilds because of this when there's no XEN_CONFIG_EXPERT in the environment? Jan