From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/gntdev: Don't allocate struct gntdev_copy_batch on stack Date: Fri, 15 Jan 2016 19:50:17 +0000 Message-ID: <56994D79.1010702__147.530544973229$1452887504$gmane$org@citrix.com> References: <1452887025-27285-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aKAO5-0007SH-G3 for xen-devel@lists.xenproject.org; Fri, 15 Jan 2016 19:50:22 +0000 In-Reply-To: <1452887025-27285-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , konrad.wilk@oracle.com, david.vrabel@citrix.com Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gMTUvMDEvMTYgMTk6NDMsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToKPiBzdHJ1Y3QgZ250ZGV2 X2NvcHlfYmF0Y2ggaXMgb3ZlciAxMzAwIGJ5dGVzIGluIHNpemUsIHdlIHNob3VsZG4ndAo+IHB1 dCBpdCBvbiBzdGFjay4KPgo+IFNvbWUgY29tcGlsZXJzIChlLmcuIDUuMi4xKSBjb21wbGFpbjoK PiAgZHJpdmVycy94ZW4vZ250ZGV2LmM6IEluIGZ1bmN0aW9uIOKAmGdudGRldl9pb2N0bF9ncmFu dF9jb3B5LmlzcmEuNeKAmToKPiAgZHJpdmVycy94ZW4vZ250ZGV2LmM6OTQ5OjE6IHdhcm5pbmc6 IHRoZSBmcmFtZSBzaXplIG9mIDE0MTYgYnl0ZXMKPiAgIGlzIGxhcmdlciB0aGFuIDEwMjQgYnl0 ZXMgWy1XZnJhbWUtbGFyZ2VyLXRoYW49XQo+Cj4gU2lnbmVkLW9mZi1ieTogQm9yaXMgT3N0cm92 c2t5IDxib3Jpcy5vc3Ryb3Zza3lAb3JhY2xlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy94ZW4vZ250 ZGV2LmMgfCAyMCArKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9n bnRkZXYuYyBiL2RyaXZlcnMveGVuL2dudGRldi5jCj4gaW5kZXggZGM0OTUzOC4uNDNhMmMxYyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3hlbi9nbnRkZXYuYwo+ICsrKyBiL2RyaXZlcnMveGVuL2du dGRldi5jCj4gQEAgLTkxNSwxNSArOTE1LDE5IEBAIHN0YXRpYyBpbnQgZ250ZGV2X2dyYW50X2Nv cHlfc2VnKHN0cnVjdCBnbnRkZXZfY29weV9iYXRjaCAqYmF0Y2gsCj4gIHN0YXRpYyBsb25nIGdu dGRldl9pb2N0bF9ncmFudF9jb3B5KHN0cnVjdCBnbnRkZXZfcHJpdiAqcHJpdiwgdm9pZCBfX3Vz ZXIgKnUpCj4gIHsKPiAgCXN0cnVjdCBpb2N0bF9nbnRkZXZfZ3JhbnRfY29weSBjb3B5Owo+IC0J c3RydWN0IGdudGRldl9jb3B5X2JhdGNoIGJhdGNoOwo+ICsJc3RydWN0IGdudGRldl9jb3B5X2Jh dGNoICpiYXRjaDsKPiAgCXVuc2lnbmVkIGludCBpOwo+ICAJaW50IHJldCA9IDA7Cj4gIAo+ICAJ aWYgKGNvcHlfZnJvbV91c2VyKCZjb3B5LCB1LCBzaXplb2YoY29weSkpKQo+ICAJCXJldHVybiAt RUZBVUxUOwo+ICAKPiAtCWJhdGNoLm5yX29wcyA9IDA7Cj4gLQliYXRjaC5ucl9wYWdlcyA9IDA7 Cj4gKwliYXRjaCA9IGttYWxsb2Moc2l6ZW9mKCpiYXRjaCksIEdGUF9LRVJORUwpOwo+ICsJaWYg KCFiYXRjaCkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwliYXRjaC0+bnJfb3BzID0gMDsK PiArCWJhdGNoLT5ucl9wYWdlcyA9IDA7Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IGNvcHkuY291 bnQ7IGkrKykgewo+ICAJCXN0cnVjdCBnbnRkZXZfZ3JhbnRfY29weV9zZWdtZW50IHNlZzsKPiBA QCAtOTMzLDE4ICs5MzcsMjAgQEAgc3RhdGljIGxvbmcgZ250ZGV2X2lvY3RsX2dyYW50X2NvcHko c3RydWN0IGdudGRldl9wcml2ICpwcml2LCB2b2lkIF9fdXNlciAqdSkKPiAgCQkJZ290byBvdXQ7 Cj4gIAkJfQo+ICAKPiAtCQlyZXQgPSBnbnRkZXZfZ3JhbnRfY29weV9zZWcoJmJhdGNoLCAmc2Vn LCAmY29weS5zZWdtZW50c1tpXS5zdGF0dXMpOwo+ICsJCXJldCA9IGdudGRldl9ncmFudF9jb3B5 X3NlZyhiYXRjaCwgJnNlZywKPiArCQkJJmNvcHkuc2VnbWVudHNbaV0uc3RhdHVzKTsKPiAgCQlp ZiAocmV0IDwgMCkKPiAgCQkJZ290byBvdXQ7Cj4gIAo+ICAJCWNvbmRfcmVzY2hlZCgpOwo+ICAJ fQo+IC0JaWYgKGJhdGNoLm5yX29wcykKPiAtCQlyZXQgPSBnbnRkZXZfY29weSgmYmF0Y2gpOwo+ ICsJaWYgKGJhdGNoLT5ucl9vcHMpCj4gKwkJcmV0ID0gZ250ZGV2X2NvcHkoYmF0Y2gpOwoKWW91 IHByZXN1bWFibHkgd2FudCBhIGtmcmVlKCkgaGVyZT8KCj4gIAlyZXR1cm4gcmV0Owo+ICAKPiAg ICBvdXQ6Cj4gLQlnbnRkZXZfcHV0X3BhZ2VzKCZiYXRjaCk7Cj4gKwlnbnRkZXZfcHV0X3BhZ2Vz KGJhdGNoKTsKPiArCWtmcmVlKGJhdGNoKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9yZy94 ZW4tZGV2ZWwK