From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v6 1/5] build: Env var to enable expert
 config options
Date: Mon, 18 Jan 2016 00:46:54 -0700
Message-ID: <569CA67E02000078000C7C49@prv-mh.provo.novell.com>
References: <1452877299-59267-1-git-send-email-jonathan.creekmore@gmail.com>
	<1452877299-59267-2-git-send-email-jonathan.creekmore@gmail.com>
	<5699387E02000078000C784B@prv-mh.provo.novell.com>
	<AB25544A-186D-4F96-8BD3-6C9D2F06D950@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1aL4Wl-0006G8-Et
	for xen-devel@lists.xenproject.org; Mon, 18 Jan 2016 07:47:03 +0000
In-Reply-To: <AB25544A-186D-4F96-8BD3-6C9D2F06D950@gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 15.01.16 at 18:33, <jonathan.creekmore@gmail.com> wrote:

>> On Jan 15, 2016, at 11:20 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> 
>>>>> On 15.01.16 at 18:01, <jonathan.creekmore@gmail.com> wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -11,6 +11,7 @@ export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && 
> /bin/dnsdomainname) |
>>> export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
>>> export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
>>> export XEN_BUILD_HOST	?= $(shell hostname)
>>> +export XEN_CONFIG_EXPERT ?= n
>> 
>> This, I'm afraid, invalidates what I've said in another reply on
>> the earlier thread a few minutes ago. What Makefile.kconfig
>> gets to see must be consistent for FORCE to not be added to
>> include/config/auto.conf's dependencies by auto.conf.cmd.
>> 
>> Or in other words - did you check (in conjunction with that other
>> patch fixing incremental rebuilds) whether incremental rebuilds
>> aren't again becoming full rebuilds because of this when there's
>> no XEN_CONFIG_EXPERT in the environment?
> 
> I have applied your patch on top of my branch and I do not see incremental 
> rebuilds becoming full rebuilds whether XEN_CONFIG_EXPERT is not in the
> environment.

Thanks; indeed I've meanwhile realized that the "export" here
should be taking care of avoiding that situation

Jan