All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: Improvements to clean and distclean targets
Date: Mon, 18 Jan 2016 18:19:11 +0000	[thread overview]
Message-ID: <569D2C9F.9070404@citrix.com> (raw)
In-Reply-To: <569D27A602000078000C82B6@prv-mh.provo.novell.com>

On 18/01/16 16:57, Jan Beulich wrote:
>>>> On 18.01.16 at 17:45, <andrew.cooper3@citrix.com> wrote:
>> On 18/01/16 16:41, Jan Beulich wrote:
>>>>>> On 18.01.16 at 17:27, <andrew.cooper3@citrix.com> wrote:
>>>> * Move '*~' and 'core' into the find rule.
>>> I don't understand this part: Where in the build process do such get
>>> generated? I'm tempted to instead recommend to just drop those
>>> from the rm invocation...
>> No idea about 'core' files, but *~ are emacs backup files.
> But emacs should clean up after itself; this shouldn't be the job
> of our clean rule.

Why? the point is to have a one-revision old version of the file to hand.

>
>> Most clean rules do "rm *.o *.d *~ core" in the local directory, but
>> there are some directories in the the public header area which don't get
>> recursed into, and therefore missed.
> Well - the same holds here than: I'd rather remove those than
> extend the bogus use.

Bogus is a matter of opinion, and there are a lot of emacs users (myself
included) who will disagree with you here.

~Andrew

  reply	other threads:[~2016-01-18 18:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 16:27 [PATCH] xen: Improvements to clean and distclean targets Andrew Cooper
2016-01-18 16:41 ` Jan Beulich
2016-01-18 16:45   ` Andrew Cooper
2016-01-18 16:57     ` Jan Beulich
2016-01-18 18:19       ` Andrew Cooper [this message]
2016-01-19  8:43         ` Jan Beulich
2016-01-19  9:38           ` Ian Campbell
2016-01-19 10:06             ` Juergen Gross
2016-01-19 10:11               ` Ian Campbell
2016-01-20 10:22             ` George Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569D2C9F.9070404@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.