From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Goldstein Subject: Re: [PATCH] x86: Convert shadow-paging to Kconfig Date: Mon, 18 Jan 2016 16:53:28 -0600 Message-ID: <569D6CE8.5050707@cardoe.com> References: <1453142404-8819-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8126549492618264707==" Return-path: In-Reply-To: <1453142404-8819-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper , Xen-devel Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============8126549492618264707== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PsxwNM8QLUBH9aKEbirVSBVFnC5sF8f8P" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PsxwNM8QLUBH9aKEbirVSBVFnC5sF8f8P Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 1/18/16 12:40 PM, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Reviewed-by: Doug Goldstein > --- > CC: Jan Beulich > CC: Doug Goldstein > --- > xen/arch/x86/Kconfig | 14 ++++++++++++++ > xen/arch/x86/Rules.mk | 4 ---- > xen/arch/x86/mm/shadow/Makefile | 2 +- > 3 files changed, 15 insertions(+), 5 deletions(-) >=20 > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig > index 4781b34..9869630 100644 > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -27,6 +27,20 @@ menu "Architecture Features" > =20 > source "arch/Kconfig" > =20 > +config SHADOW_PAGING > + bool "Shadow Paging" > + default y > + ---help--- > + Shadow paging is a software alternative to hardware paging s= upport > + (Intel EPT, AMD NPT) for use with HVM guests. > + > + It is required to run HVM guests for first-generation hardwa= re > + virtualisation (Intel VT-x, AMD SVM) which did not include h= ardware > + paging support. Under a small number of specific workloads,= shadow > + paging may also be deliberately used as a performance improv= ement. > + > + If unsure, say Y. > + > config BIGMEM > bool "big memory support" > default n > diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk > index a108d24..a1cdae0 100644 > --- a/xen/arch/x86/Rules.mk > +++ b/xen/arch/x86/Rules.mk > @@ -22,13 +22,9 @@ $(call as-insn-check,CFLAGS,CC,".equ \"x\"$$(comma)1= ", \ > -U__OBJECT_LABEL__ -DHAVE_GAS_QUOTED_SYM \ > '-D__OBJECT_LABEL__=3D$(subst $(BASEDIR)/,,$(CURD= IR))/$$@') > =20 > -shadow-paging ?=3D y > - > CFLAGS +=3D -mno-red-zone -mno-sse -fpic > CFLAGS +=3D -fno-asynchronous-unwind-tables > # -fvisibility=3Dhidden reduces -fpic cost, if it's available > ifneq ($(call cc-option,$(CC),-fvisibility=3Dhidden,n),n) > CFLAGS +=3D -DGCC_HAS_VISIBILITY_ATTRIBUTE > endif > - > -CFLAGS-$(shadow-paging) +=3D -DCONFIG_SHADOW_PAGING > diff --git a/xen/arch/x86/mm/shadow/Makefile b/xen/arch/x86/mm/shadow/M= akefile > index a07bc0c..df194ad 100644 > --- a/xen/arch/x86/mm/shadow/Makefile > +++ b/xen/arch/x86/mm/shadow/Makefile > @@ -1,4 +1,4 @@ > -ifeq ($(shadow-paging),y) > +ifdef CONFIG_SHADOW_PAGING > obj-y +=3D common.o guest_2.o guest_3.o guest_4.o > else > obj-y +=3D none.o >=20 --=20 Doug Goldstein --PsxwNM8QLUBH9aKEbirVSBVFnC5sF8f8P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0 iQJ8BAEBCgBmBQJWnWzrXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNTM5MEQ2RTNFMTkyNzlCNzVDMzIwOTVB MkJDMDNEQzg3RUQxQkQ0AAoJEKK8A9yH7RvU1PsP/1E0oWdCoXcDogsyHB0ivH9O S3uL+i1LQK2YfGzOuJUakjLEIHNV39WtPMkOwSNn457GCoACE9R5/XMA3D63itiK h5M3PNNT44sw8Ob8skAKbwCLwUE8Ug6ZYFSE729OcoC1JiEn8LRZbjzxKC0QFIFK ydY9qc5a12VflZ3Pj6vrrXj1C3I36auZbF78l5Ci3AQeEi803Ty7pllNbKe3TEn3 oM7hxERQgXvGltUCvR3zUFi0BAdVQzkT9JizwozyiAHRTyFrXvKvX/9E/FS3kS3V /idK/M3ssbASSzntfiqvd++eZPZVaIbicOuMUrWjZ5Dh0mSeAakbouAYzHKMzDoD UW8GeLEuHiFDucaG1hPKqXqkrvaUalVs2T6s2reiRu0cpjTHLXFRcEy0FRlRWevy fRgP1cPFemQtoo6nRVxfDsb3P3HBLn3LeSGkEGHXaH4fcGfD6Kdko0c/reSaxsg9 NkNE2IwVaFU5N/xJyyld5z4oxGIugWXaFDZtMXjZ4Hzy1Y7iKghVDH/lkNw3W5nV RpvB4hRfWykmfNTn36cZRjfePaUu2REMtAm6LcpJqdwF7sPUNWY8mWjQW1pxXwnf yK/RnhVv75A6i2Rbu5lzIPuXr23RgVPOjq5TvCZaFg+GGRnM1/92Aep9I93BCyIC D8HxGc1wPjTXdKEVpvYz =CSab -----END PGP SIGNATURE----- --PsxwNM8QLUBH9aKEbirVSBVFnC5sF8f8P-- --===============8126549492618264707== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8126549492618264707==--