From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLMrZ-0000Jm-LP for qemu-devel@nongnu.org; Mon, 18 Jan 2016 22:21:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aLMrW-0004le-GZ for qemu-devel@nongnu.org; Mon, 18 Jan 2016 22:21:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aLMrW-0004lZ-B1 for qemu-devel@nongnu.org; Mon, 18 Jan 2016 22:21:42 -0500 References: <1451372975-5048-1-git-send-email-zhang.zhanghailiang@huawei.com> <1451372975-5048-36-git-send-email-zhang.zhanghailiang@huawei.com> From: Jason Wang Message-ID: <569DABB4.7090008@redhat.com> Date: Tue, 19 Jan 2016 11:21:24 +0800 MIME-Version: 1.0 In-Reply-To: <1451372975-5048-36-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v13 35/39] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 12/29/2015 03:09 PM, zhanghailiang wrote: > For default buffer filter, its 'interval' value is zero, > so here we should accept zero interval. > > Signed-off-by: zhanghailiang > Reviewed-by: Yang Hongyang > Cc: Jason Wang > --- > v12: > - Add Reviewed-by tag > v11: > - Add comment > v10: > - new patch > --- > net/filter-buffer.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/net/filter-buffer.c b/net/filter-buffer.c > index 9cf3544..8abac94 100644 > --- a/net/filter-buffer.c > +++ b/net/filter-buffer.c > @@ -111,16 +111,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp) > FilterBufferState *s = FILTER_BUFFER(nf); > char *path = object_get_canonical_path_component(OBJECT(nf)); > > - /* > - * We may want to accept zero interval when VM FT solutions like MC > - * or COLO use this filter to release packets on demand. > - */ You'd better move this to the commit log for a better rationale of the patch. > - if (!s->interval) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", > - "a non-zero interval"); > - return; > - } > - > s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); > nf->is_default = !strcmp(path, "nop"); > /*