From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753494AbcASL6D (ORCPT ); Tue, 19 Jan 2016 06:58:03 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:53237 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbcASL55 (ORCPT ); Tue, 19 Jan 2016 06:57:57 -0500 Subject: Re: [PATCH RESEND] omap_hdq: fix usecount handling To: Andreas Kemnade , Evgeniy Polyakov , "hns@goldelico.com" , Fabian Frederick References: <1452948530-10639-1-git-send-email-andreas@kemnade.info> From: Vignesh R CC: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" Message-ID: <569E246E.40506@ti.com> Date: Tue, 19 Jan 2016 17:26:30 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1452948530-10639-1-git-send-email-andreas@kemnade.info> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/2016 06:18 PM, Andreas Kemnade wrote: > hdq_usecount was set to zero after a successful read, so > omap_hdq_put could not properly free resources which leads > e.g. to increasing usecounts in lsmod output > > Signed-off-by: Andreas Kemnade > --- Reviewed-by: Vignesh R Thanks, > drivers/w1/masters/omap_hdq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c > index 0e2f43b..a2eec97 100644 > --- a/drivers/w1/masters/omap_hdq.c > +++ b/drivers/w1/masters/omap_hdq.c > @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq) > > hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS, > ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK); > - hdq_data->hdq_usecount = 0; > > /* Write followed by a read, release the module */ > if (hdq_data->init_trans) { > -- Regards Vignesh