All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Ralf Ramsauer <ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree
Date: Tue, 19 Jan 2016 09:32:46 -0700	[thread overview]
Message-ID: <569E652E.5020907@wwwdotorg.org> (raw)
In-Reply-To: <1453209155-6213-3-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>

On 01/19/2016 06:12 AM, Ralf Ramsauer wrote:
> This patch enables the APB DMA high speed UARTs of the Jetson TK1.

In the cover letter, you mentioned that these ports are exposed on the 
expansion connector. It'd be useful to mention that fact here too, since 
the cover letter doesn't make it into the git commit log.

However, given that, I don't think we should apply this patch. We can't 
know ahead of time what hardware is connected to the expansion header; 
the pins aren't dedicated to be serial ports (they could be GPIOs and 
probably other functions too depending on the pinmux settings), and 
different people will connect different hardware or none at all. Hence, 
the default DT should not enable IO controllers for the pins on the 
expansion connector. The best approach these days is to use DT overlays. 
You may need to add some "hooks" into the Tegra base DT files to allow 
overlays to be used; they weren't written with overlays in mind.

  parent reply	other threads:[~2016-01-19 16:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19 13:12 [PATCH 0/2] ARM: tegra: Enable high speed UARTs of the Jetson TK1 Ralf Ramsauer
     [not found] ` <1453209155-6213-1-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-01-19 13:12   ` [PATCH 1/2] ARM: tegra: Fixed typo Ralf Ramsauer
     [not found]     ` <1453209155-6213-2-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-01-19 16:29       ` Stephen Warren
     [not found]         ` <569E6469.10301-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-01-19 16:36           ` Ralf Ramsauer
2016-01-19 13:12   ` [PATCH 2/2] ARM: tegra: Add high speed UARTs to Jetson TK1 device tree Ralf Ramsauer
     [not found]     ` <1453209155-6213-3-git-send-email-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-01-19 16:32       ` Stephen Warren [this message]
     [not found]         ` <569E652E.5020907-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-01-19 17:16           ` Ralf Ramsauer
     [not found]             ` <569E6F72.1000702-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-01-20 22:54               ` Stephen Warren
2016-01-20 23:13       ` Stephen Warren
     [not found]         ` <56A01499.9060509-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-01-21  0:10           ` Ralf Ramsauer
2016-01-26 16:26           ` Ralf Ramsauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569E652E.5020907@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.