From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/5] ARM: OMAP2+: Fix save_secure_ram_context for rodata Date: Tue, 19 Jan 2016 21:45:51 +0300 Message-ID: <569E845F.7080001@cogentembedded.com> References: <1453225734-16993-1-git-send-email-tony@atomide.com> <1453225734-16993-4-git-send-email-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453225734-16993-4-git-send-email-tony@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren , linux-omap@vger.kernel.org Cc: Nicolas Pitre , Richard Woodruff , Russell King , Kees Cook , Tero Kristo , Nishanth Menon , Laura Abbott , linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Hello. On 01/19/2016 08:48 PM, Tony Lindgren wrote: > We don't want to write to .text and we can move save_secure_ram_context > into .data as it all gets copied into SRAM anyways. > > Cc: Kees Cook > Cc: Laura Abbott > Cc: Nicolas Pitre > Cc: Nishanth Menon > Cc: Richard Woodruff > Cc: Russell King > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- > arch/arm/mach-omap2/sleep34xx.S | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S > index f7c7bf8..042e4fb 100644 > --- a/arch/arm/mach-omap2/sleep34xx.S > +++ b/arch/arm/mach-omap2/sleep34xx.S > @@ -93,8 +93,12 @@ ENTRY(enable_omap3630_toggle_l2_on_restore) > ldmfd sp!, {pc} @ restore regs and return > ENDPROC(enable_omap3630_toggle_l2_on_restore) > > - .text > -/* Function to call rom code to save secure ram context */ > +/* > + * Function to call rom code to save secure ram context, This gets s/,/./? > + * relocated to SRAM, so it can be all in .data section. Otherwise > + * we need to initialize api_params separately. > + */ > + .data > .align 3 > ENTRY(save_secure_ram_context) > stmfd sp!, {r4 - r11, lr} @ save registers on stack [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Tue, 19 Jan 2016 21:45:51 +0300 Subject: [PATCH 3/5] ARM: OMAP2+: Fix save_secure_ram_context for rodata In-Reply-To: <1453225734-16993-4-git-send-email-tony@atomide.com> References: <1453225734-16993-1-git-send-email-tony@atomide.com> <1453225734-16993-4-git-send-email-tony@atomide.com> Message-ID: <569E845F.7080001@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 01/19/2016 08:48 PM, Tony Lindgren wrote: > We don't want to write to .text and we can move save_secure_ram_context > into .data as it all gets copied into SRAM anyways. > > Cc: Kees Cook > Cc: Laura Abbott > Cc: Nicolas Pitre > Cc: Nishanth Menon > Cc: Richard Woodruff > Cc: Russell King > Cc: Tero Kristo > Signed-off-by: Tony Lindgren > --- > arch/arm/mach-omap2/sleep34xx.S | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S > index f7c7bf8..042e4fb 100644 > --- a/arch/arm/mach-omap2/sleep34xx.S > +++ b/arch/arm/mach-omap2/sleep34xx.S > @@ -93,8 +93,12 @@ ENTRY(enable_omap3630_toggle_l2_on_restore) > ldmfd sp!, {pc} @ restore regs and return > ENDPROC(enable_omap3630_toggle_l2_on_restore) > > - .text > -/* Function to call rom code to save secure ram context */ > +/* > + * Function to call rom code to save secure ram context, This gets s/,/./? > + * relocated to SRAM, so it can be all in .data section. Otherwise > + * we need to initialize api_params separately. > + */ > + .data > .align 3 > ENTRY(save_secure_ram_context) > stmfd sp!, {r4 - r11, lr} @ save registers on stack [...] MBR, Sergei