From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935064AbcATDwO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 22:52:14 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:48348 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933097AbcATDwH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 22:52:07 -0500
Subject: Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core
To: Mark Brown <broonie@kernel.org>
References: <1453185124-30809-1-git-send-email-puck.chen@hisilicon.com>
 <20160119173049.GQ6588@sirena.org.uk>
CC: <lee.jones@linaro.org>, <lgirdwood@gmail.com>,
        <linux-kernel@vger.kernel.org>, <yudongbin@hisilicon.com>,
        <saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
        <kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
        <z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
        <w.f@huawei.com>, <puck.chen@foxmail.com>, <shimingxing@hisilicon.com>,
        <oliver.fu@hisilicon.com>, <albert.lubing@hisilicon.com>,
        <chenxiang9@huawei.com>, <liuzixing@huawei.com>,
        <haojian.zhuang@linaro.org>, <qijiwen@hisilicon.com>,
        <peter.panshilin@hisilicon.com>, <dan.zhao@hisilicon.com>,
        <linuxarm@huawei.com>, <dev@lists.96boards.org>
From: chenfeng <puck.chen@hisilicon.com>
Message-ID: <569F043F.4040004@hisilicon.com>
Date: Wed, 20 Jan 2016 11:51:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20160119173049.GQ6588@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.192.172]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.569F0463.0153,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 82a44c91eec620dae2a7f8a6a7fbc84a
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 2016/1/20 1:30, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:31:59PM +0800, Chen Feng wrote:
> 
>> Chen Feng (5):
>>   doc: bindings: Add document for mfd hi665x PMIC
>>   doc: bindings: Document for hi655x regulator driver
>>   mfd: hi655x: Add hi665x pmic driver
>>   regulator: add regulator driver of hi655x pmic
>>   hisilicon/dts: Add hi655x pmic dts node
> 
> I've asked you several times to use subject lines reflecting the style
> for the subsystem for the DT bindings (and have just noticed that the
> same thing applies to the DTS update).
> 
Mark,

Really sorry for this.
Since I have not caught what you mean before this time.

I changed the style problem from doc:bindings to doc: bindings.
A blank space added. But this was not accurately what you mean.

I will change it like this:
bindings: mfd: hi655x: Add document for mfd hi665x PMIC
bindings: regulator: hi655x: Document for hi655x regulator driver
regulator: hi655x: add regulator driver of hi655x pmic
arm64: dts: hisilicon: Add hi655x pmic dts node

Will this be okay?

Have you also reviewed the regulator driver code? I changed it to
of_match and regulators_node without opening code.

Thanks again for your advice.

Feng