From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id A3F0E605FE for ; Wed, 20 Jan 2016 04:44:00 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id u0K4hpKe009952 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Tue, 19 Jan 2016 20:43:52 -0800 Received: from server.local (128.224.22.105) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.248.2; Tue, 19 Jan 2016 20:43:51 -0800 To: Ming Liu , References: <1451999565-3502-1-git-send-email-liu.ming50@gmail.com> <1451999565-3502-2-git-send-email-liu.ming50@gmail.com> <569E90F9.6020806@windriver.com> <569EB15C.9040502@gmail.com> From: Bruce Ashfield Message-ID: <569F1086.6030400@windriver.com> Date: Tue, 19 Jan 2016 23:43:50 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <569EB15C.9040502@gmail.com> Cc: yue.tao@windriver.com, Ming Liu Subject: Re: [PATCH 1/3] kernel.bbclass: do not install initramfs bundled kernel image X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2016 04:44:03 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 2016-01-19 4:57 PM, Ming Liu wrote: > > > On 01/19/2016 08:39 PM, Bruce Ashfield wrote: >> On 16-01-05 08:12 AM, Ming Liu wrote: >>> From: Ming Liu >>> >>> It makes no sense to install a initramfs bundled kernel image since >>> do_package does not depend on do_bundle_initramfs at all, otherwise, it >>> leads to a implicit kernel-image package depending on do_package run >>> before >>> or after do_bundle_initramfs. >> >> Again. So why not just add the ordering in the task dependencies ? > If we add a intertask dependency like: > add bundle_initramfs before do_install after do_deploy do_package > > Then it will somehow introduce a circular dependency as I described in > another mail. >> >> I'm probably missing something, which just means we need to tweak >> the commit log a bit more. > Maybe I should add some description in commit log about why I think we > could not introduce a intertask dependency as a fix. > That would be ideal, the more information the better. >> >> The code you are removing is conditional, and is run after an >> explicit kernel_do_compile is called, to rebuild the existing >> kernel configuration with an embedded initramfs (via alternate initrd). >> So outside of some ordering/parallel execution issues, I'm not seeing >> it as broken. > Yes, I agree, it will not break the kernel re-compiling, the problem I > want to fix here is just that it does not provide a certain way that we > could add initramfs bundled kernel image into a rootfs. > Speaking of breaking. What happens to existing users of INITRAMFS_IMAGE? Do their existing image types and bundling continue to work without modification ? Bruce > //Ming Liu >> >> Bruce >> >>> >>> Signed-off-by: Ming Liu >>> --- >>> meta/classes/kernel.bbclass | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >>> index 4ce1611..d1ca614 100644 >>> --- a/meta/classes/kernel.bbclass >>> +++ b/meta/classes/kernel.bbclass >>> @@ -179,10 +179,6 @@ do_bundle_initramfs () { >>> kernel_do_compile >>> mv -f ${KERNEL_OUTPUT} ${KERNEL_OUTPUT}.initramfs >>> mv -f ${KERNEL_OUTPUT}.bak ${KERNEL_OUTPUT} >>> - # Update install area >>> - echo "There is kernel image bundled with initramfs: >>> ${B}/${KERNEL_OUTPUT}.initramfs" >>> - install -m 0644 ${B}/${KERNEL_OUTPUT}.initramfs >>> ${D}/boot/${KERNEL_IMAGETYPE}-initramfs-${MACHINE}.bin >>> - echo "${B}/${KERNEL_OUTPUT}.initramfs" >>> fi >>> } >>> >>> >> >