From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4 1/3] can: sja1000: of: add per-compatible init hook
Date: Wed, 20 Jan 2016 11:22:21 +0100 [thread overview]
Message-ID: <569F5FDD.7050703@pengutronix.de> (raw)
In-Reply-To: <20160113155749.GB6219@localhost>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On 01/13/2016 04:57 PM, Damien Riegel wrote:
>> static int sp_probe(struct platform_device *pdev)
>> {
>> int err, irq = 0;
>> @@ -163,6 +177,9 @@ static int sp_probe(struct platform_device *pdev)
>> struct resource *res_mem, *res_irq = NULL;
>> struct sja1000_platform_data *pdata;
>> struct device_node *of = pdev->dev.of_node;
>> + const struct of_device_id *of_id;
>> + const struct sja1000_of_data *of_data = NULL;
>> + size_t priv_sz = 0;
>>
>> pdata = dev_get_platdata(&pdev->dev);
>> if (!pdata && !of) {
>> @@ -191,7 +208,13 @@ static int sp_probe(struct platform_device *pdev)
>> if (!irq && !res_irq)
>> return -ENODEV;
>>
>> - dev = alloc_sja1000dev(0);
>> + of_id = of_match_device(sp_of_table, &pdev->dev);
>> + if (of_id) {
>
> My personal preference here would be to test of_id && of_id->data. That
> way, we could avoid the declaration of nxp_data. It would also be a bit
> less error prone if someone adds a new compatible in the of device
> table.
Ok - please test v5.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-01-20 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 11:46 [PATCH v4 0/3] can: sja1000: support for technologic version Marc Kleine-Budde
2016-01-13 11:46 ` [PATCH v4 1/3] can: sja1000: of: add per-compatible init hook Marc Kleine-Budde
2016-01-13 15:57 ` Damien Riegel
2016-01-20 10:22 ` Marc Kleine-Budde [this message]
2016-01-19 20:08 ` Damien Riegel
2016-01-13 11:46 ` [PATCH v4 2/3] can: sja1000: add documentation for Technologic Systems version Marc Kleine-Budde
2016-01-13 11:46 ` [PATCH v4 3/3] can: sja1000: of: add compatibility with " Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569F5FDD.7050703@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=damien.riegel@savoirfairelinux.com \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.