On 1/20/16 7:14 AM, Andrew Cooper wrote: > On 20/01/16 12:29, Jan Beulich wrote: >>>>> On 18.01.16 at 16:53, wrote: >>> Possibly also: >>> 42940c046902 "x86/shadow: Fix missing newline in dprintk()" >> The affected statement compiles to nothing in a release build, which >> can be taken as an argument both ways. I lean towards not putting >> it in. >> >>> 6851e979874e "VT-d: use proper error codes in iommu_enable_x2apic_IR()" >> Since I had pulled this into our own tree already, and since you're >> now also viewing this as useful, I guess I will throw it in. >> >>> 0ce647ad6f70 "x86: suppress bogus log message" >> This being a purely cosmetic change, may I ask for the reason >> you consider this a backport candidate? > > The shear volume reduction in debug builds. > > XenServer ships both a release and a debug hypervisor for first-line > triage of customer issues. As such, "only affecting a debug build" > isn't a relevant consideration for us, and I expect we are not alone here. > > ~Andrew > I will likely locally backport this one myself if it doesn't land in 4.6.1 because we too have a debug variant and a release variant. -- Doug Goldstein