From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [PATCH 0/4] virtio support for container
Date: Fri, 22 Jan 2016 14:04:41 +0800
Message-ID: <56A1C679.3050407@intel.com>
References: <1446748276-132087-1-git-send-email-jianfeng.tan@intel.com>
 <058a01d14c7b$5cdc60d0$16952270$@samsung.com> <5693CFE4.4060405@intel.com>
 <009a01d14d0c$3ab6cd60$b0246820$@samsung.com>
 <CAGSMBPMTCmPvOfCv1RzrCzPK5xNE7oP_WfieyB8gaqD+dNJmGA@mail.gmail.com>
 <00b101d14d14$bab82510$30286f30$@samsung.com> <5694BE75.7010708@intel.com>
 <00d901d14d26$d04fc600$70ef5200$@samsung.com>
 <CABHD4K8CTYu6C3oXLaxLupUO17e3-d1gSTSzOxOPBZ9k3-i4Ww@mail.gmail.com>
 <56951357.2030008@intel.com>
 <CABHD4K9G3_1BBo=QZ-VhzSYCsDf9VASWKsz922a-d610UP6d_g@mail.gmail.com>
 <5695275A.5050203@intel.com>
 <CABHD4K-sV4k8r1PWUAc+ApAg=uk2++qQqFDZkAWvyKR8Lq4bXQ@mail.gmail.com>
 <56969A3F.1040503@intel.com>
 <CABHD4K_qOe-L4EOCxZeON7YDJXT50gBSeAL4GxRAGYa7Y+PNqw@mail.gmail.com>
 <5697896C.2000804@intel.com>
 <CABHD4K_RL_FR2PbPbUj7Chh4B2=3GpWGVhgKK3pUPJFsHbtNnw@mail.gmail.com>
 <5698941E.5020101@intel.com>
 <CABHD4K-mCgU3dD5AEBW044bmc+r1FjXJVRJxkpV2T9LsdckAgA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: nakajima.yoshihiro@lab.ntt.co.jp, "Michael S. Tsirkin" <mst@redhat.com>,
 dev@dpdk.org, ann.zhuangyanying@huawei.com
To: Amit Tomer <amittomer25@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 979BC8F9B
 for <dev@dpdk.org>; Fri, 22 Jan 2016 07:04:45 +0100 (CET)
In-Reply-To: <CABHD4K-mCgU3dD5AEBW044bmc+r1FjXJVRJxkpV2T9LsdckAgA@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Amit,

On 1/20/2016 11:19 PM, Amit Tomer wrote:
> Hello,
>
>> For this case, please use --single-file option because it creates much more
>> than 8 fds, which can be handled by vhost-user sendmsg().
> Thanks, I'm able to verify it by sending ARP packet from container to
> host on arm64. But sometimes, I do see following message while running
> l2fwd in container(pointed by Rich).
>
> EAL: Master lcore 0 is ready (tid=8a7a3000;cpuset=[0])
> EAL: lcore 1 is ready (tid=89cdf050;cpuset=[1])
> Notice: odd number of ports in portmask.
> Lcore 0: RX port 0
> Initializing port 0... PANIC in kick_all_vq():
> TUNSETVNETHDRSZ failed: Inappropriate ioctl for device
>
> How it could be avoided?
>
> Thanks,
> Amit.

Thanks for pointing out this bug. Actually it's caused by one of my 
fault. So vhost-user cannot work well.
Below change can help start vhost-user.

diff --git a/drivers/net/virtio/vhost.c b/drivers/net/virtio/vhost.c
index e423e02..dbca374 100644
--- a/drivers/net/virtio/vhost.c
+++ b/drivers/net/virtio/vhost.c
@@ -483,8 +483,9 @@ static void kick_all_vq(struct virtio_hw *hw)
         uint64_t features = hw->guest_features;
         features &= ~(1ull << VIRTIO_NET_F_MAC);
         vhost_call(hw, VHOST_MSG_SET_FEATURES, &features);
-       if (ioctl(hw->backfd, TUNSETVNETHDRSZ, &hw->vtnet_hdr_size) == -1)
-               rte_panic("TUNSETVNETHDRSZ failed: %s\n", strerror(errno));
+       if (hw->type == VHOST_KERNEL)
+               if (ioctl(hw->backfd, TUNSETVNETHDRSZ, 
&hw->vtnet_hdr_size) == -1)
+                       rte_panic("TUNSETVNETHDRSZ failed: %s\n", 
strerror(errno));
         PMD_DRV_LOG(INFO, "set features:%"PRIx64"\n", features);


Thanks,
Jianfeng